The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25783a2fecb69d613b1f3cfa9ea9e347b87887de

commit 25783a2fecb69d613b1f3cfa9ea9e347b87887de
Author: twifkak <twifkak@chromium.org>
Date: Fri Oct 07 17:11:46 2016

Add Precache.CacheStatus.NonPrefetch.FromPrecache.

This UMA is like Precache.CacheStatus.NonPrefetch, but only for requests
where the URL matches an unused entry in the precache_urls table -- that
is, first requests for URLs retrieved as part of prefetching. Misses
would be reported by this metric as a result of expiration or eviction.

Changed PrecacheURLTable::Is*URL*() methods with varying WHERE clauses to
PrecacheURLTable::GetURLInfo() and a PrecacheURLInfo struct containing the
SELECTed columns. This allows us to report this metric not just for first
requests for precached URLs (i.e. where is_precached = 1), but for all such
requests. This should cause the metrics sampled to be weighted similarly to
HttpCache.Pattern.

BUG= 650773 

Review-Url: https://codereview.chromium.org/2364873004
Cr-Commit-Position: refs/heads/master@{#423892}

[modify] https://crrev.com/25783a2fecb69d613b1f3cfa9ea9e347b87887de/components/precache/content/precache_manager_unittest.cc
[modify] https://crrev.com/25783a2fecb69d613b1f3cfa9ea9e347b87887de/components/precache/core/precache_database.cc
[modify] https://crrev.com/25783a2fecb69d613b1f3cfa9ea9e347b87887de/components/precache/core/precache_database_unittest.cc
[modify] https://crrev.com/25783a2fecb69d613b1f3cfa9ea9e347b87887de/components/precache/core/precache_url_table.cc
[modify] https://crrev.com/25783a2fecb69d613b1f3cfa9ea9e347b87887de/components/precache/core/precache_url_table.h
[modify] https://crrev.com/25783a2fecb69d613b1f3cfa9ea9e347b87887de/components/precache/core/precache_url_table_unittest.cc
[modify] https://crrev.com/25783a2fecb69d613b1f3cfa9ea9e347b87887de/tools/metrics/histograms/histograms.xml

[Automated comment] Less than 2 weeks to go before stable on M54, manual review required.

For manual reviewer: This is not a security/privacy/crash fix; just a new UMA. Was suggesting it because it's a low-impact change, but no worries if you think it's too risky.

Sorry, too late.

Your change meets the bar and is auto-approved for M55 (branch: 2883)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3426a9beee6d0bdf664ece23c26e3d452c96123

commit f3426a9beee6d0bdf664ece23c26e3d452c96123
Author: Devin Mullins <twifkak@google.com>
Date: Thu Oct 13 22:28:25 2016

Add Precache.CacheStatus.NonPrefetch.FromPrecache.

This UMA is like Precache.CacheStatus.NonPrefetch, but only for requests
where the URL matches an unused entry in the precache_urls table -- that
is, first requests for URLs retrieved as part of prefetching. Misses
would be reported by this metric as a result of expiration or eviction.

Changed PrecacheURLTable::Is*URL*() methods with varying WHERE clauses to
PrecacheURLTable::GetURLInfo() and a PrecacheURLInfo struct containing the
SELECTed columns. This allows us to report this metric not just for first
requests for precached URLs (i.e. where is_precached = 1), but for all such
requests. This should cause the metrics sampled to be weighted similarly to
HttpCache.Pattern.

BUG= 650773 

Review-Url: https://codereview.chromium.org/2364873004
Cr-Commit-Position: refs/heads/master@{#423892}
(cherry picked from commit 25783a2fecb69d613b1f3cfa9ea9e347b87887de)

Review URL: https://codereview.chromium.org/2413423002 .

Cr-Commit-Position: refs/branch-heads/2883@{#98}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/f3426a9beee6d0bdf664ece23c26e3d452c96123/components/precache/content/precache_manager_unittest.cc
[modify] https://crrev.com/f3426a9beee6d0bdf664ece23c26e3d452c96123/components/precache/core/precache_database.cc
[modify] https://crrev.com/f3426a9beee6d0bdf664ece23c26e3d452c96123/components/precache/core/precache_database_unittest.cc
[modify] https://crrev.com/f3426a9beee6d0bdf664ece23c26e3d452c96123/components/precache/core/precache_url_table.cc
[modify] https://crrev.com/f3426a9beee6d0bdf664ece23c26e3d452c96123/components/precache/core/precache_url_table.h
[modify] https://crrev.com/f3426a9beee6d0bdf664ece23c26e3d452c96123/components/precache/core/precache_url_table_unittest.cc
[modify] https://crrev.com/f3426a9beee6d0bdf664ece23c26e3d452c96123/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3426a9beee6d0bdf664ece23c26e3d452c96123

commit f3426a9beee6d0bdf664ece23c26e3d452c96123
Author: Devin Mullins <twifkak@google.com>
Date: Thu Oct 13 22:28:25 2016

Add Precache.CacheStatus.NonPrefetch.FromPrecache.

This UMA is like Precache.CacheStatus.NonPrefetch, but only for requests
where the URL matches an unused entry in the precache_urls table -- that
is, first requests for URLs retrieved as part of prefetching. Misses
would be reported by this metric as a result of expiration or eviction.

Changed PrecacheURLTable::Is*URL*() methods with varying WHERE clauses to
PrecacheURLTable::GetURLInfo() and a PrecacheURLInfo struct containing the
SELECTed columns. This allows us to report this metric not just for first
requests for precached URLs (i.e. where is_precached = 1), but for all such
requests. This should cause the metrics sampled to be weighted similarly to
HttpCache.Pattern.

BUG= 650773 

Review-Url: https://codereview.chromium.org/2364873004
Cr-Commit-Position: refs/heads/master@{#423892}
(cherry picked from commit 25783a2fecb69d613b1f3cfa9ea9e347b87887de)

Review URL: https://codereview.chromium.org/2413423002 .

Cr-Commit-Position: refs/branch-heads/2883@{#98}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/f3426a9beee6d0bdf664ece23c26e3d452c96123/components/precache/content/precache_manager_unittest.cc
[modify] https://crrev.com/f3426a9beee6d0bdf664ece23c26e3d452c96123/components/precache/core/precache_database.cc
[modify] https://crrev.com/f3426a9beee6d0bdf664ece23c26e3d452c96123/components/precache/core/precache_database_unittest.cc
[modify] https://crrev.com/f3426a9beee6d0bdf664ece23c26e3d452c96123/components/precache/core/precache_url_table.cc
[modify] https://crrev.com/f3426a9beee6d0bdf664ece23c26e3d452c96123/components/precache/core/precache_url_table.h
[modify] https://crrev.com/f3426a9beee6d0bdf664ece23c26e3d452c96123/components/precache/core/precache_url_table_unittest.cc
[modify] https://crrev.com/f3426a9beee6d0bdf664ece23c26e3d452c96123/tools/metrics/histograms/histograms.xml

[Automated comment] removing mislabelled merge-merged-2840