New issue
Advanced search Search tips

Issue 650755 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

WmWindowAura::OnWindowVisibilityChanged() assumes this->window_ == window

Project Member Reported by sky@chromium.org, Sep 27 2016

Issue description

That isn't the case though. OnWindowVisibilityChanged() may be supplied a different window.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/598ab1479d421bc56bec0659bb6aacfaed6d6959

commit 598ab1479d421bc56bec0659bb6aacfaed6d6959
Author: sky <sky@chromium.org>
Date: Tue Sep 27 19:36:59 2016

Fixes bug in WmWindowAura::OnWindowVisibilityChanged()

The code was assuming window was this->window_, which is not
necessarily the case.

BUG= 650755 
TEST=none
R=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2369413002
Cr-Commit-Position: refs/heads/master@{#421298}

[modify] https://crrev.com/598ab1479d421bc56bec0659bb6aacfaed6d6959/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/598ab1479d421bc56bec0659bb6aacfaed6d6959/ui/aura/window_observer.h

Comment 3 by sky@chromium.org, Sep 28 2016

Status: Fixed (was: Started)

Comment 4 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55
Status: Verified (was: Fixed)
Closing bug as per comment #3

Sign in to add a comment