Issue 650751 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	osh...@chromium.org
Closed:	Sep 2016
Cc:	█ lpique@chromium.org sky@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
M-55 VerifyIn-56 VerifyIn-59 VerifyIn-60 VerifyIn-61

Dim layer for modal windows does not get destroyed because the same window is added to the modal window list.

Project Member Reported by osh...@chromium.org, Sep 27 2016

Issue description

chrome side bug for b/31634118

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1246e525e255367df004c528c93009fefb645e0

commit a1246e525e255367df004c528c93009fefb645e0
Author: oshima <oshima@chromium.org>
Date: Wed Sep 28 17:31:13 2016

Use WmLayoutManager::OnChildWindowVisibilityChanged to update the system modal state.

The issue in WmWindowObserver::OnChildWindowVisibility is fixed in

https://codereview.chromium.org/2369413002/

but it's probably better to use WmLayoutManager::OnChildWindowVisibilityChanged because it's WmLayoutManager.

BUG= crbug.com/650751 
TEST=covered by unit tests. tested manulally with the test app in the bug.

Review-Url: https://codereview.chromium.org/2374613004
Cr-Commit-Position: refs/heads/master@{#421558}

[modify] https://crrev.com/a1246e525e255367df004c528c93009fefb645e0/ash/common/wm/system_modal_container_layout_manager.cc
[modify] https://crrev.com/a1246e525e255367df004c528c93009fefb645e0/ash/common/wm/system_modal_container_layout_manager.h
[modify] https://crrev.com/a1246e525e255367df004c528c93009fefb645e0/ash/wm/system_modal_container_layout_manager_unittest.cc