New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 650751 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Dim layer for modal windows does not get destroyed because the same window is added to the modal window list.

Project Member Reported by osh...@chromium.org, Sep 27 2016

Issue description

chrome side bug for b/31634118

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1246e525e255367df004c528c93009fefb645e0

commit a1246e525e255367df004c528c93009fefb645e0
Author: oshima <oshima@chromium.org>
Date: Wed Sep 28 17:31:13 2016

Use WmLayoutManager::OnChildWindowVisibilityChanged to update the system modal state.

The issue in WmWindowObserver::OnChildWindowVisibility is fixed in

https://codereview.chromium.org/2369413002/

but it's probably better to use WmLayoutManager::OnChildWindowVisibilityChanged because it's WmLayoutManager.

BUG= crbug.com/650751 
TEST=covered by unit tests. tested manulally with the test app in the bug.

Review-Url: https://codereview.chromium.org/2374613004
Cr-Commit-Position: refs/heads/master@{#421558}

[modify] https://crrev.com/a1246e525e255367df004c528c93009fefb645e0/ash/common/wm/system_modal_container_layout_manager.cc
[modify] https://crrev.com/a1246e525e255367df004c528c93009fefb645e0/ash/common/wm/system_modal_container_layout_manager.h
[modify] https://crrev.com/a1246e525e255367df004c528c93009fefb645e0/ash/wm/system_modal_container_layout_manager_unittest.cc

Comment 2 by osh...@chromium.org, Sep 28 2016

Status: Fixed (was: Started)

Comment 3 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 4 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 5 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment