New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 650729 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Can't inspect large Maps

Reported by roblour...@gmail.com, Sep 27 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 Safari/537.36

Steps to reproduce the problem:
Have a Map of more than 500 or so elements (see screenshot attached)

What is the expected behavior?
You should be able to see all the items in the Map, just as when you have a very large array or an object with lots of properties.

What went wrong?
The [[Entries]] property isn't visible

Did this work before? N/A 

Chrome version: 53.0.2785.116  Channel: stable
OS Version: OS X 10.11.6
Flash Version: Shockwave Flash 23.0 r0

I see that it isn't provided by the remote debug protocol.
 
Screen Shot 2016-09-27 at 10.48.10 AM.png
13.5 KB View Download
Cc: kozyatinskiy@chromium.org
Owner: yangguo@chromium.org
Status: Assigned (was: Unconfirmed)
Cc: -kozyatinskiy@chromium.org yangguo@chromium.org
Owner: kozyatinskiy@chromium.org
It's inspector issue.
Started:
https://codereview.chromium.org/2373753003/
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/bcedfb029c992f2527db0d9d7766528e356ffe12

commit bcedfb029c992f2527db0d9d7766528e356ffe12
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Thu Sep 29 00:09:35 2016

[inspector] don't truncate [[Entries]] from Runtime.getProperties

BUG= chromium:650729 
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2373753003
Cr-Commit-Position: refs/heads/master@{#39843}

[modify] https://crrev.com/bcedfb029c992f2527db0d9d7766528e356ffe12/src/inspector/v8-debugger.cc

Labels: -Type-Bug Merge-Request-54 Type-Bug-Regression
Since it's regression. Can we merge it into beta?

Comment 5 by dimu@chromium.org, Sep 29 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)

Comment 6 by dimu@chromium.org, Sep 29 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 30 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89014ca66f938be2b35f12155d6869e7c78ec985

commit 89014ca66f938be2b35f12155d6869e7c78ec985
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Sep 30 06:08:19 2016

[DevTools] don't truncate [[Entries]] from Runtime.getProperties

BUG= chromium:650729 
TBR=dgozman@chromium.org

Review URL: https://codereview.chromium.org/2383683002 .

Committed: https://crrev.com/bcedfb029c992f2527db0d9d7766528e356ffe12
Cr-Original-Commit-Position: refs/heads/master@{#39843}
Cr-Commit-Position: refs/branch-heads/2840@{#597}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/89014ca66f938be2b35f12155d6869e7c78ec985/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/60ab52e78ec1be95cff49107c36363f072328620

commit 60ab52e78ec1be95cff49107c36363f072328620
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Mon Oct 03 21:21:58 2016

[inspector] test Runtime.getProperties for set and map [[Entries]]

Added a test that Runtime.getProperties doesn't truncate Set and Map properties in [[Entries]] in internalProperties.

BUG= chromium:650729 
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2376863002
Cr-Commit-Position: refs/heads/master@{#39940}

[add] https://crrev.com/60ab52e78ec1be95cff49107c36363f072328620/test/inspector/runtime/set-or-map-entries-expected.txt
[add] https://crrev.com/60ab52e78ec1be95cff49107c36363f072328620/test/inspector/runtime/set-or-map-entries.js

Comment 10 by ajha@chromium.org, Oct 5 2016

Labels: TE-Verified-54.0.2840.50 TE-Verified-M54
Verified the merge on the latest M-54(54.0.2840.50) on Mac OS 10.11.6 and this is working as intended. Attached is the screenshot of the same.


650729.png
37.7 KB View Download
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89014ca66f938be2b35f12155d6869e7c78ec985

commit 89014ca66f938be2b35f12155d6869e7c78ec985
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Sep 30 06:08:19 2016

[DevTools] don't truncate [[Entries]] from Runtime.getProperties

BUG= chromium:650729 
TBR=dgozman@chromium.org

Review URL: https://codereview.chromium.org/2383683002 .

Committed: https://crrev.com/bcedfb029c992f2527db0d9d7766528e356ffe12
Cr-Original-Commit-Position: refs/heads/master@{#39843}
Cr-Commit-Position: refs/branch-heads/2840@{#597}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/89014ca66f938be2b35f12155d6869e7c78ec985/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

Sign in to add a comment