Issue metadata
Sign in to add a comment
|
Can't inspect large Maps
Reported by
roblour...@gmail.com,
Sep 27 2016
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 Safari/537.36 Steps to reproduce the problem: Have a Map of more than 500 or so elements (see screenshot attached) What is the expected behavior? You should be able to see all the items in the Map, just as when you have a very large array or an object with lots of properties. What went wrong? The [[Entries]] property isn't visible Did this work before? N/A Chrome version: 53.0.2785.116 Channel: stable OS Version: OS X 10.11.6 Flash Version: Shockwave Flash 23.0 r0 I see that it isn't provided by the remote debug protocol.
,
Sep 28 2016
It's inspector issue. Started: https://codereview.chromium.org/2373753003/
,
Sep 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/bcedfb029c992f2527db0d9d7766528e356ffe12 commit bcedfb029c992f2527db0d9d7766528e356ffe12 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Thu Sep 29 00:09:35 2016 [inspector] don't truncate [[Entries]] from Runtime.getProperties BUG= chromium:650729 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2373753003 Cr-Commit-Position: refs/heads/master@{#39843} [modify] https://crrev.com/bcedfb029c992f2527db0d9d7766528e356ffe12/src/inspector/v8-debugger.cc
,
Sep 29 2016
Since it's regression. Can we merge it into beta?
,
Sep 29 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 29 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89014ca66f938be2b35f12155d6869e7c78ec985 commit 89014ca66f938be2b35f12155d6869e7c78ec985 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Sep 30 06:08:19 2016 [DevTools] don't truncate [[Entries]] from Runtime.getProperties BUG= chromium:650729 TBR=dgozman@chromium.org Review URL: https://codereview.chromium.org/2383683002 . Committed: https://crrev.com/bcedfb029c992f2527db0d9d7766528e356ffe12 Cr-Original-Commit-Position: refs/heads/master@{#39843} Cr-Commit-Position: refs/branch-heads/2840@{#597} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/89014ca66f938be2b35f12155d6869e7c78ec985/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp
,
Sep 30 2016
,
Oct 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/60ab52e78ec1be95cff49107c36363f072328620 commit 60ab52e78ec1be95cff49107c36363f072328620 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Mon Oct 03 21:21:58 2016 [inspector] test Runtime.getProperties for set and map [[Entries]] Added a test that Runtime.getProperties doesn't truncate Set and Map properties in [[Entries]] in internalProperties. BUG= chromium:650729 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2376863002 Cr-Commit-Position: refs/heads/master@{#39940} [add] https://crrev.com/60ab52e78ec1be95cff49107c36363f072328620/test/inspector/runtime/set-or-map-entries-expected.txt [add] https://crrev.com/60ab52e78ec1be95cff49107c36363f072328620/test/inspector/runtime/set-or-map-entries.js
,
Oct 5 2016
Verified the merge on the latest M-54(54.0.2840.50) on Mac OS 10.11.6 and this is working as intended. Attached is the screenshot of the same.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89014ca66f938be2b35f12155d6869e7c78ec985 commit 89014ca66f938be2b35f12155d6869e7c78ec985 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Sep 30 06:08:19 2016 [DevTools] don't truncate [[Entries]] from Runtime.getProperties BUG= chromium:650729 TBR=dgozman@chromium.org Review URL: https://codereview.chromium.org/2383683002 . Committed: https://crrev.com/bcedfb029c992f2527db0d9d7766528e356ffe12 Cr-Original-Commit-Position: refs/heads/master@{#39843} Cr-Commit-Position: refs/branch-heads/2840@{#597} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/89014ca66f938be2b35f12155d6869e7c78ec985/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by seththompson@chromium.org
, Sep 27 2016Owner: yangguo@chromium.org
Status: Assigned (was: Unconfirmed)