There are places where this is being triggered from. It shouldn't be possible to do so for Stable.
This is marked as a stable blocker. We're looking to ship that very soon, so please try to have this bug fixed no later than first week of October so that it can be merged to branch 2840 ASAP.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96b3ce4784ea3b764bf5425baa671d15334d373c commit 96b3ce4784ea3b764bf5425baa671d15334d373c Author: dfalcantara <dfalcantara@chromium.org> Date: Wed Sep 28 23:42:09 2016 [Download Home] More effectively disable Download Home * Consolidate all the places where the Finch flag is checked. * Cache the Finch flag in SharedPreferences on the off-chance that we need it before native has been loaded. This can happen if someone tries to open Download Home via a notification after Chrome has died. * More effectively determine how to open Download Home when there's no tab or Activity. BUG= 650727 Review-Url: https://codereview.chromium.org/2372313002 Cr-Commit-Position: refs/heads/master@{#421683} [modify] https://crrev.com/96b3ce4784ea3b764bf5425baa671d15334d373c/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java [modify] https://crrev.com/96b3ce4784ea3b764bf5425baa671d15334d373c/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java [modify] https://crrev.com/96b3ce4784ea3b764bf5425baa671d15334d373c/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java [modify] https://crrev.com/96b3ce4784ea3b764bf5425baa671d15334d373c/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java [modify] https://crrev.com/96b3ce4784ea3b764bf5425baa671d15334d373c/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java [modify] https://crrev.com/96b3ce4784ea3b764bf5425baa671d15334d373c/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java [modify] https://crrev.com/96b3ce4784ea3b764bf5425baa671d15334d373c/chrome/android/java/src/org/chromium/chrome/browser/util/IntentUtils.java
Going to merge request while I figure out how to merge it backwards. There are definitely conflicts at this stage.
Your change meets the bar and is auto-approved for M54 (branch: 2840)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6923a4a997a92d18b64a62d656392a980afa7e02 commit 6923a4a997a92d18b64a62d656392a980afa7e02 Author: dfalcantara@chromium.org <dfalcantara@chromium.org> Date: Thu Sep 29 01:18:34 2016 [2840 Download Home] More effectively disable Download Home * Consolidate all the places where the Finch flag is checked. * Cache the Finch flag in SharedPreferences on the off-chance that we need it before native has been loaded. This can happen if someone tries to open Download Home via a notification after Chrome has died. * More effectively determine how to open Download Home when there's no tab or Activity. BUG= 650727 TBR=ianwen Original Review-Url: https://codereview.chromium.org/2372313002 Original Cr-Commit-Position: refs/heads/master@{#421683} Review URL: https://codereview.chromium.org/2380683004 . Cr-Commit-Position: refs/branch-heads/2840@{#572} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/6923a4a997a92d18b64a62d656392a980afa7e02/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java [modify] https://crrev.com/6923a4a997a92d18b64a62d656392a980afa7e02/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java [modify] https://crrev.com/6923a4a997a92d18b64a62d656392a980afa7e02/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java [modify] https://crrev.com/6923a4a997a92d18b64a62d656392a980afa7e02/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java [modify] https://crrev.com/6923a4a997a92d18b64a62d656392a980afa7e02/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java [modify] https://crrev.com/6923a4a997a92d18b64a62d656392a980afa7e02/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java [modify] https://crrev.com/6923a4a997a92d18b64a62d656392a980afa7e02/chrome/android/java/src/org/chromium/chrome/browser/util/IntentUtils.java
Comment 1 by ligim...@chromium.org
, Sep 27 2016