New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 650714 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

power_FlashVideoSuspend breaks DUTs

Reported by jrbarnette@chromium.org, Sep 27 2016

Issue description

From time to time I see older model boards (especially ZGB, Mario, and
Butterfly) that go offline after running power_FlashVideoSuspend.
Those board don't support servo, so if the DUT doesn't wake up, it stays
down and has to be repaired manually.  The failures drain the BVT pool,
and can lead to tests not running.

We need to quit running this test on those old boards.  I can imagine
various things we might do, but the simplest is probably just to make
the test depend on the 'servo' label.

 
Cc: owenlin@chromium.org rohi...@chromium.org vsu...@chromium.org wuchengli@chromium.org avkodipelli@chromium.org posciak@chromium.org
Owner: owenlin@chromium.org
Status: Assigned (was: Unconfirmed)
I understand that there's also a regression causing the
test to fail; that should be tracked in a different bug.

Do all boards have at least one DUT that connects with servo? I wonder if we'll still run the test on most boards after adding servo label.
Not all boards have servo.  Those boards won't run this test.

Note that I don't envision an acceptable alternative to blocking
the test on boards that don't support servo:  We can't afford
regular manual repairs because of failures like this.
A ZGB in the BVT pool went offline last night testing
a Beta release:
    http://cautotest/tko/retrieve_logs.cgi?job=/results/78496003-chromeos-test/

This is one of the critically short boards that can't afford
this kind of outage, and can't support servo.

What is our plan to move forward with a CL today?

https://chromium-review.googlesource.com/#/c/391212/

I'm moving forward with committing this CL, as soon as
the CQ is healthy, and I find a willing reviewer.

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ec819e05834cc5ff6806fd4e9ed459e0b63ddf6a

commit ec819e05834cc5ff6806fd4e9ed459e0b63ddf6a
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Thu Sep 29 17:00:15 2016

Restrict power_FlashVideoSuspend to DUTs with servo.

The test has been taking DUTs offline.  DUTs without servo that fail
this test then need manual repair.  So, require a servo to run the
test.

BUG= chromium:650714 
TEST=None

Change-Id: I70c5908f4a72390404648b9993b68c645b7f59d8
Reviewed-on: https://chromium-review.googlesource.com/391212
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Wu-cheng Li <wuchengli@chromium.org>

[modify] https://crrev.com/ec819e05834cc5ff6806fd4e9ed459e0b63ddf6a/client/site_tests/power_FlashVideoSuspend/control.html5

Labels: Merge-Request-54
We need to stop this test on R54 as well.

Comment 8 by dimu@chromium.org, Oct 6 2016

Labels: -Merge-Request-54 Merge-Review-54 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M54, manual review required.
Hi Richard,

Could you take this issue? I think add servo dependencies is enough for fixing the issue.
Owner: jrbarnette@chromium.org
Status: Fixed (was: Assigned)

Comment 11 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 12 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59
Labels: -Hotlist-Merge-Review -Merge-Review-54

Sign in to add a comment