New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 650713 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 650940



Sign in to add a comment

Release branch trybots are failing on "no such option: --git-cache-dir"

Project Member Reported by bhthompson@google.com, Sep 27 2016

Issue description

OS: Chrome

When attempting to run a release trybot on R53 or R54 the builder fails when it tries to call cbuildbot with --git-cache-dir. 

For example `./cbuildbot --remote --buildbot --branch=release-R54-8743.B lulu-cheets-release` resulted in
https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/cheets_release/builds/1/

which fails in bootstrap
...
10:00:25: INFO: RunCommand: chromite/bin/cbuildbot lulu-cheets-release --buildroot /b/cbuild/internal_master --buildnumber 1 --git-cache-dir /b/cros_git_cache --buildbot --branch release-R54-8743.B --remote-version 4 --sourceroot /b/build/slave/cheets_release/build --nobootstrap in /tmp/cbuildbot-tmpQgG8QD/tmpDg1PXP
Usage: cbuildbot [options] buildbot_config [buildbot_config ...]

cbuildbot: error: no such option: --git-cache-dir
...

I suspect this is rooted in https://chromium-review.googlesource.com/387106 ?
 
The "correct" solution is built into cbuildbot, which has a way to strip out unsupported arguments when invoking old versions of itself during bootstrap. But I don't remember how that works and will have to go look it up.

The "quick" solution is to turn off the option in the recipe for a little while.

How quick a solution do we need?
Cc: alberto@chromium.org
I think it depends on what comes up, for the particular case I was trying to get this trybot for we can probably get by with a ToT build.

It is quite possible others will hit this eventually (e.g. someone building say an old firmware or factory branch manually) which may up the priority, the problem is when this does come up it will probably get urgent for the impacted project quickly. On the other hand it may be no one sees a problem for weeks.

Comment 3 by nxia@chromium.org, Sep 27 2016

we do check for branch version before appending this option. I'll take a look what's going wrong. 

Comment 4 by d...@chromium.org, Sep 27 2016

Owner: d...@chromium.org
Status: Started (was: Untriaged)
I'm working on a recipe patch to fix this.

Comment 5 by nxia@google.com, Sep 27 2016

made a quick fix in remote_try. Looks like it's running. but it's remote try with --debug. 


https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/cheets_release/builds/3

Comment 6 by nxia@google.com, Sep 27 2016

removed --debug. Please find the job at

https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/cheets_release/builds/4

We'll work on the fix.

Comment 7 by nxia@chromium.org, Sep 27 2016

Cc: nxia@chromium.org
Project Member

Comment 8 by sheriffbot@chromium.org, Sep 28 2016

Labels: Hotlist-Google

Comment 9 by nxia@chromium.org, Sep 28 2016

Blocking: 650940
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/bb79be9871a84063bdae21500debbfe76520afd6

commit bb79be9871a84063bdae21500debbfe76520afd6
Author: Don Garrett <dgarrett@google.com>
Date: Tue Sep 27 18:14:07 2016

cbuildbot: Add api version to --git-cache-dir.

Also, use the same version for the deprecated --repo-cache option.

BUG= chromium:650713 
TEST=run_tests

Change-Id: I03c4636b87f93fe786079f59c7200bf22383e5c4
Reviewed-on: https://chromium-review.googlesource.com/389873
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Commit-Queue: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/bb79be9871a84063bdae21500debbfe76520afd6/scripts/cbuildbot.py
[modify] https://crrev.com/bb79be9871a84063bdae21500debbfe76520afd6/cbuildbot/constants.py

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 29 2016

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/6c7de18dafd100a1ab1e014f29a4b9987b1c8bd0

commit 6c7de18dafd100a1ab1e014f29a4b9987b1c8bd0
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Sep 29 20:05:03 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/fae60ba54c83abbbfbe84b5533f6a3e8f9b55178 Base flags on bootstrapped Chromite branch. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= chromium:650713 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2380113003

[modify] https://crrev.com/6c7de18dafd100a1ab1e014f29a4b9987b1c8bd0/infra/config/recipes.cfg

Status: Archived (was: Started)

Sign in to add a comment