Application using CrNet.framework fails app store submission |
||
Issue descriptionVersion: M55 OS: iOS What steps will reproduce the problem? (1) Build CrNet.framework (2) Use it in the app. (3) Submit app to Apple Appstore. What is the expected output? App Submission succeeds. What do you see instead? App Submission fails as "Bundle versions string, short" can't be "55.0.2846.0" due to format error (at most 3 non-negative integers are allowed for this field). Please use labels and text to provide additional information.
,
Oct 4 2016
I think you should just pass "--platform=ios" to the tweak_info_plist invocation in ios/crnet/BUILD.gn file (around line 43, https://cs.chromium.org/chromium/src/ios/crnet/BUILD.gn?q=ios/crnet/BUILD.gn&sq=package:chromium&l=43). This is how the script determine the format to use for the CFBundleShortVersionString key in the generated Info.plist file (default to mac format @MAJOR@.@MINOR@.@BUILD@.@PATCH@, see https://cs.chromium.org/chromium/src/build/mac/tweak_info_plist.py?q=tweak_in&sq=package:chromium&l=290).
,
Oct 4 2016
Should be as simple as changing the code to the following:
# Tweak |info_plist| with current version and revision.
tweak_info_plist("tweak_crnet_plist") {
info_plist = "Info.plist"
args = [
"--platform=ios",
]
}
,
Oct 4 2016
Thanks, this appears to work!
,
Oct 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/546e56fe757f0e70b16866eb3c30117377112f7c commit 546e56fe757f0e70b16866eb3c30117377112f7c Author: mef <mef@chromium.org> Date: Tue Oct 04 20:41:00 2016 [Cronet] Make CFBundleShortVersionString conform x.y.z format on iOS. BUG= 650710 Review-Url: https://codereview.chromium.org/2389113003 Cr-Commit-Position: refs/heads/master@{#422918} [modify] https://crrev.com/546e56fe757f0e70b16866eb3c30117377112f7c/components/cronet/ios/BUILD.gn
,
Mar 13 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by mef@chromium.org
, Oct 3 2016Owner: lilyhoughton@chromium.org