New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 650705 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Determine if Perf Benchmarks Should Be Using Fieldtrial Arguments

Project Member Reported by robliao@chromium.org, Sep 27 2016

Issue description

Fieldtrial arguments are already baked into the build. The use of fieldtrial arguments to override those appears at face value redundant
 
Agree. I think it may be historical - originally we just did the perf bot stuff and that implementation went in first. Then, when we backed them in, I think we just didn't convert the perf ones.

I think getting rid of the duplicate config parsing code in the perf infrastructure would be a good outcome, assuming we make them use the baked-in configs. One thing we should be careful with is if the perf bots test official builds - because by default official builds don't use the baked in configs.
Components: Infra>Client>Perf
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/420af6678ef6a2cff2e34abf62f3b5b0cc83ee7a

commit 420af6678ef6a2cff2e34abf62f3b5b0cc83ee7a
Author: robliao <robliao@chromium.org>
Date: Wed Sep 28 19:48:11 2016

Remove Extra Underscore

BUG=649363, 650705

Review-Url: https://codereview.chromium.org/2378153002
Cr-Commit-Position: refs/heads/master@{#421611}

[modify] https://crrev.com/420af6678ef6a2cff2e34abf62f3b5b0cc83ee7a/tools/perf/core/perf_benchmark.py

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a36a0b62259e09607485d26180e19a0e418c99f

commit 8a36a0b62259e09607485d26180e19a0e418c99f
Author: robliao <robliao@chromium.org>
Date: Wed Sep 28 20:37:00 2016

Revert of Remove Extra Underscore (patchset #1 id:1 of https://codereview.chromium.org/2378153002/ )

Reason for revert:
Reverting to prepare for revert of
https://codereview.chromium.org/2373843002/

due to
https://build.chromium.org/p/chromiumos.chromium/builders/amd64-generic-telemetry/builds/9845

Original issue's description:
> Remove Extra Underscore
>
> BUG=649363, 650705
>
> Committed: https://crrev.com/420af6678ef6a2cff2e34abf62f3b5b0cc83ee7a
> Cr-Commit-Position: refs/heads/master@{#421611}

TBR=aiolos@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=649363, 650705

Review-Url: https://codereview.chromium.org/2381653002
Cr-Commit-Position: refs/heads/master@{#421631}

[modify] https://crrev.com/8a36a0b62259e09607485d26180e19a0e418c99f/tools/perf/core/perf_benchmark.py

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf6e4a4caebe29f7f794bb5775d5d9f03e5e4dcb

commit cf6e4a4caebe29f7f794bb5775d5d9f03e5e4dcb
Author: robliao <robliao@chromium.org>
Date: Wed Sep 28 20:39:20 2016

Revert of Update fieldtrial_util To Handle Combined Fieldtrial Config Format (patchset #4 id:80001 of https://codereview.chromium.org/2373843002/ )

Reason for revert:
Break in
https://build.chromium.org/p/chromiumos.chromium/builders/amd64-generic-telemetry/builds/9845

This isn't part of the CQ run it appears.

Original issue's description:
> Update fieldtrial_util To Handle Combined Fieldtrial Config Format
>
> BUG=649363, 650705
>
> Committed: https://crrev.com/1c70046ee9bfd7f0159b3408331e26b9f61ef49f
> Cr-Commit-Position: refs/heads/master@{#421384}

TBR=aiolos@chromium.org,asvitkine@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=649363, 650705

Review-Url: https://codereview.chromium.org/2381663002
Cr-Commit-Position: refs/heads/master@{#421632}

[modify] https://crrev.com/cf6e4a4caebe29f7f794bb5775d5d9f03e5e4dcb/tools/perf/BUILD.gn
[modify] https://crrev.com/cf6e4a4caebe29f7f794bb5775d5d9f03e5e4dcb/tools/perf/core/perf_benchmark.py
[modify] https://crrev.com/cf6e4a4caebe29f7f794bb5775d5d9f03e5e4dcb/tools/variations/fieldtrial_to_struct.py
[modify] https://crrev.com/cf6e4a4caebe29f7f794bb5775d5d9f03e5e4dcb/tools/variations/fieldtrial_util.py
[modify] https://crrev.com/cf6e4a4caebe29f7f794bb5775d5d9f03e5e4dcb/tools/variations/fieldtrial_util_unittest.py

Hey Robliao - what outstanding work is there for this bug? Can we close it out?
Cc: robliao@chromium.org
Labels: -Pri-2 Pri-3
Owner: ----
The main question here is if
https://cs.chromium.org/chromium/src/tools/variations/fieldtrial_util.py
should even exist at all.

Perfbots rely on command line args to determine the default state of their fieldtrials. It would be better if they could directly reference the fieldtrials instead of going through args.

It's unlikely I'm going to get to this soon, so marking as available.
Setting as Pri-3 as it's not urgent.

Sign in to add a comment