Issue metadata
Sign in to add a comment
|
"org.chromium.content.browser.input.ImeTest#testInputTextEvents_SetComposingText with {--enable-features=ImeThread}" is flaky |
||||||||||||||||||||||||
Issue description
"org.chromium.content.browser.input.ImeTest#testInputTextEvents_SetComposingText with {--enable-features=ImeThread}" is flaky.
This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.
We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyfQsSBUZsYWtlInJvcmcuY2hyb21pdW0uY29udGVudC5icm93c2VyLmlucHV0LkltZVRlc3QjdGVzdElucHV0VGV4dEV2ZW50c19TZXRDb21wb3NpbmdUZXh0IHdpdGggey0tZW5hYmxlLWZlYXR1cmVzPUltZVRocmVhZH0M.
Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
This flaky test/step was previously tracked in issue 649474 .
,
Oct 3 2016
Detected 3 new flakes for test/step "org.chromium.content.browser.input.ImeTest#testInputTextEvents_SetComposingText with {--enable-features=ImeThread}". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyfQsSBUZsYWtlInJvcmcuY2hyb21pdW0uY29udGVudC5icm93c2VyLmlucHV0LkltZVRlc3QjdGVzdElucHV0VGV4dEV2ZW50c19TZXRDb21wb3NpbmdUZXh0IHdpdGggey0tZW5hYmxlLWZlYXR1cmVzPUltZVRocmVhZH0M. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Oct 3 2016
disable in cq: https://codereview.chromium.org/2391653002/
,
Oct 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60cf29f2af9a364c215f71c9ac8fdd92c16b82b4 commit 60cf29f2af9a364c215f71c9ac8fdd92c16b82b4 Author: boliu <boliu@chromium.org> Date: Mon Oct 03 18:34:45 2016 Disable flaky testInputTextEvents_SetComposingText BUG= 650691 TBR=changwan@chromium.org Review-Url: https://codereview.chromium.org/2391653002 Cr-Commit-Position: refs/heads/master@{#422466} [modify] https://crrev.com/60cf29f2af9a364c215f71c9ac8fdd92c16b82b4/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
,
Oct 3 2016
,
Nov 1 2016
,
Nov 3 2016
6 Ime tests have similar problem. In ImeAdapter#sendCompositionToNative(), we call nativeCommitText or nativeSetComposingText (fire selectionchange event), then we call nativeSendKeyEvent (fire keyup event). So selectionchange event should come before keyup event. But in fact, the former usually comes after the latter. In FrameSelection::moveCaretSelection, we put the selectionchange event in a queue (See the below link). As a result, selectionchange event gets delayed. Do we have a good reason for putting it in a queue? @yosin, what do you think? https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/editing/FrameSelection.cpp?q=enqueueDocumentEvent&sq=package:chromium&l=280&dr=C
,
Nov 3 2016
Regardless of whether there is a good reason, we generally shouldn't make a change to production behavior purely to make things easier to test. Can you change the ImeTests to be pass regardless of whether they receive keyup or selectionchange first?
,
Nov 4 2016
OK. I'll change it to listen to selectionchange event and other events separately to make the test pass.
,
Nov 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d1708cdd327cc4f038addd36153e0b86082bf2d commit 4d1708cdd327cc4f038addd36153e0b86082bf2d Author: yabinh <yabinh@chromium.org> Date: Fri Nov 04 06:30:15 2016 Fix some flaky event tests in ImeTest Some Ime tests are flaky because the event order is incorrect. Since selectionchange event is queued, it's delayed and often comes after other event, e.g. keyup event. As a workaround, we can ignore the order of selectionchange event. BUG= 650691 , 628964 Review-Url: https://codereview.chromium.org/2475773003 Cr-Commit-Position: refs/heads/master@{#429813} [modify] https://crrev.com/4d1708cdd327cc4f038addd36153e0b86082bf2d/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java [modify] https://crrev.com/4d1708cdd327cc4f038addd36153e0b86082bf2d/content/test/data/android/input/input_forms.html |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by boliu@chromium.org
, Sep 27 2016Components: UI>Input>Text>IME
Labels: -Sheriff-Chromium OS-Android
Status: Available (was: Untriaged)