Bind LogDog CLI tools to infra instances. |
|
Issue descriptionCurrently, LogDog CLI tools require users to specify default parameters that are Infra-specific rather than bake them into the "luci-go" project. This means that users will have to type "-host luci-logdog.appspot.com" every time they want to run a CLI tool. This is annoying and error-prone. This bug is to create a "default configuration" object for each LogDog application and turn their entry points into libraries. Then, software in the "infra" repository can be written to bake defaults into the Infra versions of this software.
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/e0e407209a72f692ef4de3908753e308d4ab798b commit e0e407209a72f692ef4de3908753e308d4ab798b Author: dnj <dnj@chromium.org> Date: Tue Sep 27 18:23:07 2016 LogDog: Split CLI tool into package and main. Split most of the "logdog" CLI tool into a Go package called "cli". Allow this to be called externally and accept default parameters. Wire up a default version of the tool that supplies no default parameters. This will function the same as the previous "logdog" tool. The intent of this change is to have an Infra-specific version of the tool that is built. BUG= chromium:650684 TEST=None Review-Url: https://codereview.chromium.org/2372703005 [rename] https://crrev.com/e0e407209a72f692ef4de3908753e308d4ab798b/logdog/client/cli/coordinatorSource.go [add] https://crrev.com/e0e407209a72f692ef4de3908753e308d4ab798b/logdog/client/cli/main.go [rename] https://crrev.com/e0e407209a72f692ef4de3908753e308d4ab798b/logdog/client/cli/path.go [rename] https://crrev.com/e0e407209a72f692ef4de3908753e308d4ab798b/logdog/client/cli/subcommandCat.go [rename] https://crrev.com/e0e407209a72f692ef4de3908753e308d4ab798b/logdog/client/cli/subcommandLatest.go [rename] https://crrev.com/e0e407209a72f692ef4de3908753e308d4ab798b/logdog/client/cli/subcommandList.go [rename] https://crrev.com/e0e407209a72f692ef4de3908753e308d4ab798b/logdog/client/cli/subcommandQuery.go [rename] https://crrev.com/e0e407209a72f692ef4de3908753e308d4ab798b/logdog/client/cli/trinaryFlag.go [modify] https://crrev.com/e0e407209a72f692ef4de3908753e308d4ab798b/logdog/client/cmd/logdog/main.go
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/798cba7e4a2e41939e0ad1326c1486e49fb50dbb commit 798cba7e4a2e41939e0ad1326c1486e49fb50dbb Author: Dan Jacques <dnj@chromium.org> Date: Tue Sep 27 19:19:58 2016 Build chrome-infra bound LogDog tools. Add a local LogDog CLI tool that has Infra defaults baked in. Update the CIPD builder to build from this tool instead of the generic luci-go verison. Rolls: infra/go/src/github.com/luci/luci-go: e0e4072 LogDog: Split CLI tool into package and main. b0a8ce7 logdog_cat => "logdog", latest command, rendering. 62e115f Minor tweaks to dm code (doc fixes, rename method, etc.) 7959330 scheduler: Make 'AbortJob' also abort invocations stuck in retries. 25b6d8d pRPC: Retry on certain transient HTTP failures. 81d9555 Go 1.7: Fix fetch_test. infra/go/src/github.com/luci/gae: cfd4c03 dscache: Use math/rand's Read for nonce. BUG= chromium:650684 TEST=local Change-Id: I5c49c956656f6d2e93fdbef3d0364966e72d0f07 Reviewed-on: https://chromium-review.googlesource.com/389994 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> [modify] https://crrev.com/798cba7e4a2e41939e0ad1326c1486e49fb50dbb/DEPS [add] https://crrev.com/798cba7e4a2e41939e0ad1326c1486e49fb50dbb/build/packages/logdog.yaml [delete] https://crrev.com/f32c5122f2db5386f5959984d5984e83cddf65ec/build/packages/logdog_cat.yaml [add] https://crrev.com/798cba7e4a2e41939e0ad1326c1486e49fb50dbb/go/src/infra/libs/infraenv/services.go [add] https://crrev.com/798cba7e4a2e41939e0ad1326c1486e49fb50dbb/go/src/infra/tools/logdog/logdog.infra_testing [add] https://crrev.com/798cba7e4a2e41939e0ad1326c1486e49fb50dbb/go/src/infra/tools/logdog/main.go |
|
►
Sign in to add a comment |
|
Comment 1 by d...@chromium.org
, Sep 28 2016