Implement ImageCapture's |brightness|, |contrast|, |saturation|, and |sharpness| [1,2] fields. [1] https://www.w3.org/TR/image-capture/#PhotoCapabilities [2] https://www.w3.org/TR/image-capture/#PhotoSettings
a0981987557@gmail.com, what do you want to convey with the png uploaded in #2?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d7056407d29413588771b164e82a76f819783c8 commit 6d7056407d29413588771b164e82a76f819783c8 Author: mcasas <mcasas@chromium.org> Date: Tue Oct 04 20:15:50 2016 Image Capture Linux/CrOs, implement brightness, contrast, saturation and sharpness This CL adds the said settings to the idl (capabilities and settings) and wires them through image_capture.mojom to its implementations in Fake and Linux/CrOs video capture device. BUG= 650676 TEST= manually using [1] and a Logitech C920, result equivalent to e.g. guvcview. [1] ./out/gn/chrome -vmodule=*v4l2*=1 --enable-blink-features=ImageCapture --use-fake-ui-for-media-stream https://rawgit.com/Miguelao/demos/master/imagecapture.html Review-Url: https://codereview.chromium.org/2387303002 Cr-Commit-Position: refs/heads/master@{#422899} [modify] https://crrev.com/6d7056407d29413588771b164e82a76f819783c8/content/browser/media/capture/image_capture_impl.cc [modify] https://crrev.com/6d7056407d29413588771b164e82a76f819783c8/media/capture/video/android/video_capture_device_android.cc [modify] https://crrev.com/6d7056407d29413588771b164e82a76f819783c8/media/capture/video/fake_video_capture_device.cc [modify] https://crrev.com/6d7056407d29413588771b164e82a76f819783c8/media/capture/video/fake_video_capture_device_unittest.cc [modify] https://crrev.com/6d7056407d29413588771b164e82a76f819783c8/media/capture/video/linux/v4l2_capture_delegate.cc [modify] https://crrev.com/6d7056407d29413588771b164e82a76f819783c8/media/mojo/interfaces/image_capture.mojom [modify] https://crrev.com/6d7056407d29413588771b164e82a76f819783c8/third_party/WebKit/LayoutTests/imagecapture/getphotocapabilities.html [modify] https://crrev.com/6d7056407d29413588771b164e82a76f819783c8/third_party/WebKit/LayoutTests/imagecapture/resources/mock-imagecapture.js [modify] https://crrev.com/6d7056407d29413588771b164e82a76f819783c8/third_party/WebKit/LayoutTests/imagecapture/setoptions.html [modify] https://crrev.com/6d7056407d29413588771b164e82a76f819783c8/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/6d7056407d29413588771b164e82a76f819783c8/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp [modify] https://crrev.com/6d7056407d29413588771b164e82a76f819783c8/third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.cpp [modify] https://crrev.com/6d7056407d29413588771b164e82a76f819783c8/third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.h [modify] https://crrev.com/6d7056407d29413588771b164e82a76f819783c8/third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl [modify] https://crrev.com/6d7056407d29413588771b164e82a76f819783c8/third_party/WebKit/Source/modules/imagecapture/PhotoSettings.idl
Spinning off Windows part in its own issue.
Copied issue chromium:650676 to issue chromium:657128
[bulk-edit : please ignore if not applicable] Could you please set the correct milestone for this issue?
Comment 1 by mcasas@chromium.org
, Sep 27 2016