Implement ImageCapture's |colorTemperature| [1,2] field. [1] https://www.w3.org/TR/image-capture/#dom-photocapabilities-colortemperature [2] https://www.w3.org/TR/image-capture/#dom-photosettings-colortemperature
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd1e2163fdc66f0204c4de304e2b0bcffceec31b commit dd1e2163fdc66f0204c4de304e2b0bcffceec31b Author: mcasas <mcasas@chromium.org> Date: Tue Sep 27 23:47:18 2016 ImageCapture: wire |colorTemperature| set/get for Linux/Cros This CL adds getting/setting colorTemperature from idl to Linux/CrOs implementation. File image_capture.mojom photo capabilities/settings is reordered to follow the Spec definition order and the idl. (The only added fields are called |color_temperature|). BUG= 650675 TEST=by hand using [1] on a Linux + Logitech C920. Improved LayoutTests. [1] https://rawgit.com/Miguelao/demos/master/imagecapture.html Review-Url: https://codereview.chromium.org/2375543004 Cr-Commit-Position: refs/heads/master@{#421388} [modify] https://crrev.com/dd1e2163fdc66f0204c4de304e2b0bcffceec31b/content/browser/media/capture/image_capture_impl.cc [modify] https://crrev.com/dd1e2163fdc66f0204c4de304e2b0bcffceec31b/media/capture/video/fake_video_capture_device.cc [modify] https://crrev.com/dd1e2163fdc66f0204c4de304e2b0bcffceec31b/media/capture/video/fake_video_capture_device_unittest.cc [modify] https://crrev.com/dd1e2163fdc66f0204c4de304e2b0bcffceec31b/media/capture/video/linux/v4l2_capture_delegate.cc [modify] https://crrev.com/dd1e2163fdc66f0204c4de304e2b0bcffceec31b/media/mojo/interfaces/image_capture.mojom [modify] https://crrev.com/dd1e2163fdc66f0204c4de304e2b0bcffceec31b/third_party/WebKit/LayoutTests/imagecapture/getphotocapabilities.html [modify] https://crrev.com/dd1e2163fdc66f0204c4de304e2b0bcffceec31b/third_party/WebKit/LayoutTests/imagecapture/resources/mock-imagecapture.js [modify] https://crrev.com/dd1e2163fdc66f0204c4de304e2b0bcffceec31b/third_party/WebKit/LayoutTests/imagecapture/setoptions.html [modify] https://crrev.com/dd1e2163fdc66f0204c4de304e2b0bcffceec31b/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/dd1e2163fdc66f0204c4de304e2b0bcffceec31b/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp [modify] https://crrev.com/dd1e2163fdc66f0204c4de304e2b0bcffceec31b/third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.cpp [modify] https://crrev.com/dd1e2163fdc66f0204c4de304e2b0bcffceec31b/third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.h [modify] https://crrev.com/dd1e2163fdc66f0204c4de304e2b0bcffceec31b/third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl [modify] https://crrev.com/dd1e2163fdc66f0204c4de304e2b0bcffceec31b/third_party/WebKit/Source/modules/imagecapture/PhotoSettings.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3aaa88a3a5a0a089aa11837ceaa01bed8cf5ec5b commit 3aaa88a3a5a0a089aa11837ceaa01bed8cf5ec5b Author: mcasas <mcasas@chromium.org> Date: Tue Oct 04 17:06:46 2016 Image Capture Android: wire color temperature set/get This CL adds getter/setter for colour temperature for Android implementation. JS API uses Kelvin grades, whereas the platform uses names, so a mapping of sorts is introduced. BUG= 650675 TEST= by hand using the JS ImageCapture API. Review-Url: https://codereview.chromium.org/2385833002 Cr-Commit-Position: refs/heads/master@{#422832} [modify] https://crrev.com/3aaa88a3a5a0a089aa11837ceaa01bed8cf5ec5b/media/capture/video/android/java/src/org/chromium/media/PhotoCapabilities.java [modify] https://crrev.com/3aaa88a3a5a0a089aa11837ceaa01bed8cf5ec5b/media/capture/video/android/java/src/org/chromium/media/VideoCapture.java [modify] https://crrev.com/3aaa88a3a5a0a089aa11837ceaa01bed8cf5ec5b/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java [modify] https://crrev.com/3aaa88a3a5a0a089aa11837ceaa01bed8cf5ec5b/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java [modify] https://crrev.com/3aaa88a3a5a0a089aa11837ceaa01bed8cf5ec5b/media/capture/video/android/photo_capabilities.cc [modify] https://crrev.com/3aaa88a3a5a0a089aa11837ceaa01bed8cf5ec5b/media/capture/video/android/photo_capabilities.h [modify] https://crrev.com/3aaa88a3a5a0a089aa11837ceaa01bed8cf5ec5b/media/capture/video/android/video_capture_device_android.cc
Can the owner please set a milestone label to this issue? FYI, the last CL associated with this issue has been added after the M54 branch was created and before the M55 branch was created, so perhaps it should be labelled as M55?
This is all behind a flag, so it doesn't matter which milestone it goes to.
[bulk-edit : please ignore if not applicable] Could you please set the correct milestone for this issue?
Comment 1 by mcasas@chromium.org
, Sep 27 2016Labels: -Type-Bug Type-Feature