Fill out missing comments in kSafeManifestEntries in DeviceLocalAccountManagementPolicyProvider |
|||||
Issue descriptionAsk Mattias (@mnissler) for additional clarification.
,
Sep 28 2016
,
Oct 5 2016
There's no need to add a comment for every entry saying "no apparent privacy implications - no further thoughts", absence of comments is a reasonable indicator of this (clarified with mnissler over email).
,
Oct 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d04de4c5a7a78993944fcb0006b947fe6b020371 commit d04de4c5a7a78993944fcb0006b947fe6b020371 Author: isandrk <isandrk@chromium.org> Date: Wed Oct 05 12:45:04 2016 PS whitelisting - removed a TODO There's no need to add a comment for every entry saying "no apparent privacy implications - no further thoughts", absence of comments is a reasonable indicator of this (clarified with mnissler over email). BUG= 650672 Review-Url: https://codereview.chromium.org/2389233003 Cr-Commit-Position: refs/heads/master@{#423134} [modify] https://crrev.com/d04de4c5a7a78993944fcb0006b947fe6b020371/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
,
Oct 5 2016
WAI.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d04de4c5a7a78993944fcb0006b947fe6b020371 commit d04de4c5a7a78993944fcb0006b947fe6b020371 Author: isandrk <isandrk@chromium.org> Date: Wed Oct 05 12:45:04 2016 PS whitelisting - removed a TODO There's no need to add a comment for every entry saying "no apparent privacy implications - no further thoughts", absence of comments is a reasonable indicator of this (clarified with mnissler over email). BUG= 650672 Review-Url: https://codereview.chromium.org/2389233003 Cr-Commit-Position: refs/heads/master@{#423134} [modify] https://crrev.com/d04de4c5a7a78993944fcb0006b947fe6b020371/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by isandrk@chromium.org
, Sep 28 2016