android.webkit.cts.WebViewTest#testSetPictureListener is flaky |
||
Issue descriptionjunit.framework.AssertionFailedError: Expected: <null> but was: android.graphics.Picture@59db550 at junit.framework.Assert.fail(Assert.java:50) at junit.framework.Assert.assertTrue(Assert.java:20) at junit.framework.Assert.assertNull(Assert.java:237) at junit.framework.Assert.assertNull(Assert.java:230) at android.webkit.cts.WebViewTest.testSetPictureListener(WebViewTest.java:1156) The problem appears to be that onPagefinished generates a synthetic onNewPicture callback, and doesn't respect the documented behaviour that the picture should be null on JB MR2 and above.
,
Sep 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d240ed8eb78d66415e16773f0265fb902f0434e commit 3d240ed8eb78d66415e16773f0265fb902f0434e Author: tobiasjs <tobiasjs@chromium.org> Date: Tue Sep 27 15:46:30 2016 When onPageFinished calls onNewPicture, pass null picture on SDK>=JB MR2. onPagefinished generates a synthetic onNewPicture callback if a picture listener is registered. We probably shouldn't change that behaviour, even though it was introduced to fix a different CTS test flake, because applications may well be relying upon it. Given that, it should at least respect the documented behaviour that the picture instance it passes should be null on JB MR2 and above. BUG= 650641 Review-Url: https://codereview.chromium.org/2376673002 Cr-Commit-Position: refs/heads/master@{#421222} [modify] https://crrev.com/3d240ed8eb78d66415e16773f0265fb902f0434e/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java [modify] https://crrev.com/3d240ed8eb78d66415e16773f0265fb902f0434e/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java
,
Oct 10 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by tobiasjs@chromium.org
, Sep 27 2016