Issue metadata
Sign in to add a comment
|
2.8% regression in oortonline_tbmv2 at 420805:420835 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Sep 27 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9000367503128652048
,
Sep 27 2016
=== Auto-CCing suspected CL author cbruni@chromium.org === Hi cbruni@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Revert of [api] Clean up scopes and precheck instantiations cache (patchset #3 id:40001 of https://codereview.chromium.org/2206773003/ ) Author : cbruni Commit description: Reason for revert: Regresses API see go/v8-startup-api Original issue's description: > [api] Clean up scopes and precheck instantiations cache > > Make sure all the scopes used in api-natives.cc have inlineable constructors > and destructors. Additionally directly precheck the instantiations cache before > trying to enter the InvokeScope which sets the save_context. > > BUG=chromium:630217 > > Committed: https://crrev.com/a2496b942cad524f0f3144b107936eaa9a7c9fd5 > Cr-Commit-Position: refs/heads/master@{#38346} TBR=yangguo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:630217, chromium:635912 Review-Url: https://codereview.chromium.org/2366903003 Cr-Commit-Position: refs/heads/master@{#39680} Commit : 85575cd8ee33fa3dd49ffc58de6e0b958df29094 Date : Fri Sep 23 16:01:35 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@420804 554543 4577.97 8 good chromium@420820 555780 4038.87 8 good chromium@420828 554884 4110.18 8 good chromium@420830 556154 4019.66 5 good chromium@420830,v8@84145a149b 556762 2762.61 5 good chromium@420830,v8@73518a9070 556084 3971.08 5 good chromium@420830,v8@76eb976a67 556137 3981.86 5 good chromium@420830,v8@12918397b4 555899 3884.53 5 good chromium@420830,v8@85575cd8ee 572539 2755.78 5 bad <-- chromium@420831 572126 1558.93 5 bad chromium@420832 572055 1627.82 5 bad chromium@420835 568935 9603.7 8 bad Bisect job ran on: mac_10_11_perf_bisect Bug ID: 650610 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests oortonline_tbmv2 Test Metric: memory:chrome:renderer_processes:reported_by_chrome:v8:heap:map_space:effective_size_avg/memory:chrome:renderer_processes:reported_by_chrome:v8:heap:map_space:effective_size_avg Relative Change: 2.19% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/924 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9000367503128652048 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5297758217437184 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Sep 28 2016
This CL had a much wider positive effect on many of our top25 websites. Will reland a modified version of this after investigation. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by hpayer@chromium.org
, Sep 27 2016