New issue
Advanced search Search tips

Issue 650589 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS , All
Pri: 2
Type: Feature

Blocking:
issue 607111
issue 619584
issue 662397



Sign in to add a comment

Make PopularSites long-lived

Project Member Reported by sfiera@chromium.org, Sep 27 2016

Issue description

Paired with  crbug.com/619584 .

In the common case, PopularSites reads and parses a file that past NTPs have already read, and there's no need to do that again.
 

Comment 1 by treib@chromium.org, Sep 27 2016

But if MostVisitedSites becomes a KeyedService, then it's fine for PopularSites to stay as it is (and be owned by MVS). No need to make another KeyedService that'll be used in only a single place.

Comment 2 by sfiera@chromium.org, Sep 27 2016

Summary: Make PopularSites long-lived (was: Make PopularSites a KeyedService)

Comment 3 by fi...@chromium.org, Oct 11 2016

Labels: zine-popularsites M-56 zine-triaged
Status: Assigned (was: Untriaged)

Comment 4 by treib@chromium.org, Oct 12 2016

Labels: -Pri-2 -M-56 Pri-3
Not time critical
Cc: mastiz@chromium.org

Comment 6 by sfiera@chromium.org, Jan 18 2017

Blocking: 662397

Comment 7 by nepper@chromium.org, Jan 18 2017

Labels: -Pri-3 M-57 Pri-1
Adjusting priority as this is now marked as a blocker for the M57 full launch of popular sites on iOS
Status: Started (was: Assigned)
Let me know if you'd like me to do progress on https://codereview.chromium.org/2619993002/
sfiera@: could you give a quick status update? thx!
Blocking: 607111
Cc: fhorschig@chromium.org
Gentle ping for sfiera@.

More specifically, fhorschig@ and I had the impression that Chrome Home is already using Popular Sites (indirectly) as a long-lived object. Is that an issue? If not, should we close this bug?
Labels: OS-iOS OS-All
The future state of this on various platforms is:
 * Android: long-lived via Chrome Home (I believe)
 * iOS: short-lived, per NTP
 * Desktop: long-lived via local NTP

#7 says "marked as a blocker for the M57 full launch of popular sites on iOS" but clearly it wasn't, since we launched and it's still not fixed there.

Comment 14 by treib@chromium.org, Jul 10 2017

Desktop: long-lived via InstantService. That's independent of local/remote NTP. (It's not yet fully launched though - going out with M60.)
Any objection to closing the bug?
Labels: -Pri-1 -M-57 Pri-2
Dropping priority and obsolete target milestone based on comment #13.
Components: -UI>Browser>NewTabPage UI>Browser>ContentSuggestions
Cc: -mastiz@chromium.org -fhorschig@chromium.org
Labels: -zine-triaged
Owner: ----
Status: Untriaged (was: Started)
With Chrome Home and Local NTP on hold, this is back to square one. Not clear how desired it is anymore.

Comment 19 by pkl@chromium.org, Mar 19 2018

Cc: pschaffner@chromium.org mard...@chromium.org justincohen@chromium.org
Status: Available (was: Untriaged)

Sign in to add a comment