New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 650572 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
hobby only
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Make noauth_local_webserver the default option for privacy review shepherding scripts

Project Member Reported by vabr@chromium.org, Sep 27 2016

Issue description

The scripts currently run on a remote machine without GUI. When the authentication tokens expire, the scripts ask the user to open a URL in a browser or rerun with --noauth_local_webserver. However, --noauth_local_webserver is not passed properly to the OAuth2 library, so there is no easy way to refresh the tokens.

There are 2 possible ways of mitigation:
(1) Pass noauth_local_webserver to the library.
(2) Make --noauth_local_webserver the default.

Because the scripts will likely always be run remotely, there is hardly a chance that noauth_local_webserver will be useful when disabled. And even if run on a machine with GUI, noauth_local_webserver enabled still allows the auth flow to proceed. So I suggest doing (2). Will submit a CL shortly.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 27 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/triage/+/a34641c29944b624791f1c887bef7be1712ef0e5

commit a34641c29944b624791f1c887bef7be1712ef0e5
Author: Vaclav Brozek <vabr@chromium.org>
Date: Tue Sep 27 09:31:22 2016

Comment 2 by vabr@chromium.org, Sep 27 2016

Status: Fixed (was: Started)

Sign in to add a comment