Extension submitting form dom object via POST does not pass input parameters
Reported by
toshihir...@gmail.com,
Sep 27 2016
|
|||||||||||||
Issue description
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2868.3 Safari/537.36
Steps to reproduce the problem:
1. Build a extension that executes following script.
---
var form = document.createElement("form");
form.setAttribute("method", "post");
form.setAttribute("action", "http://www.sample.com/");
form.setAttribute('target', "1"); //setting tab id which you want to submit the form to.
var param1 = document.createElement("input");
param1.setAttribute("type", "hidden");
param1.setAttribute("name", "param1");
param1.setAttribute("value", "param1Value");
form.appendChild(param1);
document.body.appendChild(form);
form.submit();
---
What is the expected behavior?
It submits the form with given parameter to the specified tab.
What went wrong?
It submits the form but the parameter does not get passed.
It also crashes the developer console so I cannot see the logs.
Did this work before? Yes It worked for 10+ years as far as I know and works on the latest production version.
Chrome version: 54.0.2840.24 Channel: beta
OS Version: OS X 10.11.6
Flash Version: Shockwave Flash 23.0 r0
,
Sep 28 2016
toshihirotakasu@, do you mean the code is in a Chrome extension? Can you provide a complete source of the extension? > Did this work before? Yes It worked for 10+ years as far as I know and works on the latest production version. Google Chrome didn't exist 10 years ago.
,
Sep 28 2016
I don't know how I get this calculation wrong, it's about 6 years ago :X Yes it's the code in the Chrome extension and complete source code attached. The corresponding code is in the openTabPagePOST() function in js/main.js.
,
Sep 28 2016
,
Sep 28 2016
,
Sep 28 2016
Tested this issue on Mac OS 10.11.6 using latest canary #55.0.2874.0 by following the below steps: 1. Enabled the developer mode. 2. Added the Force.com LOGINS extension. 3. Clicked on the extension and entered a sample username and password. Tried saving the main.html page. 4. The page did not allow to save the page. toshihirotakasu@ - Could you please provide a sample username and password to repro this issue and please eleborate more about this issue.
,
Sep 28 2016
The username and password can be anything, this extension is for you to manage the login credentials of your salesforce account. I followed exactly the same steps, and I could successfully save the credentials (username/password). Can you explain how it did not allow you to save the credential? Once you saved the credentials, clicking 'tab' button next to the account username should open a new tab, and in that new tab the extension should POST your credentials to the salesforce login endpoint (by openTabPagePost() in js/main.js). If you have dummy username/password saved for test purpose then you should see the salesforce login error page in that tab, if you have valid username/password then you should be logged into your salesforce account - this is expected behavior. However the issue that I see with the beta (or with the Canary) is that you just see the salesforce login page regardless of whether or not you have valid username/password, and it makes me think that un/pw parameters haven't been passed. I confirmed that it works with GET on beta.
,
Sep 29 2016
Hi, please see https://bugs.chromium.org/p/chromium/issues/detail?id=571120#c3. I think this might be a similar problem: form posts from the options V2 page do not work correctly.
,
Sep 29 2016
Retested the issue on Mac OS 10.11.6 using reported version #55.0.2868.3 as per the comment #0. Observed that an error box displayed after saving the credentials regarding purchasing a paid license. Attaching screencast for the same. toshihirotakasu@ - Could you please verify the screencast and let us know if anything else need to be done from our side.
,
Sep 29 2016
Thanks for the screencast.
You need paid license to set the 'Landing Page' option in the form.
You can just leave that field as default value ("-") and you should be able to save.
,
Oct 4 2016
toshihirotakasu@ - Thanks for your clarification. Retested the issue on Mac OS 10.11.6 using reported version #55.0.2868.3, chrome stable version #53.0.2785.143 and latest canary #55.0.2880.0 as per the comment #0 and #7. Observed a salesforce login error page in tab after saving the test credentials. Attaching screencast for reference. toshihirotakasu@ - Could you please verify the screencast and let us know if it is the expected behaviour.
,
Oct 11 2016
Hi krajshree, Thank you again for the screencast, and my apology for late response. What you showed is actually expected behavior because getting login error page means the extension has successfully posted id and/or password to the login endpoint. I can see you're using later version of beta than the one I've seen the issue with, so probably the issue has been resolved.
,
Oct 13 2016
toshihirotakasu@ - Thanks for your clarification....!! Could you please check the issue in latest beta version and confirm. The chrome beta build can be accessed from the URL below: https://www.chromium.org/getting-involved/dev-channel. Thanks,
,
Oct 20 2016
Thank you for providing more feedback. Adding requester "krajshree@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 24 2016
@krajshree - I confirmed that this issue has been resolved at the latest beta version (55.0.2883.21 beta (64-bit)). Thank you all!
,
Oct 24 2016
As per comments from @toshihirotakasu, this issue is fixed. Removing the Needs Bisect label and changing the status from unconfirmed to Fixed.
,
Oct 24 2016
As per comments from @toshihirotakasu,changing the status of issue to Won't Fix. Please ignore my earlier post. Thank You... |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by dtapu...@chromium.org
, Sep 27 2016