New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 650566 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 667481
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Storm of NOTREACHED() in WebRemoteFrameImpl::addMessageToConsole()

Project Member Reported by djkurtz@chromium.org, Sep 27 2016

Issue description

Chrome Version       : 54.0.2840.24
OS Version           : 8743.25.0
Device               :  Elm

What steps will reproduce the problem?
1. Sign in @gmail.com as secondary account
2.
3.

What is the expected result?

What happens instead of that?

Device is quite sluggish.
Possibly related, file:///var/log/ui/ui.LATEST is filling up with messages like:

[1:1:0927/150632:ERROR:WebRemoteFrameImpl.cpp(213)] NOTREACHED() hit.
[1:1:0927/150632:ERROR:WebRemoteFrameImpl.cpp(213)] NOTREACHED() hit.
[1:1:0927/150632:ERROR:WebRemoteFrameImpl.cpp(213)] NOTREACHED() hit.
[1:1:0927/150633:ERROR:WebRemoteFrameImpl.cpp(213)] NOTREACHED() hit.
[1:1:0927/150633:ERROR:WebRemoteFrameImpl.cpp(213)] NOTREACHED() hit.
[1:1:0927/150633:ERROR:WebRemoteFrameImpl.cpp(213)] NOTREACHED() hit.
[1:1:0927/150633:ERROR:WebRemoteFrameImpl.cpp(213)] NOTREACHED() hit.
[1:1:0927/150634:ERROR:WebRemoteFrameImpl.cpp(213)] NOTREACHED() hit.
[1:1:0927/150634:ERROR:WebRemoteFrameImpl.cpp(213)] NOTREACHED() hit.
...

As many as 100 such messages / second.



Please provide any additional information below. Attach a screenshot if
possible.

From Feedback Report:
https://feedback.corp.google.com/product/208/neutron?lView=rd&lReport=12399895675

UserAgentString: Mozilla/5.0 (X11; CrOS aarch64 8743.25.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.24 Safari/537.36

From https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

This seems to be:

void WebRemoteFrameImpl::addMessageToConsole(const WebConsoleMessage&)
{
    NOTREACHED();
}

Assigning to dcheng@ to help triage, since he was unfortunate to have originally added this function :-).
 

Comment 1 by dcheng@chromium.org, Sep 29 2016

Components: -UI>Browser Internals>Sandbox>SiteIsolation
Labels: -Pri-3 Pri-2
Status: Started (was: Assigned)
Any way for me to see the actual feedback report? Or does it not have significant amounts of extra info?
Attached are the chrome_user_log, chrome_system_log and ui_log from the feedback report.

Is there anything else you would like to see?
Are you not able to access the feedback URL itself?

12399895675_snippet.txt
301 KB View Download
Cc: a...@chromium.org dcheng@chromium.org
 Issue 650522  has been merged into this issue.
There are quite a few places that do something like  m_webView->mainFrame()->addMessageToConsole().  I'm guessing we hit this when one of those places is triggered from an OOPIF?

Comment 5 by dcheng@chromium.org, Feb 28 2017

Mergedinto: 667481
Status: Duplicate (was: Started)
We fixed this by moving addMessageToConsole() to WebLocalFrame. There's a few broken things that no longer emit console messages as a result; those will have to be separately fixed.

Sign in to add a comment