Some layout tests in http/tests/credentialmanager are failing consistently |
||
Issue descriptionConfiguration on the mock of navigator.credentials is affecting following tests when run on the same content_shell. They should clear the configuration at the end e.g. by registering such a logic by using add_completion_callback if it's using testharness.js.
,
Sep 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5138b3b9ec53fd1cea8ff4e9da8389ef71b79c2f commit 5138b3b9ec53fd1cea8ff4e9da8389ef71b79c2f Author: tyoshino <tyoshino@chromium.org> Date: Tue Sep 27 09:11:50 2016 Add clean up logic to navigator.credentials layout tests navigator.credentials is backed by MockCredentialManagerClient when running layout tests. If two tests are run in sequence on the same content_shell, the earlier test's configuration affects the following one. Actually, passwordcredential-fetch.html is consistently failing. Fix this by adding clean up logic to user of the mock configuration API. R=mkwst@chromium.org BUG= 650561 Review-Url: https://codereview.chromium.org/2373503003 Cr-Commit-Position: refs/heads/master@{#421155} [modify] https://crrev.com/5138b3b9ec53fd1cea8ff4e9da8389ef71b79c2f/components/test_runner/test_runner.cc [modify] https://crrev.com/5138b3b9ec53fd1cea8ff4e9da8389ef71b79c2f/components/test_runner/test_runner.h [modify] https://crrev.com/5138b3b9ec53fd1cea8ff4e9da8389ef71b79c2f/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-frame-errors.html [modify] https://crrev.com/5138b3b9ec53fd1cea8ff4e9da8389ef71b79c2f/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html [modify] https://crrev.com/5138b3b9ec53fd1cea8ff4e9da8389ef71b79c2f/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-errors.html [modify] https://crrev.com/5138b3b9ec53fd1cea8ff4e9da8389ef71b79c2f/third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-fetch.html [modify] https://crrev.com/5138b3b9ec53fd1cea8ff4e9da8389ef71b79c2f/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/iframed-credentialscontainer.html
,
Sep 30 2016
http/tests/credentialmanager/credentialscontainer-get-basics.html http/tests/credentialmanager/passwordcredential-fetch.html are green now. Closing. |
||
►
Sign in to add a comment |
||
Comment 1 by tyoshino@chromium.org
, Sep 27 2016