New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 650560 link

Starred by 1 user
Status: Fixed
Owner:
finnur@chromium.org
Closed: Sep 2016
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ durga.behera@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Plugin icon and three dot menu is seen on adding any exception in All sites in Chrome://md-settings page

Project Member Reported by susanjun...@techmahindra.com, Sep 27 2016 
Version: 55.0.2873.0
OS: Ubuntu 14.04

What steps will reproduce the problem?
(1)Launch Chrome and goto chrome://md-settings/siteSettings/all.
(2)For default sites in the All sites page, we can see Plugin icon against it. If we try adding a new exception(in Camera,Microphone,location etc), we can see both the Plugin icon and three dot menu.

Expected: No icon should be seen against the site in All sites page.
Actual: Instead, Plugin and three dot icon are seen.

This is a Regression issue broken in M-55. Will provide the bisect info and Windows behaviour soon.

Manual Bisect info:
Good build:55.0.2868.0 Dev
Bad build: 55.0.2870.0 Dev

Comment 1 by susanjun...@techmahindra.com, Sep 27 2016

Labels: OS-Windows
Attaching Actual and Expected screen casts for reference.

Also this issue is reproducible on Windows.
actual_icons.webm
3.1 MB View Download
Expected_icons.webm
2.0 MB View Download

Comment 2 by kavvaru@chromium.org, Sep 27 2016

Labels: OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Mac 10.11.6 using chrome version 55.0.2873.0

Comment 3 by susanjun...@techmahindra.com, Sep 28 2016

Labels: -Needs-Bisect hasbisect
Owner: finnur@chromium.org
Status: Assigned (was: Untriaged)
Manual good and Bad Builds:
Good Build: 54.0.2868.0
Bad Build:  54.0.2870.0

Below is the Tool Bisect Info:

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/3b3e90443440cecbc3d24a045819b3d14e0b17c6..735f4f6767f1baf9d16f6fb53c46df366873022a

Suspecting https://codereview.chromium.org/2354313002

@finnur : Please feel free to re-assign if this is not related to your change

Comment 4 by kavvaru@chromium.org, Sep 28 2016

Labels: -hasbisect hasbisect-per-revision ReleaseBlock-Stable
Please find the bisect information using hasbisect-per-revision

Narrow Bisect::
Good Build: 55.0.2868.0
Bad Build:  55.0.2869.0

Change Log::
https://chromium.googlesource.com/chromium/src/+log/3b3e90443440cecbc3d24a045819b3d14e0b17c6..b0fca5c853d275637871e0ac86f84953f2071346

Possible suspect::
https://chromium.googlesource.com/chromium/src/+/b0fca5c853d275637871e0ac86f84953f2071346

Adding stable blocker as this is recent regression.Please feel free to remove if not the case.

Thanks,

Comment 5 by finnur@chromium.org, Sep 28 2016

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4bb8db63ac1856a29786bb0317f0fce06084134

commit c4bb8db63ac1856a29786bb0317f0fce06084134
Author: finnur <finnur@chromium.org>
Date: Thu Sep 29 09:41:02 2016

Site Settings Desktop: Make sure AllSites list doesn't show icon/menu per site.

This CL also unifies the way we check for the ALL_SITES category.

BUG= 650560 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2378013002
Cr-Commit-Position: refs/heads/master@{#421789}

[modify] https://crrev.com/c4bb8db63ac1856a29786bb0317f0fce06084134/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/c4bb8db63ac1856a29786bb0317f0fce06084134/chrome/browser/resources/settings/site_settings/site_list.js

Comment 7 by finnur@chromium.org, Sep 29 2016

Status: Fixed (was: Started)

Comment 8 by krajshree@chromium.org, Oct 4 2016

Labels: TE-Verified-M55 TE-Verified-55.0.2880.0
Verified the issue on windows 10 and Mac 10.11.6 using chrome dev version #55.0.2880.0 as per the comment #0. 
Observed that the fix is working as expected.

Attaching screencast for reference.

Hence, adding the verified labels.

Note:: Issue verified on 55.0.2879.0 for Linux as the 55.0.2880.0 build got failed for linux due to issue 652581.
650560.mp4
2.0 MB View Download
►

Sign in to add a comment