New issue
Advanced search Search tips

Issue 650552 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

chrome-extension:// url breaks MD Settings -> Site Settings

Reported by kartride...@gmail.com, Sep 27 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2868.3 Safari/537.36

Steps to reproduce the problem:
1. enable MD settings via #enable-md-settings flag;
2. navigate to one sub setting of site settings like
chrome://settings/siteSettings/notifications
3. add an extension url to exception like
chrome-extension://efhgfbfpcbnnbicfphagcjmgjfjmojfd/
4. reload

What is the expected behavior?
the added site appears in site list and exception rule works.

What went wrong?
1. the Block/Allow section which the site is added to disappears with errors in console, see the attached screenshot for details (shot on a canary build which also got this problem).
2. the rule doesn't work.

Did this work before? N/A 

Chrome version: 55.0.2868.3  Channel: dev
OS Version: 10.0
Flash Version: Shockwave Flash 23.0 r0

i found this problem because i want to use notification in an extension background page but notification permission request popup wouldn't show up (reasonable for background page? hmm...) and i had to manually add it to site exceptions.
In traditional settings UI that works fine and previously added sites show up in MD settings list -- but adding site in MD settings doesn't work.
And now i can switch back to traditional UI, add site, switch to MD settings and rules work well -- but this requires restarting chrome twice.
 
extension_url_breaks_md_settings.png
123 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09022f2c25367e6ed30af3cec48db61b94570524

commit 09022f2c25367e6ed30af3cec48db61b94570524
Author: finnur <finnur@chromium.org>
Date: Thu Sep 29 12:10:44 2016

Site Settings Desktop: Better support for chrome-extension scheme.

BUG= 650552 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2381583002
Cr-Commit-Position: refs/heads/master@{#421803}

[modify] https://crrev.com/09022f2c25367e6ed30af3cec48db61b94570524/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/09022f2c25367e6ed30af3cec48db61b94570524/chrome/test/data/webui/settings/site_list_tests.js

Comment 2 by finnur@chromium.org, Sep 29 2016

Owner: finnur@chromium.org
Status: Fixed (was: Unconfirmed)

Sign in to add a comment