[MD History] Polymer gesture listeners are reset when element upgrades |
||||
Issue descriptionSteps to reproduce: 1. Open MD History on touch screen device (or with devtools touch emulation enabled) 2. Touch item menu button The menu does not open in response to touch events, but still works correctly from click events. The root cause is in Polymer. The `tap` event is registered on the button element when it is first created. When paper-icon-button-light is imported by lazy-load.html, the button element upgrades into a Polymer element and in the process, resets its gestures [1], losing the ability to respond to tap events. A simple workaround is to use on-click instead of on-tap for any elements which are lazy-loaded. [1] https://github.com/Polymer/polymer/blob/master/src/standard/gestures.html#L707
,
Sep 28 2016
Work-around landed, Polymer issue: https://github.com/Polymer/polymer/issues/4002
,
Sep 28 2016
Issue 650578 has been merged into this issue.
,
Oct 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95f84bba89a39f5d70372bb08dfb159208f6b6c0 commit 95f84bba89a39f5d70372bb08dfb159208f6b6c0 Author: tsergeant <tsergeant@chromium.org> Date: Wed Oct 05 06:30:41 2016 MD History: Use click instead of tap events for synced device collapsing This fixes an issue where using touch to open the synced device actions menu would also collapse the device card, since one event used on-tap and the other used on-click. BUG= 652634 , 650551 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2389393002 Cr-Commit-Position: refs/heads/master@{#423091} [modify] https://crrev.com/95f84bba89a39f5d70372bb08dfb159208f6b6c0/chrome/browser/resources/md_history/lazy_load.vulcanized.html [modify] https://crrev.com/95f84bba89a39f5d70372bb08dfb159208f6b6c0/chrome/browser/resources/md_history/synced_device_card.html [modify] https://crrev.com/95f84bba89a39f5d70372bb08dfb159208f6b6c0/chrome/test/data/webui/md_history/history_synced_tabs_test.js
,
Sep 8 2017
Based on playing around with the demo on the Polymer issue, I think this is fixed in Polymer 2.0. Upgrading to Polymer 2 should it for us, even if we're just running in Hybrid mode. Closing this issue as obsolete, since the Polymer 1.x issue is unlikely to get any traction between now and then. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Sep 28 2016