Issue metadata
Sign in to add a comment
|
Pressing cmd+L when the omnibox already has focus loads the downloads page |
||||||||||||||||||||||||
Issue descriptionVersion: 55.0.2872.0 OS: Tested on macOS 10.11 so far What steps will reproduce the problem? (1) Press cmd+L (2) Press cmd+L What is the expected output? The omnibox gets focus and keeps it. What do you see instead? The omnibox gets focus, then the downloads page loads. This showed up in Canary in the last few days. It does *not* repro in dev (55.0.2868.3).
,
Sep 27 2016
Yeah, confirmed by bisect. Also triggers when the find-on-page field has focus.
,
Sep 27 2016
Able to reproduce the issue on mac 10.11.6 Retina chrome version 55.0.2872.0 - The omnibox gets focus, then the downloads page loads. This is a regression in M55 and below is the info Manual Bisect: Good Build:55.0.2869.0 Bad Build:55.0.2870.0 CL :https://chromium.googlesource.com/chromium/src/+log/55.0.2869.0..55.0.2870.0?pretty=fuller&n=10000 Bisect Tool Info: https://chromium.googlesource.com/chromium/src/+log/928ed3fef6431a8815e32bb2d905fc3bd21f5024..e4782406f9b29d7d4d87653f4edec682dbba8107 Using Shortcut Cmd-Alt-L download page loads fine.
,
Sep 27 2016
This is working fine on win and Linux
,
Sep 27 2016
able to repro on latest Canary/Dev #55.0.2873.0 on Mac OS X 10.11.6
,
Sep 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2af95142ec4aa2f5935921dd681c6351dff9fd6 commit c2af95142ec4aa2f5935921dd681c6351dff9fd6 Author: ellyjones <ellyjones@chromium.org> Date: Tue Sep 27 14:36:59 2016 cocoa browser: bind cmd-opt-l, not cmd-l, for downloads A longstanding trap in global_keyboard_shortcuts_mac: if a binding has a character specified instead of a keycode, the option modifier in the command is ignored, which makes sense, since option might be involved in typing the character in the first place. However, it does mean that bindings should never specify opt == true, which is exactly what I did in CL 2369453003. This CL adds a DCHECK to ensure nobody else trips over this. BUG= 650528 Review-Url: https://codereview.chromium.org/2373543003 Cr-Commit-Position: refs/heads/master@{#421203} [modify] https://crrev.com/c2af95142ec4aa2f5935921dd681c6351dff9fd6/chrome/browser/global_keyboard_shortcuts_mac.mm
,
Sep 27 2016
,
Sep 27 2016
ellyjones@, Thank you for the fix. Could you please merge this fix to 2873 branch if possible?
,
Sep 27 2016
,
Sep 27 2016
M55 is NOT branched yet so no merge request is needed. Please merge the fix to M55 Canary branch 2873 ASAP. Thank you.
,
Sep 27 2016
,
Sep 27 2016
Merged to 2873.
,
Sep 27 2016
,
Sep 27 2016
Tested this fix on Latest Dev#55.0.2873.4 for Mac OS X 10.11.6 - Working as intended. Thank you!
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c82805b67a152c5b11ee762bea7d6393b2715c7f commit c82805b67a152c5b11ee762bea7d6393b2715c7f Author: Elly Fong-Jones <ellyjones@google.com> Date: Tue Sep 27 18:55:28 2016 cocoa browser: bind cmd-opt-l, not cmd-l, for downloads A longstanding trap in global_keyboard_shortcuts_mac: if a binding has a character specified instead of a keycode, the option modifier in the command is ignored, which makes sense, since option might be involved in typing the character in the first place. However, it does mean that bindings should never specify opt == true, which is exactly what I did in CL 2369453003. This CL adds a DCHECK to ensure nobody else trips over this. BUG= 650528 Review-Url: https://codereview.chromium.org/2373543003 Cr-Commit-Position: refs/heads/master@{#421203} (cherry picked from commit c2af95142ec4aa2f5935921dd681c6351dff9fd6) Review URL: https://codereview.chromium.org/2376793002 . Cr-Commit-Position: refs/branch-heads/2873@{#5} Cr-Branched-From: 4e1f4cd0a29061dc75bc76aef5212847c2ca132a-refs/heads/master@{#421052} [modify] https://crrev.com/c82805b67a152c5b11ee762bea7d6393b2715c7f/chrome/browser/global_keyboard_shortcuts_mac.mm |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by sdy@chromium.org
, Sep 27 2016Owner: ellyjo...@chromium.org
Status: Assigned (was: Untriaged)