New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 650504 link

Starred by 1 user
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Sep 2016
Cc:
█ tsergeant@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

MD Downloads: Remove CSS imports

Project Member Reported by tsergeant@chromium.org, Sep 27 2016 
Downloads uses <link rel="import" type="css"> to import CSS files into polymer elements. This style of import is deprecated [1] and will be removed in Polymer 2.0 [2].

We should move away from this to directly including stylesheets in element <template>s.

Comment 1 by dbeam@chromium.org, Sep 27 2016

Cc: -dbeam@chromium.org
Owner: dbeam@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36d04319120c222cc12de7a788b547f4773da845

commit 36d04319120c222cc12de7a788b547f4773da845
Author: dbeam <dbeam@chromium.org>
Date: Tue Sep 27 17:52:57 2016

MD Downloads: remove most deprecated CSS imports

This CL merges component.css files into respective component.html files.

This reduces Download's use of the deprecated <link type="css"> syntax
and more closely resembles other MD pages.

While I was at it: shared_styles.css had basically outlived its
usefulness, so I put some --vars in the top-level page and duplicated
a couple of small [hidden] { display: none !important; } rules across
components (because it seems better than making a shared CSS module).

Depends on both of these lovely changes:
https://codereview.chromium.org/2362633002/
https://codereview.chromium.org/2370653002/

R=tsergeant@chromium.org
BUG= 650504 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2374473003
Cr-Commit-Position: refs/heads/master@{#421258}

[modify] https://crrev.com/36d04319120c222cc12de7a788b547f4773da845/chrome/browser/browser_resources.grd
[modify] https://crrev.com/36d04319120c222cc12de7a788b547f4773da845/chrome/browser/resources/md_downloads/downloads.html
[delete] https://crrev.com/36c922341b0da49622ea02fabc7ce73356d89c25/chrome/browser/resources/md_downloads/item.css
[modify] https://crrev.com/36d04319120c222cc12de7a788b547f4773da845/chrome/browser/resources/md_downloads/item.html
[delete] https://crrev.com/36c922341b0da49622ea02fabc7ce73356d89c25/chrome/browser/resources/md_downloads/manager.css
[modify] https://crrev.com/36d04319120c222cc12de7a788b547f4773da845/chrome/browser/resources/md_downloads/manager.html
[delete] https://crrev.com/36c922341b0da49622ea02fabc7ce73356d89c25/chrome/browser/resources/md_downloads/shared_style.css
[delete] https://crrev.com/36c922341b0da49622ea02fabc7ce73356d89c25/chrome/browser/resources/md_downloads/toolbar.css
[modify] https://crrev.com/36d04319120c222cc12de7a788b547f4773da845/chrome/browser/resources/md_downloads/toolbar.html
[modify] https://crrev.com/36d04319120c222cc12de7a788b547f4773da845/chrome/browser/resources/md_downloads/vulcanized.html

Comment 3 by dbeam@chromium.org, Sep 27 2016

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7afe3476bd1f1f851515c6c420791890a6b7b352

commit 7afe3476bd1f1f851515c6c420791890a6b7b352
Author: tsergeant <tsergeant@chromium.org>
Date: Wed Sep 28 08:14:57 2016

MD Downloads: Fix unvulcanized build

Following crrev.com/421258, these resources no longer exist and break
the unvulcanized compile.

BUG= 650504 

Review-Url: https://codereview.chromium.org/2378593002
Cr-Commit-Position: refs/heads/master@{#421477}

[modify] https://crrev.com/7afe3476bd1f1f851515c6c420791890a6b7b352/chrome/browser/ui/webui/md_downloads/md_downloads_ui.cc
►

Sign in to add a comment