Uninstalled Android apps resurrected by sync |
||||||
Issue descriptionThe list of synced apps only grows. If I remove some apps, they would still end up synced over on a new Chromebook. Inner link: https://buganizer.corp.google.com/issues/31593342
,
Sep 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/077a23cfcc11a665a41e878be2270218a0a0f429 commit 077a23cfcc11a665a41e878be2270218a0a0f429 Author: lgcheng <lgcheng@google.com> Date: Thu Sep 29 18:33:12 2016 Fix Android App resurrected by sync. This patch makes ReadyForStart + ReenableDatatype to be called only when the type is being disabled/re-enabled for some external to sync condition. StartModels/OnModelLoaded is now used to track ARC AppInstanceReady signal. Also moves re-enable sync data type related code from sync service to sync data type controller. BUG= 650483 Test=Pass exsiting Test. Test1=Manually remove app on Chromebook1 while Chromebook2 is off. When Chromebook2 is on, the app is removed by sync. Test2=Manually remove app on Chromebook1 while Chromebook2 is on but offline. When Chromebook2 is back online, app is removed by sync. Test3=Manually remove app on Chromebook1 while Chromebook1 is offline. When Chromebook1 is back online, app is removed by sync on Chromebook2. Review-Url: https://codereview.chromium.org/2353213002 Cr-Commit-Position: refs/heads/master@{#421876} [modify] https://crrev.com/077a23cfcc11a665a41e878be2270218a0a0f429/chrome/browser/sync/chrome_sync_client.cc [modify] https://crrev.com/077a23cfcc11a665a41e878be2270218a0a0f429/chrome/browser/sync/test/integration/sync_arc_package_helper.cc [modify] https://crrev.com/077a23cfcc11a665a41e878be2270218a0a0f429/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc [modify] https://crrev.com/077a23cfcc11a665a41e878be2270218a0a0f429/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h [modify] https://crrev.com/077a23cfcc11a665a41e878be2270218a0a0f429/chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc
,
Sep 29 2016
,
Sep 30 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Oct 4 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 7 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/276127c923c28cafe3e4fddd1ab8d83e5a4a6f9c commit 276127c923c28cafe3e4fddd1ab8d83e5a4a6f9c Author: Josh Horwich <jhorwich@chromium.org> Date: Tue Oct 11 23:05:53 2016 arc: Fix Android App resurrected by sync. This patch makes ReadyForStart + ReenableDatatype to be called only when the type is being disabled/re-enabled for some external to sync condition. StartModels/OnModelLoaded is now used to track ARC AppInstanceReady signal. Also moves re-enable sync data type related code from sync service to sync data type controller. BUG= 650483 TBR=xiyuan@chromium.org, pavely@chromium.org Test=Pass exsiting Test. Test1=Manually remove app on Chromebook1 while Chromebook2 is off. When Chromebook2 is on, the app is removed by sync. Test2=Manually remove app on Chromebook1 while Chromebook2 is on but offline. When Chromebook2 is back online, app is removed by sync. Test3=Manually remove app on Chromebook1 while Chromebook1 is offline. When Chromebook1 is back online, app is removed by sync on Chromebook2. Review-Url: https://codereview.chromium.org/2353213002 Cr-Commit-Position: refs/heads/master@{#421876} (cherry picked from commit 077a23cfcc11a665a41e878be2270218a0a0f429) Review URL: https://codereview.chromium.org/2410993002 . Cr-Commit-Position: refs/branch-heads/2840@{#724} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/276127c923c28cafe3e4fddd1ab8d83e5a4a6f9c/chrome/browser/sync/chrome_sync_client.cc [modify] https://crrev.com/276127c923c28cafe3e4fddd1ab8d83e5a4a6f9c/chrome/browser/sync/test/integration/sync_arc_package_helper.cc [modify] https://crrev.com/276127c923c28cafe3e4fddd1ab8d83e5a4a6f9c/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc [modify] https://crrev.com/276127c923c28cafe3e4fddd1ab8d83e5a4a6f9c/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h [modify] https://crrev.com/276127c923c28cafe3e4fddd1ab8d83e5a4a6f9c/chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc
,
Oct 17 2016
,
Oct 18 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/276127c923c28cafe3e4fddd1ab8d83e5a4a6f9c commit 276127c923c28cafe3e4fddd1ab8d83e5a4a6f9c Author: Josh Horwich <jhorwich@chromium.org> Date: Tue Oct 11 23:05:53 2016 arc: Fix Android App resurrected by sync. This patch makes ReadyForStart + ReenableDatatype to be called only when the type is being disabled/re-enabled for some external to sync condition. StartModels/OnModelLoaded is now used to track ARC AppInstanceReady signal. Also moves re-enable sync data type related code from sync service to sync data type controller. BUG= 650483 TBR=xiyuan@chromium.org, pavely@chromium.org Test=Pass exsiting Test. Test1=Manually remove app on Chromebook1 while Chromebook2 is off. When Chromebook2 is on, the app is removed by sync. Test2=Manually remove app on Chromebook1 while Chromebook2 is on but offline. When Chromebook2 is back online, app is removed by sync. Test3=Manually remove app on Chromebook1 while Chromebook1 is offline. When Chromebook1 is back online, app is removed by sync on Chromebook2. Review-Url: https://codereview.chromium.org/2353213002 Cr-Commit-Position: refs/heads/master@{#421876} (cherry picked from commit 077a23cfcc11a665a41e878be2270218a0a0f429) Review URL: https://codereview.chromium.org/2410993002 . Cr-Commit-Position: refs/branch-heads/2840@{#724} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/276127c923c28cafe3e4fddd1ab8d83e5a4a6f9c/chrome/browser/sync/chrome_sync_client.cc [modify] https://crrev.com/276127c923c28cafe3e4fddd1ab8d83e5a4a6f9c/chrome/browser/sync/test/integration/sync_arc_package_helper.cc [modify] https://crrev.com/276127c923c28cafe3e4fddd1ab8d83e5a4a6f9c/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc [modify] https://crrev.com/276127c923c28cafe3e4fddd1ab8d83e5a4a6f9c/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h [modify] https://crrev.com/276127c923c28cafe3e4fddd1ab8d83e5a4a6f9c/chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sheriffbot@chromium.org
, Sep 27 2016