New issue
Advanced search Search tips

Issue 650469 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 650461



Sign in to add a comment

Define and implement SyncManager.

Project Member Reported by kmarshall@chromium.org, Sep 26 2016

Issue description

Feature tracking bug.

Implementation should be functionally correct, but doesn't need to be optimal. Should be tested against a dummy Syncable object which contains a LwwRegister.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35a16a011800bf25273c58f0c937b0140b55d9bd

commit 35a16a011800bf25273c58f0c937b0140b55d9bd
Author: kmarshall <kmarshall@chromium.org>
Date: Thu Oct 06 20:44:47 2016

Initial definition of HeliumSyncManager and SyncRegistration objects.

This CL contains an abstract interface for SyncManager and a private
class skeleton SyncManagerImpl with the method bodies stubbed out.

R=steimel@chromium.org,scf@chromium.org
CC=wez@chromium.org
BUG= 650469 

Review-Url: https://codereview.chromium.org/2377873002
Cr-Commit-Position: refs/heads/master@{#423660}

[modify] https://crrev.com/35a16a011800bf25273c58f0c937b0140b55d9bd/blimp/net/BUILD.gn
[add] https://crrev.com/35a16a011800bf25273c58f0c937b0140b55d9bd/blimp/net/helium/helium_sync_manager.cc
[add] https://crrev.com/35a16a011800bf25273c58f0c937b0140b55d9bd/blimp/net/helium/helium_sync_manager.h

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35a16a011800bf25273c58f0c937b0140b55d9bd

commit 35a16a011800bf25273c58f0c937b0140b55d9bd
Author: kmarshall <kmarshall@chromium.org>
Date: Thu Oct 06 20:44:47 2016

Initial definition of HeliumSyncManager and SyncRegistration objects.

This CL contains an abstract interface for SyncManager and a private
class skeleton SyncManagerImpl with the method bodies stubbed out.

R=steimel@chromium.org,scf@chromium.org
CC=wez@chromium.org
BUG= 650469 

Review-Url: https://codereview.chromium.org/2377873002
Cr-Commit-Position: refs/heads/master@{#423660}

[modify] https://crrev.com/35a16a011800bf25273c58f0c937b0140b55d9bd/blimp/net/BUILD.gn
[add] https://crrev.com/35a16a011800bf25273c58f0c937b0140b55d9bd/blimp/net/helium/helium_sync_manager.cc
[add] https://crrev.com/35a16a011800bf25273c58f0c937b0140b55d9bd/blimp/net/helium/helium_sync_manager.h

Comment 3 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Owner: ----
Status: Available (was: Assigned)
Status: WontFix (was: Available)
Obsolete, WontFix.
Labels: Archive-Blimp

Sign in to add a comment