New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 650462 link

Starred by 2 users
Status: Fixed
Owner:
█ gcasto@chromium.org
Last visit > 30 days ago
Closed: Dec 21
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Refactor gRPC support for Cronet

Project Member Reported by gcasto@chromium.org, Sep 26 2016 
Blimp, and other projects, will want to make use of gRPC inside of Chromium. This requires that the interface (cronet_c_for_grpc.h) that is currently used for gRPC be moved to location that is built on all platforms, not just iOS, and to have an implementation of the cronet_engine that works inside of Chromium.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1821cea4d1c74024a434527f780c704e4f297d09

commit 1821cea4d1c74024a434527f780c704e4f297d09
Author: gcasto <gcasto@chromium.org>
Date: Wed Oct 05 17:50:45 2016

Add cronet_test to gn_isolate_map.pyl to fix ios-simulator-cronet.

Currently this bot fails with:
MBErr: target "cronet_test" not found in //testing/buildbot/gn_isolate_map.pyl

BUG= 650462 

Review-Url: https://codereview.chromium.org/2396673002
Cr-Commit-Position: refs/heads/master@{#423213}

[modify] https://crrev.com/1821cea4d1c74024a434527f780c704e4f297d09/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/1821cea4d1c74024a434527f780c704e4f297d09/testing/buildbot/manage.py
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef2a6d130430d93b29b4258c814ea94a3cbbfb31

commit ef2a6d130430d93b29b4258c814ea94a3cbbfb31
Author: gcasto <gcasto@chromium.org>
Date: Thu Oct 27 18:57:32 2016

Moving gRPC support interfaces out of cronet and into a new component.

BUG= 650462 

Review-Url: https://codereview.chromium.org/2273403003
Cr-Commit-Position: refs/heads/master@{#428099}

[modify] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/BUILD.gn
[modify] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/cronet/DEPS
[modify] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/cronet/ios/BUILD.gn
[modify] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/cronet/ios/Cronet.h
[modify] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/cronet/ios/Cronet.mm
[delete] https://crrev.com/8dcec2d180e56dcfe84506daac08ef37d7d57a24/components/cronet/ios/cronet_c_for_grpc.cc
[delete] https://crrev.com/8dcec2d180e56dcfe84506daac08ef37d7d57a24/components/cronet/ios/cronet_c_for_grpc.h
[modify] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/cronet/ios/cronet_environment.cc
[modify] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/cronet/ios/cronet_environment.h
[modify] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/cronet/ios/test/BUILD.gn
[delete] https://crrev.com/8dcec2d180e56dcfe84506daac08ef37d7d57a24/components/cronet/ios/test/cronet_bidirectional_stream_test.mm
[modify] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/cronet/ios/test/cronet_http_test.mm
[add] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/cronet/ios/test/get_stream_engine.mm
[add] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/cronet/ios/test/start_cronet.h
[add] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/cronet/ios/test/start_cronet.mm
[add] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/grpc_support/BUILD.gn
[add] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/grpc_support/DEPS
[add] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/grpc_support/OWNERS
[add] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/grpc_support/README.md
[rename] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/grpc_support/bidirectional_stream.cc
[rename] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/grpc_support/bidirectional_stream.h
[add] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/grpc_support/bidirectional_stream_c.cc
[add] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/grpc_support/bidirectional_stream_unittest.cc
[add] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/grpc_support/include/DEPS
[add] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/grpc_support/include/bidirectional_stream_c.h
[add] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/grpc_support/include/headers.gni
[add] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/grpc_support/test/BUILD.gn
[add] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/grpc_support/test/get_stream_engine.cc
[add] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/grpc_support/test/get_stream_engine.h
[rename] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/grpc_support/test/quic_test_server.cc
[rename] https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31/components/grpc_support/test/quic_test_server.h
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b72ebe609598fa876ddd2af0b61636a225486c1

commit 3b72ebe609598fa876ddd2af0b61636a225486c1
Author: mohsen <mohsen@chromium.org>
Date: Thu Oct 27 20:11:40 2016

Revert of Moving gRPC support interfaces out of cronet and into a new component. (patchset #67 id:1300001 of https://codereview.chromium.org/2273403003/ )

Reason for revert:
Causes failures on "Mac10.9 Tests" builder:

https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests/builds/30817

An example failure:

[ RUN      ] BidirectionalStreamDelayRequestHeadersUntilFlush/BidirectionalStreamTest.StartExampleBidiStream/1
[12832:13571:1027/123821:4064068458447:ERROR:quic_simple_server.cc(97)] Listen() failed: net::ERR_ADDRESS_IN_USE
[12832:13571:1027/123821:4064068534048:FATAL:quic_test_server.cc(87)] Check failed: rv >= 0 (-147 vs. 0)Quic server fails to start
0   components_unittests                0x00000001095d79c3 _ZN4base5debug10StackTraceC1Ev + 19
1   components_unittests                0x00000001095ee9d7 _ZN7logging10LogMessageD2Ev + 71
2   components_unittests                0x0000000109461920 _ZN12grpc_support29StartQuicServerOnServerThreadERKN4base8FilePathEPNS0_13WaitableEventE + 608
3   components_unittests                0x00000001095d7f49 _ZN4base5debug13TaskAnnotator7RunTaskEPKcPNS_11PendingTaskE + 217
4   components_unittests                0x00000001095f8236 _ZN4base11MessageLoop7RunTaskEPNS_11PendingTaskE + 390
5   components_unittests                0x00000001095f850c _ZN4base11MessageLoop21DeferOrRunPendingTaskENS_11PendingTaskE + 44
6   components_unittests                0x00000001095f8853 _ZN4base11MessageLoop6DoWorkEv + 371
7   components_unittests                0x00000001095fa223 _ZN4base19MessagePumpLibevent3RunEPNS_11MessagePump8DelegateE + 83
8   components_unittests                0x00000001095f7f9e _ZN4base11MessageLoop10RunHandlerEv + 94
9   components_unittests                0x00000001096103f3 _ZN4base7RunLoop3RunEv + 115
10  components_unittests                0x0000000109630f92 _ZN4base6Thread10ThreadMainEv + 386
11  components_unittests                0x000000010962c6d7 _ZN4base12_GLOBAL__N_110ThreadFuncEPv + 87
12  libsystem_pthread.dylib             0x00007fff8e718899 _pthread_body + 138
13  libsystem_pthread.dylib             0x00007fff8e71872a _pthread_struct_init + 0
14  libsystem_pthread.dylib             0x00007fff8e71cfc9 thread_start + 13

Original issue's description:
> Moving gRPC support interfaces out of cronet and into a new component.
>
> BUG= 650462 
>
> Committed: https://crrev.com/ef2a6d130430d93b29b4258c814ea94a3cbbfb31
> Cr-Commit-Position: refs/heads/master@{#428099}

TBR=mef@chromium.org,blundell@chromium.org,gcasto@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 650462 

Review-Url: https://codereview.chromium.org/2454183002
Cr-Commit-Position: refs/heads/master@{#428122}

[modify] https://crrev.com/3b72ebe609598fa876ddd2af0b61636a225486c1/components/BUILD.gn
[modify] https://crrev.com/3b72ebe609598fa876ddd2af0b61636a225486c1/components/cronet/DEPS
[modify] https://crrev.com/3b72ebe609598fa876ddd2af0b61636a225486c1/components/cronet/ios/BUILD.gn
[modify] https://crrev.com/3b72ebe609598fa876ddd2af0b61636a225486c1/components/cronet/ios/Cronet.h
[modify] https://crrev.com/3b72ebe609598fa876ddd2af0b61636a225486c1/components/cronet/ios/Cronet.mm
[rename] https://crrev.com/3b72ebe609598fa876ddd2af0b61636a225486c1/components/cronet/ios/cronet_bidirectional_stream.cc
[rename] https://crrev.com/3b72ebe609598fa876ddd2af0b61636a225486c1/components/cronet/ios/cronet_bidirectional_stream.h
[add] https://crrev.com/3b72ebe609598fa876ddd2af0b61636a225486c1/components/cronet/ios/cronet_c_for_grpc.cc
[add] https://crrev.com/3b72ebe609598fa876ddd2af0b61636a225486c1/components/cronet/ios/cronet_c_for_grpc.h
[modify] https://crrev.com/3b72ebe609598fa876ddd2af0b61636a225486c1/components/cronet/ios/cronet_environment.cc
[modify] https://crrev.com/3b72ebe609598fa876ddd2af0b61636a225486c1/components/cronet/ios/cronet_environment.h
[modify] https://crrev.com/3b72ebe609598fa876ddd2af0b61636a225486c1/components/cronet/ios/test/BUILD.gn
[add] https://crrev.com/3b72ebe609598fa876ddd2af0b61636a225486c1/components/cronet/ios/test/cronet_bidirectional_stream_test.mm
[modify] https://crrev.com/3b72ebe609598fa876ddd2af0b61636a225486c1/components/cronet/ios/test/cronet_http_test.mm
[delete] https://crrev.com/92d41b244faecf619cbff52ca3f08e4a25afb14e/components/cronet/ios/test/get_stream_engine.mm
[rename] https://crrev.com/3b72ebe609598fa876ddd2af0b61636a225486c1/components/cronet/ios/test/quic_test_server.cc
[rename] https://crrev.com/3b72ebe609598fa876ddd2af0b61636a225486c1/components/cronet/ios/test/quic_test_server.h
[delete] https://crrev.com/92d41b244faecf619cbff52ca3f08e4a25afb14e/components/cronet/ios/test/start_cronet.h
[delete] https://crrev.com/92d41b244faecf619cbff52ca3f08e4a25afb14e/components/cronet/ios/test/start_cronet.mm
[delete] https://crrev.com/92d41b244faecf619cbff52ca3f08e4a25afb14e/components/grpc_support/BUILD.gn
[delete] https://crrev.com/92d41b244faecf619cbff52ca3f08e4a25afb14e/components/grpc_support/DEPS
[delete] https://crrev.com/92d41b244faecf619cbff52ca3f08e4a25afb14e/components/grpc_support/OWNERS
[delete] https://crrev.com/92d41b244faecf619cbff52ca3f08e4a25afb14e/components/grpc_support/README.md
[delete] https://crrev.com/92d41b244faecf619cbff52ca3f08e4a25afb14e/components/grpc_support/bidirectional_stream_c.cc
[delete] https://crrev.com/92d41b244faecf619cbff52ca3f08e4a25afb14e/components/grpc_support/bidirectional_stream_unittest.cc
[delete] https://crrev.com/92d41b244faecf619cbff52ca3f08e4a25afb14e/components/grpc_support/include/DEPS
[delete] https://crrev.com/92d41b244faecf619cbff52ca3f08e4a25afb14e/components/grpc_support/include/bidirectional_stream_c.h
[delete] https://crrev.com/92d41b244faecf619cbff52ca3f08e4a25afb14e/components/grpc_support/include/headers.gni
[delete] https://crrev.com/92d41b244faecf619cbff52ca3f08e4a25afb14e/components/grpc_support/test/BUILD.gn
[delete] https://crrev.com/92d41b244faecf619cbff52ca3f08e4a25afb14e/components/grpc_support/test/get_stream_engine.cc
[delete] https://crrev.com/92d41b244faecf619cbff52ca3f08e4a25afb14e/components/grpc_support/test/get_stream_engine.h
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1821cea4d1c74024a434527f780c704e4f297d09

commit 1821cea4d1c74024a434527f780c704e4f297d09
Author: gcasto <gcasto@chromium.org>
Date: Wed Oct 05 17:50:45 2016

Add cronet_test to gn_isolate_map.pyl to fix ios-simulator-cronet.

Currently this bot fails with:
MBErr: target "cronet_test" not found in //testing/buildbot/gn_isolate_map.pyl

BUG= 650462 

Review-Url: https://codereview.chromium.org/2396673002
Cr-Commit-Position: refs/heads/master@{#423213}

[modify] https://crrev.com/1821cea4d1c74024a434527f780c704e4f297d09/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/1821cea4d1c74024a434527f780c704e4f297d09/testing/buildbot/manage.py

Comment 5 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe

commit 47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe
Author: gcasto <gcasto@chromium.org>
Date: Wed Nov 09 19:01:33 2016

Reland refactor of gRPC. Previous CL was reverted because it used a fixed port for testing, which was sometimes occupied. The test now uses dynamically bound ports for Cronet as well as the grpc_support unittest.

Revert "Revert of Moving gRPC support interfaces out of cronet and into a new component. (patchset #67 id:1300001 of https://codereview.chromium.org/2273403003/ )"

This reverts commit 3b72ebe609598fa876ddd2af0b61636a225486c1.

TBR=blundell@chromium.org
BUG= 650462 

Review-Url: https://codereview.chromium.org/2470923002
Cr-Commit-Position: refs/heads/master@{#430995}

[modify] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/BUILD.gn
[modify] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/cronet/DEPS
[modify] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/cronet/ios/BUILD.gn
[modify] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/cronet/ios/Cronet.h
[modify] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/cronet/ios/Cronet.mm
[delete] https://crrev.com/abe8ce9085986cb01cb9bc397886fb51c307032f/components/cronet/ios/cronet_c_for_grpc.cc
[delete] https://crrev.com/abe8ce9085986cb01cb9bc397886fb51c307032f/components/cronet/ios/cronet_c_for_grpc.h
[modify] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/cronet/ios/cronet_environment.cc
[modify] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/cronet/ios/cronet_environment.h
[modify] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/cronet/ios/test/BUILD.gn
[delete] https://crrev.com/abe8ce9085986cb01cb9bc397886fb51c307032f/components/cronet/ios/test/cronet_bidirectional_stream_test.mm
[modify] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/cronet/ios/test/cronet_http_test.mm
[modify] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/cronet/ios/test/cronet_test_runner.mm
[add] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/cronet/ios/test/get_stream_engine.mm
[add] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/cronet/ios/test/start_cronet.h
[add] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/cronet/ios/test/start_cronet.mm
[add] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/grpc_support/BUILD.gn
[add] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/grpc_support/DEPS
[add] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/grpc_support/OWNERS
[add] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/grpc_support/README.md
[rename] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/grpc_support/bidirectional_stream.cc
[rename] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/grpc_support/bidirectional_stream.h
[add] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/grpc_support/bidirectional_stream_c.cc
[add] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/grpc_support/bidirectional_stream_unittest.cc
[add] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/grpc_support/include/DEPS
[add] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/grpc_support/include/bidirectional_stream_c.h
[add] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/grpc_support/include/headers.gni
[add] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/grpc_support/test/BUILD.gn
[add] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/grpc_support/test/get_stream_engine.cc
[add] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/grpc_support/test/get_stream_engine.h
[rename] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/grpc_support/test/quic_test_server.cc
[rename] https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe/components/grpc_support/test/quic_test_server.h
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f42bc4c56bd255e293109de16b8d19b7adcdc889

commit f42bc4c56bd255e293109de16b8d19b7adcdc889
Author: dpranke <dpranke@chromium.org>
Date: Wed Nov 09 22:38:26 2016

Revert of Revert "Revert of Moving gRPC support interfaces out of cronet and into a new component. (patchset … (patchset #5 id:100001 of https://codereview.chromium.org/2470923002/ )

Reason for revert:
Looks like this broke component_unittests on Android and Windows:

https://build.chromium.org/p/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/6152
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/59755

so I'm going to revert this. Sorry!

Original issue's description:
> Reland refactor of gRPC. Previous CL was reverted because it used a fixed port for testing, which was sometimes occupied. The test now uses dynamically bound ports for Cronet as well as the grpc_support unittest.
>
> Revert "Revert of Moving gRPC support interfaces out of cronet and into a new component. (patchset #67 id:1300001 of https://codereview.chromium.org/2273403003/ )"
>
> This reverts commit 3b72ebe609598fa876ddd2af0b61636a225486c1.
>
> TBR=blundell@chromium.org
> BUG= 650462 
>
> Committed: https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe
> Cr-Commit-Position: refs/heads/master@{#430995}

TBR=mef@chromium.org,gcasto@chromium.org
NOPRESUBMIT=true
BUG= 650462 

Review-Url: https://codereview.chromium.org/2484263005
Cr-Commit-Position: refs/heads/master@{#431058}

[modify] https://crrev.com/f42bc4c56bd255e293109de16b8d19b7adcdc889/components/BUILD.gn
[modify] https://crrev.com/f42bc4c56bd255e293109de16b8d19b7adcdc889/components/cronet/DEPS
[modify] https://crrev.com/f42bc4c56bd255e293109de16b8d19b7adcdc889/components/cronet/ios/BUILD.gn
[modify] https://crrev.com/f42bc4c56bd255e293109de16b8d19b7adcdc889/components/cronet/ios/Cronet.h
[modify] https://crrev.com/f42bc4c56bd255e293109de16b8d19b7adcdc889/components/cronet/ios/Cronet.mm
[rename] https://crrev.com/f42bc4c56bd255e293109de16b8d19b7adcdc889/components/cronet/ios/cronet_bidirectional_stream.cc
[rename] https://crrev.com/f42bc4c56bd255e293109de16b8d19b7adcdc889/components/cronet/ios/cronet_bidirectional_stream.h
[add] https://crrev.com/f42bc4c56bd255e293109de16b8d19b7adcdc889/components/cronet/ios/cronet_c_for_grpc.cc
[add] https://crrev.com/f42bc4c56bd255e293109de16b8d19b7adcdc889/components/cronet/ios/cronet_c_for_grpc.h
[modify] https://crrev.com/f42bc4c56bd255e293109de16b8d19b7adcdc889/components/cronet/ios/cronet_environment.cc
[modify] https://crrev.com/f42bc4c56bd255e293109de16b8d19b7adcdc889/components/cronet/ios/cronet_environment.h
[modify] https://crrev.com/f42bc4c56bd255e293109de16b8d19b7adcdc889/components/cronet/ios/test/BUILD.gn
[add] https://crrev.com/f42bc4c56bd255e293109de16b8d19b7adcdc889/components/cronet/ios/test/cronet_bidirectional_stream_test.mm
[modify] https://crrev.com/f42bc4c56bd255e293109de16b8d19b7adcdc889/components/cronet/ios/test/cronet_http_test.mm
[modify] https://crrev.com/f42bc4c56bd255e293109de16b8d19b7adcdc889/components/cronet/ios/test/cronet_test_runner.mm
[delete] https://crrev.com/6c003cb6963a6b597e50c5f8df2633ad70254a31/components/cronet/ios/test/get_stream_engine.mm
[rename] https://crrev.com/f42bc4c56bd255e293109de16b8d19b7adcdc889/components/cronet/ios/test/quic_test_server.cc
[rename] https://crrev.com/f42bc4c56bd255e293109de16b8d19b7adcdc889/components/cronet/ios/test/quic_test_server.h
[delete] https://crrev.com/6c003cb6963a6b597e50c5f8df2633ad70254a31/components/cronet/ios/test/start_cronet.h
[delete] https://crrev.com/6c003cb6963a6b597e50c5f8df2633ad70254a31/components/cronet/ios/test/start_cronet.mm
[delete] https://crrev.com/6c003cb6963a6b597e50c5f8df2633ad70254a31/components/grpc_support/BUILD.gn
[delete] https://crrev.com/6c003cb6963a6b597e50c5f8df2633ad70254a31/components/grpc_support/DEPS
[delete] https://crrev.com/6c003cb6963a6b597e50c5f8df2633ad70254a31/components/grpc_support/OWNERS
[delete] https://crrev.com/6c003cb6963a6b597e50c5f8df2633ad70254a31/components/grpc_support/README.md
[delete] https://crrev.com/6c003cb6963a6b597e50c5f8df2633ad70254a31/components/grpc_support/bidirectional_stream_c.cc
[delete] https://crrev.com/6c003cb6963a6b597e50c5f8df2633ad70254a31/components/grpc_support/bidirectional_stream_unittest.cc
[delete] https://crrev.com/6c003cb6963a6b597e50c5f8df2633ad70254a31/components/grpc_support/include/DEPS
[delete] https://crrev.com/6c003cb6963a6b597e50c5f8df2633ad70254a31/components/grpc_support/include/bidirectional_stream_c.h
[delete] https://crrev.com/6c003cb6963a6b597e50c5f8df2633ad70254a31/components/grpc_support/include/headers.gni
[delete] https://crrev.com/6c003cb6963a6b597e50c5f8df2633ad70254a31/components/grpc_support/test/BUILD.gn
[delete] https://crrev.com/6c003cb6963a6b597e50c5f8df2633ad70254a31/components/grpc_support/test/get_stream_engine.cc
[delete] https://crrev.com/6c003cb6963a6b597e50c5f8df2633ad70254a31/components/grpc_support/test/get_stream_engine.h
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67ace9323db6baf5d3177ebb243fdcd07d11486a

commit 67ace9323db6baf5d3177ebb243fdcd07d11486a
Author: gcasto <gcasto@chromium.org>
Date: Thu Nov 10 21:44:49 2016

Third try at landing gRPC refactoring. Previous iteration failed on opt builds because it did work inside a DCHECK().

Revert "Revert of Revert "Revert of Moving gRPC support interfaces out of cronet and into a new component. (patchset … (patchset #5 id:100001 of https://codereview.chromium.org/2470923002/ )"

This reverts commit f42bc4c56bd255e293109de16b8d19b7adcdc889.

TBR=blundell@chromium.org
BUG= 650462 

Review-Url: https://codereview.chromium.org/2492703002
Cr-Commit-Position: refs/heads/master@{#431366}

[modify] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/BUILD.gn
[modify] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/cronet/DEPS
[modify] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/cronet/ios/BUILD.gn
[modify] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/cronet/ios/Cronet.h
[modify] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/cronet/ios/Cronet.mm
[delete] https://crrev.com/bc0614e467b9538c2930b93a5c058c8b66c93cac/components/cronet/ios/cronet_c_for_grpc.cc
[delete] https://crrev.com/bc0614e467b9538c2930b93a5c058c8b66c93cac/components/cronet/ios/cronet_c_for_grpc.h
[modify] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/cronet/ios/cronet_environment.cc
[modify] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/cronet/ios/cronet_environment.h
[modify] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/cronet/ios/test/BUILD.gn
[delete] https://crrev.com/bc0614e467b9538c2930b93a5c058c8b66c93cac/components/cronet/ios/test/cronet_bidirectional_stream_test.mm
[modify] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/cronet/ios/test/cronet_http_test.mm
[modify] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/cronet/ios/test/cronet_test_runner.mm
[add] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/cronet/ios/test/get_stream_engine.mm
[add] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/cronet/ios/test/start_cronet.h
[add] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/cronet/ios/test/start_cronet.mm
[add] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/grpc_support/BUILD.gn
[add] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/grpc_support/DEPS
[add] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/grpc_support/OWNERS
[add] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/grpc_support/README.md
[rename] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/grpc_support/bidirectional_stream.cc
[rename] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/grpc_support/bidirectional_stream.h
[add] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/grpc_support/bidirectional_stream_c.cc
[add] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/grpc_support/bidirectional_stream_unittest.cc
[add] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/grpc_support/include/DEPS
[add] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/grpc_support/include/bidirectional_stream_c.h
[add] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/grpc_support/include/headers.gni
[add] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/grpc_support/test/BUILD.gn
[add] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/grpc_support/test/get_stream_engine.cc
[add] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/grpc_support/test/get_stream_engine.h
[rename] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/grpc_support/test/quic_test_server.cc
[rename] https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a/components/grpc_support/test/quic_test_server.h

Comment 9 by amineer@chromium.org, Nov 29 2016

Status: WontFix (was: Started)
Obsolete, WontFix.

Comment 10 by amineer@chromium.org, Dec 9 2016

Labels: Archive-Blimp

Comment 11 by gcasto@chromium.org, Dec 12 2016

Components: -Mobile>Blimp
Status: Started (was: WontFix)
This will no longer be used for Blimp, but other teams my still make use of this work. Keeping this bug around for now.

Comment 12 by mef@chromium.org, Jan 3 2017 

Per conversation with GRPC folks this refactor is going to block updates of Cronet for iOS for at least a few weeks.

In order to unblock updates I'm going to add a temporary shim from old API to new API: https://codereview.chromium.org/2611853002
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/233f9faa257fdad767900274a66b67160ee66094

commit 233f9faa257fdad767900274a66b67160ee66094
Author: mef <mef@chromium.org>
Date: Wed Jan 04 23:34:50 2017

[Cronet] Provide shim from deprecated cronet_c_for_grpc.h API to bidirectional_stream_c.h API on iOS.

BUG= 650462 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2611853002
Cr-Commit-Position: refs/heads/master@{#441509}

[modify] https://crrev.com/233f9faa257fdad767900274a66b67160ee66094/components/cronet/ios/BUILD.gn
[modify] https://crrev.com/233f9faa257fdad767900274a66b67160ee66094/components/cronet/ios/Cronet.h
[add] https://crrev.com/233f9faa257fdad767900274a66b67160ee66094/components/cronet/ios/cronet_c_for_grpc.h
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc4bfa2ea2405820f0441dedd2c2e36f918f9c00

commit bc4bfa2ea2405820f0441dedd2c2e36f918f9c00
Author: Misha Efimov <mef@chromium.org>
Date: Wed Jun 14 13:19:42 2017

[Cronet] Remove shim cronet_c_for_grpc.h from Cronet framework.

Bug:  650462 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: Ie46ae8d3415a67258a1d50c09e35d2e6ac293176
Reviewed-on: https://chromium-review.googlesource.com/533753
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479367}
[modify] https://crrev.com/bc4bfa2ea2405820f0441dedd2c2e36f918f9c00/components/cronet/ios/BUILD.gn
[modify] https://crrev.com/bc4bfa2ea2405820f0441dedd2c2e36f918f9c00/components/cronet/ios/Cronet.h
[delete] https://crrev.com/c825632ff5cbb347dbc6aead3c5e305eb74d3e4b/components/cronet/ios/cronet_c_for_grpc.h
[modify] https://crrev.com/bc4bfa2ea2405820f0441dedd2c2e36f918f9c00/ios/web_view/BUILD.gn

Comment 15 by mef@chromium.org, Dec 21

Status: Fixed (was: Started)
►

Sign in to add a comment