system_health.common_mobile failing for system webview |
|||
Issue description
,
Sep 26 2016
,
Sep 26 2016
Note: I know as a benchmark wide way you can use @benchmark.Enable('has tabs') but I do not know if that works on a single page in the system health page sets. Since single page disabling is relatively new to user stories, I'm guessing it doesn't work?
,
Sep 26 2016
You may want to override "ShouldDisable" to return True if the possible_browser is webview
,
Sep 27 2016
I'm not sure how to do that just for webview. I did some digging and the way most other things do stuff like this would be to run possible_browser.platform.GetOSName() which returns android. I did some experimenting by printing these values in ShouldDisable in a benchmark, and confirm my suspicions. Clank and webview use the same backend, so I am not sure how to determine which one is being used.
,
Sep 27 2016
Ah, actually it looks like you can disable with 'android-webview' key: https://cs.chromium.org/chromium/src/tools/perf/benchmarks/power.py?rcl=0&l=47
,
Sep 27 2016
Thats at the benchmark level though, will that work on a page level for system health tests? On a side note I think I found a way to do it through ShouldDisable
,
Sep 27 2016
It should also work on page level for system health pages. If not, it's a bug.
,
Sep 27 2016
Tested locally, works as expected. CL inbound.
,
Sep 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a0e7edd2376bba70eee655a40f46de4d255b14a commit 9a0e7edd2376bba70eee655a40f46de4d255b14a Author: rnephew <rnephew@chromium.org> Date: Tue Sep 27 17:16:07 2016 [Telemetry] Disable long running backgrounded gmail system health test on webview. Webview does not have tabs so it cannot be backgrounded in the same way as other browser types. BUG= 650458 Review-Url: https://codereview.chromium.org/2370913003 Cr-Commit-Position: refs/heads/master@{#421244} [modify] https://crrev.com/9a0e7edd2376bba70eee655a40f46de4d255b14a/tools/perf/page_sets/system_health/long_running_stories.py
,
Sep 29 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by rnep...@chromium.org
, Sep 26 2016Traceback (most recent call last): File "/b/rr/tmpgNeSAQ/w/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 86, in _RunStoryAndProcessErrorIfNeeded state.RunStory(results) File "/b/rr/tmpgNeSAQ/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function return func(*args, **kwargs) File "/b/rr/tmpgNeSAQ/w/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 304, in RunStory self._current_page.Run(self) File "/b/rr/tmpgNeSAQ/w/src/third_party/catapult/telemetry/telemetry/page/__init__.py", line 99, in Run self.RunPageInteractions(action_runner) File "/b/rr/tmpgNeSAQ/w/src/tools/perf/page_sets/system_health/long_running_stories.py", line 23, in RunPageInteractions action_runner.tab.browser.tabs.New() File "/b/rr/tmpgNeSAQ/w/src/third_party/catapult/telemetry/telemetry/internal/browser/tab_list.py", line 9, in New return self._tab_list_backend.New(timeout) File "/b/rr/tmpgNeSAQ/w/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/tab_list_backend.py", line 33, in New raise NotImplementedError("Browser doesn't support tab control.") NotImplementedError: Browser doesn't support tab control. This is caused by my long_running background test I added awhile back. +Ned Is there a decorator for disabling only on webview? I did a quick search and nothing really popped out at me.