Actually marking M-55.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8512a83031e6531c976f4af85a28dbeef58bd635

commit 8512a83031e6531c976f4af85a28dbeef58bd635
Author: dfalcantara <dfalcantara@chromium.org>
Date: Fri Oct 14 19:53:13 2016

[Blink] Display images in the center of the screen

Code was adapted from MediaDocument.cpp.  Additions were
made to let the image be zoomed to full width on both
mobile and desktop.

Had to edit TestExpectations to deal with the virtual tests
failing to work with the command line rebaselining tool,
but some of the suggested changes are included here.

Intent to implement:
https://docs.google.com/document/d/1wJPz4kn-9mEFs_ZEM0hAwwr-YzBdW-5hdX1-jkt81Ng/edit?usp=sharing

Images of proposed changes:
https://drive.google.com/drive/folders/0B8k2SmEN8xS3RHJGSVpNZjVtUUE?usp=sharing

BUG=650456

Review-Url: https://codereview.chromium.org/2376163002
Cr-Commit-Position: refs/heads/master@{#425440}

[modify] https://crrev.com/8512a83031e6531c976f4af85a28dbeef58bd635/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/8512a83031e6531c976f4af85a28dbeef58bd635/third_party/WebKit/LayoutTests/fast/images/exif-orientation-height-image-document-expected.png
[modify] https://crrev.com/8512a83031e6531c976f4af85a28dbeef58bd635/third_party/WebKit/LayoutTests/fast/images/exif-orientation-height-image-document-expected.txt
[modify] https://crrev.com/8512a83031e6531c976f4af85a28dbeef58bd635/third_party/WebKit/LayoutTests/fast/images/image-click-scale-restore-zoomed-image-expected.txt
[modify] https://crrev.com/8512a83031e6531c976f4af85a28dbeef58bd635/third_party/WebKit/LayoutTests/fast/images/image-zoom-to-25-expected.txt
[modify] https://crrev.com/8512a83031e6531c976f4af85a28dbeef58bd635/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/image-document-default-src-none-expected.txt
[add] https://crrev.com/8512a83031e6531c976f4af85a28dbeef58bd635/third_party/WebKit/LayoutTests/platform/android/fast/images/image-click-scale-restore-zoomed-image-expected.txt
[add] https://crrev.com/8512a83031e6531c976f4af85a28dbeef58bd635/third_party/WebKit/LayoutTests/platform/android/http/tests/security/contentSecurityPolicy/image-document-default-src-none-expected.txt
[modify] https://crrev.com/8512a83031e6531c976f4af85a28dbeef58bd635/third_party/WebKit/LayoutTests/svg/custom/anchor-on-use-expected.svg
[modify] https://crrev.com/8512a83031e6531c976f4af85a28dbeef58bd635/third_party/WebKit/Source/core/html/ImageDocument.cpp
[modify] https://crrev.com/8512a83031e6531c976f4af85a28dbeef58bd635/third_party/WebKit/Source/core/html/ImageDocument.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cd3a6a5c19014f91361982145d5c454967454e7

commit 6cd3a6a5c19014f91361982145d5c454967454e7
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Fri Oct 14 22:12:50 2016

Auto-rebaseline for r425440

https://chromium.googlesource.com/chromium/src/+/8512a8303

BUG=650456
TBR=dfalcantara@chromium.org

Review URL: https://codereview.chromium.org/2419203002 .

Cr-Commit-Position: refs/heads/master@{#425490}

[modify] https://crrev.com/6cd3a6a5c19014f91361982145d5c454967454e7/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/6cd3a6a5c19014f91361982145d5c454967454e7/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/exif-orientation-height-image-document-expected.png
[modify] https://crrev.com/6cd3a6a5c19014f91361982145d5c454967454e7/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/exif-orientation-height-image-document-expected.png
[modify] https://crrev.com/6cd3a6a5c19014f91361982145d5c454967454e7/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/exif-orientation-height-image-document-expected.png
[modify] https://crrev.com/6cd3a6a5c19014f91361982145d5c454967454e7/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/fast/images/image-zoom-to-25-expected.txt

This CL seems to have stuck; I accidentally noticed it working in Canary on desktop and thought "geez, that looks swell".

 Issue 249272  has been merged into this issue.

 Issue 118636  has been merged into this issue.

Images with orientation are not handled correctly with the changes above.

For example, load http://fredericiana.com/media/2013/monalisa.jpg and resize to see odd effects with light box being off-center ... example attached.

Deleted: Screen Shot 2017-11-06 at 1.24.59 PM.png 1.2 MB

	Screen Shot 2017-11-06 at 1.24.59 PM.png 1.2 MB View Download

^^^ Tested with Version 64.0.3253.3 (Official Build) dev (64-bit) Mac OSX.

Marking as untriaged, so it comes up in our weekly triage queue

Those effects may related to color correction. +ccameron@.

The background is supposed to be sRGB 0.05,0.05,0.05

There shouldn't be a lightbox -- the black there should should match the background (they go through different paths) -- it's "acceptable" for the color values to be off by 1/255, but that seems like quite a bit. Could you upload that monitor's color profile.

According to System Preferences -> Displays, the screen I recorded on is using the ./System/Library/ColorSync/Profiles/DCI(P3) RGB.icc profile.  FWIW, I see the same issue if I use the ./System/Library/ColorSync/Profiles/AdobeRGB1998.icc profile.

Using dev-tools show "Layer borders" feature, I notice the "off-center light box" is exactly correlated with compositing tile boundaries.

Deleted: DCI(P3) RGB.icc 548 bytes

DCI(P3) RGB.icc 548 bytes Download