New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 650455 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Remove white background flash from media playback CCT

Project Member Reported by dah...@chromium.org, Sep 26 2016

Issue description

Per UI review, we should always start with the black background instead of flashing from white to black.

This is a non-blocking bug for M55, but important for product excellence.
 
Labels: M-55
Actually marking M-55.

Comment 2 by dah...@chromium.org, Oct 27 2016

Labels: -M-55 M-56
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98b66eba2a1509a2c7d2d6a4ecab6c270a761092

commit 98b66eba2a1509a2c7d2d6a4ecab6c270a761092
Author: dfalcantara <dfalcantara@chromium.org>
Date: Fri Nov 04 06:57:17 2016

[Blink] Display images on a dark background

Images displayed in a standalone main frame are now displayed
on a color that is almost, but not quite, entirely unlike black.
More specifically, all images will now be displayed on a #0E0E0E
page background, while transparent images are displayed on a
checkerboard image background.

Intent to implement:
https://docs.google.com/document/d/1wJPz4kn-9mEFs_ZEM0hAwwr-YzBdW-5hdX1-jkt81Ng/edit?usp=sharing

BUG= 650455 

Review-Url: https://codereview.chromium.org/2445413003
Cr-Commit-Position: refs/heads/master@{#429820}

[modify] https://crrev.com/98b66eba2a1509a2c7d2d6a4ecab6c270a761092/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/98b66eba2a1509a2c7d2d6a4ecab6c270a761092/third_party/WebKit/LayoutTests/fast/images/exif-orientation-height-image-document-expected.png
[modify] https://crrev.com/98b66eba2a1509a2c7d2d6a4ecab6c270a761092/third_party/WebKit/LayoutTests/fast/images/huge-image-viewport-scale-expected.txt
[modify] https://crrev.com/98b66eba2a1509a2c7d2d6a4ecab6c270a761092/third_party/WebKit/LayoutTests/mhtml/image_document-expected.txt
[modify] https://crrev.com/98b66eba2a1509a2c7d2d6a4ecab6c270a761092/third_party/WebKit/LayoutTests/mhtml/invalid-bad-boundary2-expected.txt
[modify] https://crrev.com/98b66eba2a1509a2c7d2d6a4ecab6c270a761092/third_party/WebKit/LayoutTests/svg/custom/anchor-on-use-expected.svg
[modify] https://crrev.com/98b66eba2a1509a2c7d2d6a4ecab6c270a761092/third_party/WebKit/Source/core/html/ImageDocument.cpp
[modify] https://crrev.com/98b66eba2a1509a2c7d2d6a4ecab6c270a761092/third_party/WebKit/Source/core/html/ImageDocument.h

Just found that the CL I landed leaves a single pixel checkerboard pattern visible above and/or below images that are too wide and have to be shrunken down.  Ugh.  Investigating.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73877006b0b2cda3b6906f376f852d58b0c2ba4b

commit 73877006b0b2cda3b6906f376f852d58b0c2ba4b
Author: dfalcantara <dfalcantara@chromium.org>
Date: Wed Nov 09 00:08:42 2016

[Download Home] Custom tab backgrounds

* Background and toolbar of the Custom Tab should be
  off-black for images and black for all other media.

* Add an extra to the Intent that allows changing the
  background.

* Overrides ChromeActivity methods so that the colors
  can be set at the right times.

* Add a method to disable the toolbar shadow.

BUG= 650455 

Review-Url: https://codereview.chromium.org/2484053002
Cr-Commit-Position: refs/heads/master@{#430780}

[modify] https://crrev.com/73877006b0b2cda3b6906f376f852d58b0c2ba4b/chrome/android/java/res/values/colors.xml
[modify] https://crrev.com/73877006b0b2cda3b6906f376f852d58b0c2ba4b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/73877006b0b2cda3b6906f376f852d58b0c2ba4b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
[modify] https://crrev.com/73877006b0b2cda3b6906f376f852d58b0c2ba4b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/73877006b0b2cda3b6906f376f852d58b0c2ba4b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadFilter.java
[modify] https://crrev.com/73877006b0b2cda3b6906f376f852d58b0c2ba4b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

Should be mostly in now.  Some animation jankiness can be tackled on the animation bug.
Status: Fixed (was: Assigned)

Comment 8 by jay...@chromium.org, Nov 15 2016

Status: Assigned (was: Fixed)
dfalcantara@ : Does this fix the issue mentioned in comment#4 ? I still see the single pixel checkerboard pattern on 56.0.2919.3

Screenshot - http://go/chrome-androidlogs1/6/650455
Status: Fixed (was: Assigned)
Unrelated.  See 662593.
Well, related, but actually a bug in Blink.
Status: Verified (was: Fixed)
Thanks dfalcantara@ ! Marking this bug as verified then.

Sign in to add a comment