New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 650449 link

Starred by 2 users
Status: Verified
Owner:
mlamouri@chromium.org
Closed: Sep 2016
Cc:
mlamouri@chromium.org
█ dah...@chromium.org
█ ranjitkan@chromium.org
█ dfalcant...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Download button should not be shown during playback of downloaded files

Project Member Reported by dah...@chromium.org, Sep 26 2016 
Per UI review feedback, we should remove the download button from the media controls for downloaded content. According to Mounir, 
"I think it should be possible to hide the download button from a UA stylesheet using ::-internal-download-button pseudo element selector. I'm changing this name to "::-internal-media-controls-download-button" but that change hasn't landed yet."

This is a blocking bug for M55.

Comment 1 by dfalcant...@chromium.org, Sep 27 2016

Cc: mlamouri@chromium.org
Labels: M-55 ReleaseBlock-Stable
Marking M55, RBS as per bug report.

Comment 2 by mlamouri@chromium.org, Sep 28 2016 

You can now use ::-internal-media-controls-download-button on trunk.

dfalcantara@, feel free to ping me on IM. We can see what we can do here.

Comment 3 by gov...@chromium.org, Sep 29 2016 

Is this bug applicable to any specific OS or all OSs?

Comment 4 by mlamouri@chromium.org, Sep 29 2016

Cc: -mlamouri@chromium.org dfalcant...@chromium.org
Labels: OS-All
Owner: mlamouri@chromium.org
Status: Started (was: Assigned)
I have a CL disabling the download button for file://

Comment 5 by dah...@chromium.org, Sep 29 2016

Cc: dah...@chromium.org mlamouri@chromium.org
 Issue 651424  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a

commit aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a
Author: mlamouri <mlamouri@chromium.org>
Date: Fri Sep 30 13:59:12 2016

Don't show media controls download button on local files.

It requires moving a lot of tests so the files are not local.

BUG= 650449 
R=dfalcantara@chromium.org

Review-Url: https://codereview.chromium.org/2376293004
Cr-Commit-Position: refs/heads/master@{#422103}

[rename] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/http/tests/media/video-controls-download-button-displayed.html
[rename] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/http/tests/media/video-controls-download-button-not-displayed-mediastream.html
[rename] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/http/tests/media/video-controls-download-button-not-displayed-mse.html
[rename] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/http/tests/media/video-controls-download-button-saves-media-expected.txt
[rename] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/http/tests/media/video-controls-download-button-saves-media.html
[rename] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/http/tests/media/video-controls-overflow-menu-correct-ordering.html
[rename] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/http/tests/media/video-controls-overflow-menu-download-button-expected.txt
[rename] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/http/tests/media/video-controls-overflow-menu-download-button.html
[rename] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/http/tests/media/video-controls-overflow-menu-updates-appropriately.html
[copy] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/media/video-controls-download-button-not-displayed-local.html
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/paint/invalidation/video-mute-repaint-expected.txt
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/paint/invalidation/video-unmute-repaint-expected.txt
[delete] https://crrev.com/925f8db388b50ca65b17aa6b16d385d577aa8454/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/video-mute-repaint-expected.txt
[delete] https://crrev.com/925f8db388b50ca65b17aa6b16d385d577aa8454/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/video-unmute-repaint-expected.txt
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/linux/compositing/video/video-controls-layer-creation-expected.png
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.png
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.txt
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-iframe-allowed-video-expected.png
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-controls-timeline-expected.png
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-scrolled-iframe-expected.png
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-controls-layer-creation-expected.png
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/mac/media/controls-timeline-expected.txt
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/mac/media/video-zoom-controls-expected.png
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/mac/media/video-zoom-controls-expected.txt
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/win/media/video-zoom-controls-expected.png
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/win/media/video-zoom-controls-expected.txt
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

Comment 7 by mlamouri@chromium.org, Sep 30 2016

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a

commit aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a
Author: mlamouri <mlamouri@chromium.org>
Date: Fri Sep 30 13:59:12 2016

Don't show media controls download button on local files.

It requires moving a lot of tests so the files are not local.

BUG= 650449 
R=dfalcantara@chromium.org

Review-Url: https://codereview.chromium.org/2376293004
Cr-Commit-Position: refs/heads/master@{#422103}

[rename] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/http/tests/media/video-controls-download-button-displayed.html
[rename] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/http/tests/media/video-controls-download-button-not-displayed-mediastream.html
[rename] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/http/tests/media/video-controls-download-button-not-displayed-mse.html
[rename] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/http/tests/media/video-controls-download-button-saves-media-expected.txt
[rename] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/http/tests/media/video-controls-download-button-saves-media.html
[rename] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/http/tests/media/video-controls-overflow-menu-correct-ordering.html
[rename] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/http/tests/media/video-controls-overflow-menu-download-button-expected.txt
[rename] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/http/tests/media/video-controls-overflow-menu-download-button.html
[rename] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/http/tests/media/video-controls-overflow-menu-updates-appropriately.html
[copy] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/media/video-controls-download-button-not-displayed-local.html
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/paint/invalidation/video-mute-repaint-expected.txt
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/paint/invalidation/video-unmute-repaint-expected.txt
[delete] https://crrev.com/925f8db388b50ca65b17aa6b16d385d577aa8454/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/video-mute-repaint-expected.txt
[delete] https://crrev.com/925f8db388b50ca65b17aa6b16d385d577aa8454/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/video-unmute-repaint-expected.txt
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/linux/compositing/video/video-controls-layer-creation-expected.png
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.png
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.txt
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-iframe-allowed-video-expected.png
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-controls-timeline-expected.png
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-scrolled-iframe-expected.png
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-controls-layer-creation-expected.png
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/mac/media/controls-timeline-expected.txt
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/mac/media/video-zoom-controls-expected.png
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/mac/media/video-zoom-controls-expected.txt
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/win/media/video-zoom-controls-expected.png
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/LayoutTests/platform/win/media/video-zoom-controls-expected.txt
[modify] https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

Comment 9 by ranjitkan@chromium.org, Oct 4 2016

Cc: ranjitkan@chromium.org
Labels: Needs-Feedback
Just tried with the following Steps on chrome version 55.0.2880.0 on Windows 10 and MAC 10.11.6.

1) Launched chrome and Downloaded one .mp4 video file 
2) Opened a new tab and pressed Ctrl+O to open the downloaded video file.
3) Video played on the chrome tab and No download button was displayed on the page.

@ mlamouri: Request you to please confirm if this is the expected behavior. if not could you please help us with the steps to validate the issue.

Thanks.!

Comment 10 by mlamouri@chromium.org, Oct 4 2016

Labels: -Needs-Feedback
Status: Verified (was: Fixed)
Yes, it was is expected. Thanks for verifying.
Project Member

Comment 11 by blocker...@chrome-infra-auth.iam.gserviceaccount.com, Oct 28 2016

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-55; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-55 label, otherwise remove Merge-TBD label. Thanks.

Comment 12 by dfalcant...@chromium.org, Oct 28 2016

Labels: -Merge-TBD
►

Sign in to add a comment