New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 650448 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Open action from snackbar, notifications, etc. for media should open CCT

Project Member Reported by dah...@chromium.org, Sep 26 2016

Issue description

Per UI review feedback, all open actions for downloaded media should go to the CCT playback experience.

This is a blocking bug for m55.
 
Cc: ian...@chromium.org qin...@chromium.org
Labels: M-55 ReleaseBlock-Stable
Marking M55, RBS as per bug report.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b442abfbfcd93afdd00d7dd106e71bddbaf19ac

commit 4b442abfbfcd93afdd00d7dd106e71bddbaf19ac
Author: dfalcantara <dfalcantara@chromium.org>
Date: Tue Oct 04 00:24:49 2016

[Downloads] Open media downloads internally

* Force the Custom Tab Intent to use the same package as Chrome
  when opening the media viewer.

* Open media downloads inside of the internal media viewer when
  opening the file in the notification or via the snackbar.

* Shuffle code around for creating media viewer Intents in the
  hopes of consolidating them in places that makes sense.

BUG= 650448 

Review-Url: https://codereview.chromium.org/2376893006
Cr-Commit-Position: refs/heads/master@{#422624}

[modify] https://crrev.com/4b442abfbfcd93afdd00d7dd106e71bddbaf19ac/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadBroadcastReceiver.java
[modify] https://crrev.com/4b442abfbfcd93afdd00d7dd106e71bddbaf19ac/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/4b442abfbfcd93afdd00d7dd106e71bddbaf19ac/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/4b442abfbfcd93afdd00d7dd106e71bddbaf19ac/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java
[modify] https://crrev.com/4b442abfbfcd93afdd00d7dd106e71bddbaf19ac/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/4b442abfbfcd93afdd00d7dd106e71bddbaf19ac/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java
[modify] https://crrev.com/4b442abfbfcd93afdd00d7dd106e71bddbaf19ac/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadFilter.java
[modify] https://crrev.com/4b442abfbfcd93afdd00d7dd106e71bddbaf19ac/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java
[modify] https://crrev.com/4b442abfbfcd93afdd00d7dd106e71bddbaf19ac/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
[modify] https://crrev.com/4b442abfbfcd93afdd00d7dd106e71bddbaf19ac/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java
[modify] https://crrev.com/4b442abfbfcd93afdd00d7dd106e71bddbaf19ac/chrome/browser/android/download/download_manager_service.cc

Status: Fixed (was: Assigned)
Verified in M55-55.0.2880.3 build
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-55; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-55 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD

Sign in to add a comment