New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 650447 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Change Open Externally string to Open with...

Project Member Reported by dah...@chromium.org, Sep 26 2016

Issue description

Per UI review for the download media playback CCT, we need to update the "Open Externally" to "Open with..."

This is a blocking bug for the M55 release.

 
Cc: ainslie@chromium.org
Labels: M-55 ReleaseBlock-Stable
Marking M55, RBS as per bug report.

Was told to force the Intent picker to appear every time the user selected the option instead of opening the app the user chose to default to.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f5ce82e33afe872b6959dc381925666b14a413f

commit 4f5ce82e33afe872b6959dc381925666b14a413f
Author: dfalcantara <dfalcantara@chromium.org>
Date: Thu Sep 29 21:14:47 2016

[Download Home] Various M55 adjustments

* Replace "Open externally" with "Open with..." and force a chooser to
  appear when there's more than one possibility for an app, even if the
  user has a default set.

* Replace file size display with logical size values that are smaller
  than GB

* Replace X with <-

BUG= 650451 , 650447 , 643795 

Review-Url: https://codereview.chromium.org/2359763003
Cr-Commit-Position: refs/heads/master@{#421933}

[modify] https://crrev.com/4f5ce82e33afe872b6959dc381925666b14a413f/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
[modify] https://crrev.com/4f5ce82e33afe872b6959dc381925666b14a413f/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/4f5ce82e33afe872b6959dc381925666b14a413f/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java
[modify] https://crrev.com/4f5ce82e33afe872b6959dc381925666b14a413f/chrome/android/java/src/org/chromium/chrome/browser/download/ui/SpaceDisplay.java
[modify] https://crrev.com/4f5ce82e33afe872b6959dc381925666b14a413f/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/4f5ce82e33afe872b6959dc381925666b14a413f/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java

Status: Fixed (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-55; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-55 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD

Sign in to add a comment