New issue
Advanced search Search tips

Issue 650442 link

Starred by 1 user
Status: Fixed
Owner:
waff...@chromium.org
Closed: Oct 2016
Cc:
kerrnel@chromium.org
wfh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Fake flash is registered even if --ppapi-flash-path is passed.

Project Member Reported by waff...@chromium.org, Sep 26 2016 
Due to how chrome_content_client.cc is structured, even if you pass Flash by the command line, the fake placeholder Flash will still be added to chrome://components.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1512fef16d73a51f020954dc81e51d84bc0e921

commit a1512fef16d73a51f020954dc81e51d84bc0e921
Author: waffles <waffles@chromium.org>
Date: Sun Oct 02 14:45:06 2016

Don't add fake flash when command-line flash exists.

BUG= 650442 

Review-Url: https://codereview.chromium.org/2370683003
Cr-Commit-Position: refs/heads/master@{#422347}

[modify] https://crrev.com/a1512fef16d73a51f020954dc81e51d84bc0e921/chrome/common/chrome_content_client.cc

Comment 2 by lafo...@chromium.org, Oct 3 2016

Labels: M-55 Merge-Request-54

Comment 3 by dimu@chromium.org, Oct 3 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 3 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2ae665277b015b0c050ebdb924f93cbe714337e

commit c2ae665277b015b0c050ebdb924f93cbe714337e
Author: Joshua Pawlicki <waffles@google.com>
Date: Mon Oct 03 18:16:01 2016

Don't add fake flash when command-line flash exists.

BUG= 650442 

Review-Url: https://codereview.chromium.org/2370683003
Cr-Commit-Position: refs/heads/master@{#422347}
(cherry picked from commit a1512fef16d73a51f020954dc81e51d84bc0e921)

Review URL: https://codereview.chromium.org/2390613003 .

Cr-Commit-Position: refs/branch-heads/2840@{#623}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/c2ae665277b015b0c050ebdb924f93cbe714337e/chrome/common/chrome_content_client.cc

Comment 5 by waff...@chromium.org, Oct 3 2016

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2ae665277b015b0c050ebdb924f93cbe714337e

commit c2ae665277b015b0c050ebdb924f93cbe714337e
Author: Joshua Pawlicki <waffles@google.com>
Date: Mon Oct 03 18:16:01 2016

Don't add fake flash when command-line flash exists.

BUG= 650442 

Review-Url: https://codereview.chromium.org/2370683003
Cr-Commit-Position: refs/heads/master@{#422347}
(cherry picked from commit a1512fef16d73a51f020954dc81e51d84bc0e921)

Review URL: https://codereview.chromium.org/2390613003 .

Cr-Commit-Position: refs/branch-heads/2840@{#623}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/c2ae665277b015b0c050ebdb924f93cbe714337e/chrome/common/chrome_content_client.cc
►

Sign in to add a comment