New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 650395 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

BattOr serial log fails to upload on failure on windows platform

Project Member Reported by rnep...@chromium.org, Sep 26 2016

Issue description

It is likely because the file is open elsewhere. Windows is very strict on file access. 


https://build.chromium.org/p/chromium.perf/builders/Win%2010%20High-DPI%20Perf%20%285%29/builds/109/steps/battor.tough_video_cases/logs/stdio


CRITICAL:root:Finding return code for BattOr shell.
CRITICAL:root:Found return code: None
INFO:root:Uploading c:\users\chrome~1.lab\appdata\local\temp\tmpdbwlnt to gs://chrome-telemetry-output/battor-serial-log-2016-09-25_15-04.txt-7011.txt
WARNING:root:Cannot dump browser state: No browser.
WARNING:root:Either tab has crashed or browser does not support taking tab screenshot. Skip taking screenshot on failure.
Traceback (most recent call last):
  File "C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\telemetry\telemetry\internal\story_runner.py", line 78, in _RunStoryAndProcessErrorIfNeeded
    test.WillRunStory(state.platform)
  File "C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\telemetry\telemetry\web_perf\timeline_based_measurement.py", line 282, in WillRunStory
    platform.tracing_controller.StartTracing(self._tbm_options.config)
  File "C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\telemetry\telemetry\core\tracing_controller.py", line 43, in StartTracing
    self._tracing_controller_backend.StartTracing(tracing_config, timeout)
  File "C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\telemetry\telemetry\internal\platform\tracing_controller_backend.py", line 91, in StartTracing
    if agent.StartAgentTracing(config, timeout):
  File "C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\telemetry\telemetry\internal\platform\tracing_agent\battor_tracing_agent.py", line 73, in StartAgentTracing
    self._battor.StartTracing()
  File "C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\common\battor\battor\battor_wrapper.py", line 155, in StartTracing
    self._SendBattorCommand(self._START_TRACING_CMD)
  File "C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\common\battor\battor\battor_wrapper.py", line 265, in _SendBattorCommand
    self._UploadSerialLogToCloudStorage()
  File "C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\common\battor\battor\battor_wrapper.py", line 288, in _UploadSerialLogToCloudStorage
    self._serial_log_bucket, remote_path, self._serial_log_file.name)
  File "C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\common\py_utils\py_utils\cloud_storage.py", line 315, in Insert
    _RunCommand(command_and_args)
  File "C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\common\py_utils\py_utils\cloud_storage.py", line 160, in _RunCommand
    raise CloudStorageError(stderr)
CloudStorageError: CommandException: Error opening file "file://c:\users\chrome~1.lab\appdata\local\temp\tmpdbwlnt": .
 
Labels: OS-Windows
Owner: rnep...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b362de8c2ff04a58f275778a382500372f78b670

commit b362de8c2ff04a58f275778a382500372f78b670
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Tue Sep 27 03:11:24 2016

Roll src/third_party/catapult/ 28c78c375..333ad9c49 (2 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/28c78c375477..333ad9c490dd

$ git log 28c78c375..333ad9c49 --date=short --no-merges --format='%ad %ae %s'
2016-09-26 rnephew [BattOr] Make BattOr attempt to upload serial trace at exit if it fails doing so earlier.
2016-09-26 lpy Add vertical support in radio picker.

BUG= 650395 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2366203005
Cr-Commit-Position: refs/heads/master@{#421090}

[modify] https://crrev.com/b362de8c2ff04a58f275778a382500372f78b670/DEPS

Cc: alexandermont@chromium.org rnep...@chromium.org aiolos@chromium.org
 Issue 652348  has been merged into this issue.

Comment 4 by zh...@chromium.org, Oct 3 2016

Labels: -Pri-2 Performance-Sheriff-BotHealth Pri-1
This affect perf bots. Upgrading to pri-1.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/036c5f84288d362915dde6d44734c5a832cad108

commit 036c5f84288d362915dde6d44734c5a832cad108
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Fri Oct 07 23:51:08 2016

Roll src/third_party/catapult/ 0a0e13e30..455c70b71 (6 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0a0e13e30fe5..455c70b716be

$ git log 0a0e13e30..455c70b71 --date=short --no-merges --format='%ad %ae %s'
2016-10-07 nednguyen [telemetry] Add API for dumping system log when there is browser crash & implement it for Mac
2016-10-07 charliea [battor wrapper] Fix uploading of the serial log on Windows
2016-10-07 benjhayden Enforce One True Brace Style in eslint.
2016-10-07 alexandermont Make the clock sync metric report the latency between each pair of clock domains in the trace, regardless of which clock domain is chosen as the "model" clock domain.
2016-10-07 charliea Remove logging for  crbug.com/645106  now that it's closed
2016-10-07 lpy Add test for V8 GC objects stats table.

BUG= 653870 , 650395 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2405543003
Cr-Commit-Position: refs/heads/master@{#424017}

[modify] https://crrev.com/036c5f84288d362915dde6d44734c5a832cad108/DEPS

Status: WontFix (was: Assigned)
Not failing anymore. 

Sign in to add a comment