New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 650394 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Ctrl + F4 is not working for external display switching between modes (Extended and Mirror)

Project Member Reported by son...@google.com, Sep 26 2016

Issue description

Version:8838.0.0 
OS: Chrome

What steps will reproduce the problem?
(1) Sign in to the device.
(2) Connect external monitor. 
(3) Try to use "Ctrl + F4" to switch between modes (Extended and Mirror)

What is the expected output?
Ctrl + F4 should work for switching between modes (Extended and Mirror)


What do you see instead?
Ctrl + F4 is not working for switching between modes (Extended and Mirror)

Note: Able to switch between modes using UI settings.

Please use labels and text to provide additional information.

 

Comment 2 by ka...@chromium.org, Sep 26 2016

Cc: osh...@chromium.org conradlo@chromium.org waihong@chromium.org

Comment 3 by ka...@chromium.org, Sep 26 2016

Cc: bhthompson@chromium.org
Labels: -ReleaseBlock-Stable ReleaseBlock-Beta

Comment 4 by ka...@chromium.org, Sep 26 2016

Issue 650312 has been merged into this issue.

Comment 5 by ka...@chromium.org, Sep 26 2016

Labels: -Type-Bug Type-Bug-Regression
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 27 2016

Labels: Hotlist-Google
Owner: mojahsu@chromium.org
I think the ctrl+F4 is broken is the root cause of set_mirrored failing.
Just as title said. 
We use LEFTCTRL + F4 or ctrl+F4 for set_mirrored function.
Cc: mojahsu@chromium.org
Owner: osh...@chromium.org
Added oshima@ to triage the issue.
Owner: afakhry@chromium.org
Status: Assigned (was: Untriaged)
afakhry@ can you test if this happen on non Elm?
Labels: triaged
Labels: Arch-All
still reproducible in 8872.5.0 / 55.0.2883.6. 
Reproduced in chell, 8872.6.0 / 55.0.2883.7
Status: Started (was: Assigned)
I can repro.
This is a regression caused by me, actually! :( Fix is up for review.
Components: -OS>Kernel>Display UI>Input>KeyboardShortcuts
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8b394e863e69c0b99338e826a05fae76f22851a

commit d8b394e863e69c0b99338e826a05fae76f22851a
Author: afakhry <afakhry@chromium.org>
Date: Thu Oct 13 22:22:32 2016

Fix regression in handling toggle mirror mode

Toggle mirror mode shouldn't be dependent on the dev-shortcuts flag.

BUG= 650394 
TEST=Ctrl+F4 should toggle mirror mode successfully.

Review-Url: https://codereview.chromium.org/2417773002
Cr-Commit-Position: refs/heads/master@{#425189}

[modify] https://crrev.com/d8b394e863e69c0b99338e826a05fae76f22851a/ash/accelerators/accelerator_controller_delegate_aura.cc

Labels: Merge-Request-55

Comment 19 by dimu@chromium.org, Oct 14 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 20 by bugdroid1@chromium.org, Oct 15 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c87bb9fb0e725ad22520dc27847bfb577be535d

commit 4c87bb9fb0e725ad22520dc27847bfb577be535d
Author: Ahmed Fakhry <afakhry@google.com>
Date: Sat Oct 15 01:42:32 2016

[Merge to M55] Fix regression in handling toggle mirror mode

Toggle mirror mode shouldn't be dependent on the dev-shortcuts flag.

TBR=jamescook@chromium.org
BUG= 650394 
TEST=Ctrl+F4 should toggle mirror mode successfully.

Review-Url: https://codereview.chromium.org/2417773002
Cr-Commit-Position: refs/heads/master@{#425189}
(cherry picked from commit d8b394e863e69c0b99338e826a05fae76f22851a)

Review URL: https://codereview.chromium.org/2423673002 .

Cr-Commit-Position: refs/branch-heads/2883@{#129}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/4c87bb9fb0e725ad22520dc27847bfb577be535d/ash/accelerators/accelerator_controller_delegate_aura.cc

Status: Fixed (was: Started)
Project Member

Comment 22 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c87bb9fb0e725ad22520dc27847bfb577be535d

commit 4c87bb9fb0e725ad22520dc27847bfb577be535d
Author: Ahmed Fakhry <afakhry@google.com>
Date: Sat Oct 15 01:42:32 2016

[Merge to M55] Fix regression in handling toggle mirror mode

Toggle mirror mode shouldn't be dependent on the dev-shortcuts flag.

TBR=jamescook@chromium.org
BUG= 650394 
TEST=Ctrl+F4 should toggle mirror mode successfully.

Review-Url: https://codereview.chromium.org/2417773002
Cr-Commit-Position: refs/heads/master@{#425189}
(cherry picked from commit d8b394e863e69c0b99338e826a05fae76f22851a)

Review URL: https://codereview.chromium.org/2423673002 .

Cr-Commit-Position: refs/branch-heads/2883@{#129}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/4c87bb9fb0e725ad22520dc27847bfb577be535d/ash/accelerators/accelerator_controller_delegate_aura.cc

Comment 23 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Status: Verified (was: Fixed)
Verified in ChromeOs 8872.67.0, 55.0.2883.82

Sign in to add a comment