New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 650376 link

Starred by 3 users
Status: Fixed
Owner:
dtrainor@chromium.org
Closed: Sep 2016
Cc:
█ bshe@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

android component + release build broken due to VR

Project Member Reported by boliu@chromium.org, Sep 26 2016 
Warning: com.google.vr.cardboard.AndroidNCompat: can't find referenced method 'void setVrModeEnabled(boolean,android.content.ComponentName)' in library class android.app.Activity
Warning: com.google.vr.cardboard.AndroidNCompat: can't find referenced method 'boolean isSustainedPerformanceModeSupported()' in library class android.os.PowerManager
Warning: com.google.vr.cardboard.AndroidNCompat: can't find referenced method 'void setSustainedPerformanceMode(boolean)' in library class android.view.Window
Warning: there were 3 unresolved references to library class members.
         You probably need to update the library versions.
         (http://proguard.sourceforge.net/manual/troubleshooting.html#unresolvedlibraryclassmember)
Error: Please correct the above warnings first


Repro by building chrome_public_apk with is_component_build = true, is_debug = false, is_java_debug = false. Apparently no bot does this combination of flags..

Note this has nothing to do with the VrShell that's currently being written. VrShell is still off by default.

Comment 1 by csharrison@chromium.org, Sep 26 2016 

I'm hitting this with the following args.gn:

is_debug = false
target_os = "android"
enable_nacl = false
is_component_build = true

Comment 2 by boliu@chromium.org, Sep 26 2016 

short term workaround is "is_java_debug = true"

Comment 3 by csharrison@chromium.org, Sep 26 2016 

Thanks :)

Comment 4 by bshe@chromium.org, Sep 29 2016

Owner: dtrainor@chromium.org
Status: Fixed (was: Untriaged)
https://codereview.chromium.org/2377763003/

Comment 5 by boliu@chromium.org, Sep 29 2016

Cc: bshe@chromium.org
bshe: why is vrshell stuff affecting the build if enable_vr_shell is false?

Comment 6 by bshe@chromium.org, Sep 29 2016 

I think it is because webvr also use gvr library(https://cs.chromium.org/chromium/src/device/vr/BUILD.gn?rcl=0&l=97). And gvr_common internally depends on gvr_base, which results the proguard issue. The reason it doesn't trigger the same issue for previous version is because gvr library was using reflection to check if these functions exist or not.

I have verified locally that once we have N sdk available in chromium, we can then safely reland gvr 1.0 to chromium.

Comment 7 by ddorwin@chromium.org, Nov 30 2016

Labels: Proj-VR
►

Sign in to add a comment