Provide function equivalent API for UMA macros in histogram_macros.h |
||
Issue descriptionhistogram_macros.h provide macros for addition histogram. They are very efficient, but doesn't cover all use cases, like If histogram name is generated at runtime, special care has to be taken when using macro so that generated code behaves as expected. It is not possible in some cases. Provide a equivalent API for using UMA macros have similar functionality exposed as functions.
,
Nov 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09d945012fa2c299ace0b044277d67901d6158a5 commit 09d945012fa2c299ace0b044277d67901d6158a5 Author: nikunjb <nikunjb@chromium.org> Date: Mon Nov 14 22:06:25 2016 Expose macros from base/metrics/histogram_macros.h as functions BUG= 650375 Review-Url: https://codereview.chromium.org/2393493002 Cr-Commit-Position: refs/heads/master@{#431917} [modify] https://crrev.com/09d945012fa2c299ace0b044277d67901d6158a5/base/BUILD.gn [add] https://crrev.com/09d945012fa2c299ace0b044277d67901d6158a5/base/metrics/histogram_functions.cc [add] https://crrev.com/09d945012fa2c299ace0b044277d67901d6158a5/base/metrics/histogram_functions.h [add] https://crrev.com/09d945012fa2c299ace0b044277d67901d6158a5/base/metrics/histogram_functions_unittest.cc [modify] https://crrev.com/09d945012fa2c299ace0b044277d67901d6158a5/base/metrics/histogram_macros.h [modify] https://crrev.com/09d945012fa2c299ace0b044277d67901d6158a5/base/test/histogram_tester.cc [modify] https://crrev.com/09d945012fa2c299ace0b044277d67901d6158a5/base/test/histogram_tester.h
,
Nov 21 2016
Please use functions defined in base/metrics/histogram_functions.h instead of using base::Histogram::FactoryGet directly. |
||
►
Sign in to add a comment |
||
Comment 1 by nikunjb@chromium.org
, Sep 26 2016