New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 650347 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature
cwp



Sign in to add a comment

Runtime memory leak detector: record system memory info in leak report

Project Member Reported by sque@chromium.org, Sep 26 2016

Issue description

When a leak report is generated, also record info about system memory (total, free, etc).


 

Comment 1 by sque@chromium.org, Sep 26 2016

Status: Started (was: Untriaged)
We can get total and free memory for the entire system using base::SysInfo.

metrics_memory_details.cc contains a way to get the private memory used by each Chrome process.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cfe9539a19cb6cdea82c91f78f9341418fa2d13

commit 1cfe9539a19cb6cdea82c91f78f9341418fa2d13
Author: mwlodar <mwlodar@google.com>
Date: Tue Oct 04 22:19:53 2016

Additional fields added to Memory Leak Detector proto

Memory Leak Detector proto gets enriched with a message
for collecting memory usage information from OS
and fields describing the last increasing allocation trend for
the suspected size and call stack.

BUG= chromium:650347 

Review-Url: https://codereview.chromium.org/2391893002
Cr-Commit-Position: refs/heads/master@{#422963}

[modify] https://crrev.com/1cfe9539a19cb6cdea82c91f78f9341418fa2d13/components/metrics/proto/memory_leak_report.proto

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee4005181ef90e80428b3569fd5a364f50f334e6

commit ee4005181ef90e80428b3569fd5a364f50f334e6
Author: mwlodar <mwlodar@google.com>
Date: Fri Oct 14 00:11:52 2016

Leak reports collect information about the memory usage

LeakDetectorController calls the MetricsMemoryDetails
to collect information about the memory usage and writes
it in the received leak reports.

BUG= 650347 
TEST=1. Modify kDefaultProbability and kDefaultNumProcessesEnabled in leak_detector_controller.cc to always launch the detector.
2. Add a dummy report in leak_detector.cc before detector->NotifyObservers()
3. Add debug info with LOG(ERROR) in leak_detector_controller.cc:OnMemoryDetailCollectionDone()
4. Launch Chromium with flag enable-features=RuntimeMemoryLeakDetector

Review-Url: https://codereview.chromium.org/2396743002
Cr-Commit-Position: refs/heads/master@{#425212}

[modify] https://crrev.com/ee4005181ef90e80428b3569fd5a364f50f334e6/chrome/browser/metrics/leak_detector/leak_detector_controller.cc
[modify] https://crrev.com/ee4005181ef90e80428b3569fd5a364f50f334e6/chrome/browser/metrics/leak_detector/leak_detector_controller.h
[modify] https://crrev.com/ee4005181ef90e80428b3569fd5a364f50f334e6/chrome/browser/metrics/leak_detector/leak_detector_controller_unittest.cc
[modify] https://crrev.com/ee4005181ef90e80428b3569fd5a364f50f334e6/chrome/browser/metrics/metrics_memory_details.cc
[modify] https://crrev.com/ee4005181ef90e80428b3569fd5a364f50f334e6/chrome/browser/metrics/metrics_memory_details.h

Comment 4 by sque@chromium.org, May 20 2017

Status: Fixed (was: Started)

Comment 5 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment