Issue metadata
Sign in to add a comment
|
DedicatedWorkerTest.* is slow |
||||||||||||||||||||||
Issue descriptionwas running webkit_unit_tests locally recently. [4014/4053] DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent (1341 ms) [4030/4053] DedicatedWorkerTest.PendingActivity_NoActivity (151 ms) [4031/4053] DedicatedWorkerTest.PendingActivity_SetTimeout (149 ms) [4032/4053] DedicatedWorkerTest.PendingActivity_SetInterval (113 ms) [4033/4053] DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent (1127 ms) Almost all of these > 4000 tests take a millisecond to run (exception: bug 650340 ). DedicatedWorkerTest tests combined take about 2s, which would be 20% of the runtime of webkit_unit_tests if it weren't for bug 650340 . Please make these tests instant instead. If that's tricky to do, disable them until they're fast.
,
Sep 30 2016
postDelayedTask() makes them so slow. I think we can shorten the delay.
,
Sep 30 2016
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4fc0c9e997c07fafa8089520db5286b4f0f22817 commit 4fc0c9e997c07fafa8089520db5286b4f0f22817 Author: nhiroki <nhiroki@chromium.org> Date: Fri Oct 07 02:55:21 2016 Worker: Shorten running time of DedicatedWorkerTests DedicatedWorkerTests are very slow compared to other tests. According to the report ( https://crbug.com/650346 ), these take 20% of the running time of webkit_unit_tests. This CL saves the running time by shortening delays for postDelayedTask(), setInterval() etc used in the tests. Before this CL (Linux Debug Build): [1/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (197 ms) [2/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (194 ms) [3/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (195 ms) [4/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (1202 ms) [5/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (1409 ms) [6/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (155 ms) [7/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (169 ms) [8/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (160 ms) [9/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (1187 ms) [10/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (1374 ms) After this CL (Linux Debug Build): [1/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (116 ms) [2/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (105 ms) [3/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (109 ms) [4/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (120 ms) [5/10] MainThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (139 ms) [6/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_NoActivity/0 (68 ms) [7/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeout/0 (74 ms) [8/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetInterval/0 (77 ms) [9/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetTimeoutOnMessageEvent/0 (94 ms) [10/10] PerThreadHeap/DedicatedWorkerTest.PendingActivity_SetIntervalOnMessageEvent/0 (104 ms) BUG= 650346 Review-Url: https://codereview.chromium.org/2384723002 Cr-Commit-Position: refs/heads/master@{#423789} [modify] https://crrev.com/4fc0c9e997c07fafa8089520db5286b4f0f22817/third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp [modify] https://crrev.com/4fc0c9e997c07fafa8089520db5286b4f0f22817/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp [modify] https://crrev.com/4fc0c9e997c07fafa8089520db5286b4f0f22817/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h
,
Oct 7 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kojii@chromium.org
, Sep 26 2016