New issue
Advanced search Search tips

Issue 650345 link

Starred by 1 user
Status: Fixed
Owner:
sdefresne@chromium.org
Closed: Jun 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature

Blocking:
issue 649854



Sign in to add a comment

Remove dependence on gen_plist.py ignoring unbound substitutions

Project Member Reported by sdy@chromium.org, Sep 26 2016 
The iOS build relies on gen_plist.py skipping keys which use unbound variables.  Bug 649854  will change the default to fail the build for unbound variables, but the current behavior will still be supported with `--skip-unbound-variables`.

It would be nice to remove this flag, so that legitimately forgetting to bind a substitution makes loud noises.

Based on sdefresne@'s description, one way forward might be to split sets of uncommon keys out into separate template plists and then conditionally include them.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b334ab19b61db7d9df851a5a765df62e90341b38

commit b334ab19b61db7d9df851a5a765df62e90341b38
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Jun 01 16:13:00 2017

[ios] Pass missing variable substitution values.

https://codereview.chromium.org/2367923002/ tries to change
build/config/mac/plist_util.py to fails if some variables
have no value while performing substitution.

Fix invocations of plist_util.py when building Chrome on iOS
to allow the change to plist_util.py.

BUG= 650345 

Change-Id: Ibbd38373d851bb418e0328f5113342cdbc3604e9
Reviewed-on: https://chromium-review.googlesource.com/521106
Reviewed-by: Louis Romero <lpromero@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476315}
[modify] https://crrev.com/b334ab19b61db7d9df851a5a765df62e90341b38/ios/clean/chrome/app/BUILD.gn

Comment 2 by sdefresne@chromium.org, Jun 1 2017

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/faba7ddfc2b78b1741e578817d7cbbaed0030a93

commit faba7ddfc2b78b1741e578817d7cbbaed0030a93
Author: sdy <sdy@chromium.org>
Date: Wed Jul 05 21:04:22 2017

Fail to build with unbound Info.plist substitutions instead of silently dropping them.

- In plist_util.py, fail if any plist substitutions aren't bound to values.

- Remove a few keys in BuildInfo.plist which had no substitutions. They're
  added later by tweak_info_plist.py.

BUG= 649854 , 650345 

Review-Url: https://codereview.chromium.org/2367923002
Cr-Commit-Position: refs/heads/master@{#484348}

[modify] https://crrev.com/faba7ddfc2b78b1741e578817d7cbbaed0030a93/build/config/mac/BuildInfo.plist
[modify] https://crrev.com/faba7ddfc2b78b1741e578817d7cbbaed0030a93/build/config/mac/plist_util.py
[modify] https://crrev.com/faba7ddfc2b78b1741e578817d7cbbaed0030a93/ui/base/BUILD.gn
[modify] https://crrev.com/faba7ddfc2b78b1741e578817d7cbbaed0030a93/ui/base/test/framework-Info.plist
►

Sign in to add a comment