New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 650340 link

Starred by 1 user
Status: Fixed
Owner:
█ alexclarke@chromium.org
Last visit > 30 days ago
Closed: Sep 2016
Cc:
skyos...@chromium.org
altimin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

VirtualTimeTest are way way way too slow

Project Member Reported by thakis@chromium.org, Sep 26 2016 
I recently ran webkit_unit_tests locally:

[4049/4053] VirtualTimeTest.SetInterval (8518 ms)
[4050/4053] VirtualTimeTest.AllowVirtualTimeToAdvance (8516 ms)
[4051/4053] VirtualTimeTest.VirtualTimeNotAllowedToAdvanceWhileResourcesLoading (8507 ms)

Running all tests takes 35s. These 3 tests together take 25.5s, that's almost 75% of the runtime of webkit_unit_tests. Please make these tests instant instead. If that's tricky to do, disable them until they're fast.

Comment 1 by dtapu...@chromium.org, Sep 26 2016

Components: -Blink Blink>Scheduling

Comment 2 by alexclarke@chromium.org, Sep 29 2016

Status: Started (was: Assigned)
This turns out to be due to SimTest's destructor calling runPendingTasks().  

Normally that's fine but virtual time causes CallDelayedOnForegroundThread posted by gin/v8_platform.cc to run repeatedly back to back so the run loop never goes idle.

I think I can fix this by pausing virtual time in the test tear down.

Comment 3 by alexclarke@chromium.org, Sep 29 2016

Status: Fixed (was: Started)

Comment 4 by alexclarke@chromium.org, Sep 29 2016 

Not sure what happened to the commit email but this was fixed by: https://codereview.chromium.org/2377243003/
►

Sign in to add a comment