Issue metadata
Sign in to add a comment
|
Security interstitial icons are not updated on iOS |
||||||||||||||||||||||||
Issue descriptionApp Version: 54.0.2840.39 beta iOS Version: 10.0.1, 10.1 beta Device: iPad Air2, iPhone6s URL: https://expired.badssl.com Steps to reproduce: 1. Launch Google Chrome 2. Goto https://expired.badssl.com Observed results: Observe that red security icon is not matching with the one in omnibox Expected results: Red triangle icon should be displayed Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): M53 New update Bug reproducible on the current beta channel build (App Version, iOS Version): M54 YES Link to video/image: https://docs.google.com/drawings/d/13nVs5e5jtb89h2jIq3xzV4dtpgd4oAB5lTppVQpD6VQ/preview
,
Sep 26 2016
Will this be fixed in M55? I can reproduce on M55.0.2872.0 canary too.
,
Sep 26 2016
I'm aiming for M55, but there are a lot higher-priority items. Assuming you're only concerned about color, this is Issue 637814.
,
Sep 26 2016
If there is no other tracking bug then its worth keep this bug open. Issue 637814 is related to the color in page info popup. This issue is specific to iOS10 only, where the triangular icon is not updated. The same is working fine in iOS9.
,
Sep 26 2016
Oooh, this is about interstitials, sorry. I assumed it was about page info because you assigned it to me. That's Issue 629140 , which appears not to have affected iOS [10] properly. I can confirm that 55.0.2870.0 also doesn't have the updated icon on an iPad on iOS 10.0.1 edwardjung@, could you look into this?
,
Sep 27 2016
Not looked at this code in a while, but it's all shared so a little confused why the iOS version isn't working. At first glance it seems like the iconUpdate boolean isn't being set properly so the old class is being used. I can't test the malware page to see if it's using the old icon too. I'll need to get my iOS environment setup to confirm.
,
Oct 6 2016
Ah just saw this. Sounds like a bug in the code I added recently. edwardjung@, did you end up debugging this? If not, I can pick up the bug.
,
Oct 6 2016
Thanks, that would be great if could take this one felt.
,
Oct 19 2016
felt@ is leaving soon, and won't have time. edwardjung@: I have a working iOS checkout. How quick would this be to fix?
,
Oct 19 2016
(Note: by "leaving soon", I mean "going on leave after Friday".)
,
Oct 19 2016
,
Oct 20 2016
I actually couldn't find out where the problem lies. Felt@ indicated that it was a a change she'd made recently but I had a look at some recent CLs and couldn't see anything relevant. As far as I can tell it's something to do with this: base::FeatureList::IsEnabled(kSecurityWarningIconUpdate) is set to false for iOS 10. Is this WAI due to being under an experiment - https://critique.corp.google.com/#review/132567250
,
Oct 20 2016
This issue is reproducing on iOS 9.3.5 also. I have tried with the latest Chrome M56.0.2896.0 Canary and Beta channels.
,
Nov 24 2016
,
Nov 10 2017
,
Feb 18 2018
,
Aug 7
It's not the case anymore :) Both the interstitial and the omnibox have a triangle now. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by lgar...@chromium.org
, Sep 26 2016