Remove MessageLoop destruction observers |
|||
Issue descriptionTaskScheduler doesn't support destruction observers. Removing MessageLoop destruction observers will facilitate the migration of BrowserThreads to TaskScheduler.
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4430f9e5f415d06994bc12ba3fe2a8a46ac80482 commit 4430f9e5f415d06994bc12ba3fe2a8a46ac80482 Author: fdoray <fdoray@chromium.org> Date: Wed Sep 28 18:30:27 2016 Remove FilePathWatcher::PlatformDelegate::CancelOnMessageLoopThread(). There is no reason to have this method in the PlatformDelegate interface it can simply be declared in subclasses that need it. BUG= 650318 Review-Url: https://codereview.chromium.org/2372513005 Cr-Commit-Position: refs/heads/master@{#421583} [modify] https://crrev.com/4430f9e5f415d06994bc12ba3fe2a8a46ac80482/base/files/file_path_watcher.cc [modify] https://crrev.com/4430f9e5f415d06994bc12ba3fe2a8a46ac80482/base/files/file_path_watcher.h [modify] https://crrev.com/4430f9e5f415d06994bc12ba3fe2a8a46ac80482/base/files/file_path_watcher_fsevents.h [modify] https://crrev.com/4430f9e5f415d06994bc12ba3fe2a8a46ac80482/base/files/file_path_watcher_kqueue.h [modify] https://crrev.com/4430f9e5f415d06994bc12ba3fe2a8a46ac80482/base/files/file_path_watcher_linux.cc [modify] https://crrev.com/4430f9e5f415d06994bc12ba3fe2a8a46ac80482/base/files/file_path_watcher_mac.cc [modify] https://crrev.com/4430f9e5f415d06994bc12ba3fe2a8a46ac80482/base/files/file_path_watcher_stub.cc [modify] https://crrev.com/4430f9e5f415d06994bc12ba3fe2a8a46ac80482/base/files/file_path_watcher_win.cc
,
Oct 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc6bd5c938f5d4dfa33ed1bbe962a2effc12d597 commit cc6bd5c938f5d4dfa33ed1bbe962a2effc12d597 Author: fdoray <fdoray@chromium.org> Date: Tue Oct 04 18:03:17 2016 Make WaitableEventWatcher TaskScheduler-friendly. With this CL, WaitableEventWatcher uses SequencedTaskRunnerHandle instead of MessageLoop::current() to post back to the sequence that called StartWatching(). Also, WaitableEventWatcher no longer registers itself as a destruction observer of the MessageLoop from which StartWatching() is called. If the watched WaitableEvent is signaled after the MessageLoop is destroyed, the task posted by WaitableEventWatcher to the SequencedTaskRunner will simply not run (no crash). MessageLoop::current() and destruction observer do not work with TaskScheduler. BUG= 650318 Review-Url: https://codereview.chromium.org/2368423002 Cr-Commit-Position: refs/heads/master@{#422856} [modify] https://crrev.com/cc6bd5c938f5d4dfa33ed1bbe962a2effc12d597/base/synchronization/waitable_event_watcher.h [modify] https://crrev.com/cc6bd5c938f5d4dfa33ed1bbe962a2effc12d597/base/synchronization/waitable_event_watcher_posix.cc [modify] https://crrev.com/cc6bd5c938f5d4dfa33ed1bbe962a2effc12d597/base/synchronization/waitable_event_watcher_unittest.cc [modify] https://crrev.com/cc6bd5c938f5d4dfa33ed1bbe962a2effc12d597/base/synchronization/waitable_event_watcher_win.cc
,
Oct 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a9ea7caa267b3779d7984a6834e2d35b723cefb commit 7a9ea7caa267b3779d7984a6834e2d35b723cefb Author: fdoray <fdoray@chromium.org> Date: Thu Oct 20 17:22:27 2016 Leak DeviceMonitorLinux on shutdown. In preparation for the migration of many Chrome threads to TaskScheduler, we want to get rid of MessageLoop destruction observers. This CL removes the code that deletes DeviceMonitorLinux from a destruction observer and uses a LazyInstance::Leaky to manage the lifetime of DeviceMonitorLinux. This CL also helps reducing the amount of work done during shutdown https://groups.google.com/a/chromium.org/d/msg/chromium-dev/AMB2Y7Sqj48/QltA07wUCQAJ BUG= 650318 Review-Url: https://chromiumcodereview.appspot.com/2433933004 Cr-Commit-Position: refs/heads/master@{#426518} [modify] https://crrev.com/7a9ea7caa267b3779d7984a6834e2d35b723cefb/device/base/device_monitor_linux.cc
,
Nov 7 2016
,
Nov 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e1feb846042722a8df671de070a32374221e499 commit 1e1feb846042722a8df671de070a32374221e499 Author: fdoray <fdoray@chromium.org> Date: Wed Nov 23 12:29:59 2016 Remove destruction observer from file_path_watcher_win.cc Now that the FilePathWatcher::~FilePathWatcher() is called on the same sequence as FilePathWatcher::Watch() (see https://codereview.chromium.org/2438913003/), the work done in FilePathWatcherImpl::WillDestroyCurrentMessageLoop() can safely be moved to FilePathWatcherImpl::Cancel(). BUG= 650318 Review-Url: https://codereview.chromium.org/2523573002 Cr-Commit-Position: refs/heads/master@{#434150} [modify] https://crrev.com/1e1feb846042722a8df671de070a32374221e499/base/files/file_path_watcher_win.cc
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52e11d48575954e29aa9407c4343d76f0475327a commit 52e11d48575954e29aa9407c4343d76f0475327a Author: fdoray <fdoray@chromium.org> Date: Tue Nov 29 22:19:58 2016 Remove destruction observer from base::FilePathWatcherKQueue. Now that FilePathWatcher::~FilePathWatcher() is called on the same sequence as FilePathWatcher::Watch() (see https://codereview.chromium.org/2438913003/), the work done in FilePathWatcherKQueue::WillDestroyCurrentMessageLoop() can safely be moved to FilePathWatcherKQueue::Cancel(). BUG= 650318 Review-Url: https://codereview.chromium.org/2517323002 Cr-Commit-Position: refs/heads/master@{#435092} [modify] https://crrev.com/52e11d48575954e29aa9407c4343d76f0475327a/base/files/file_path_watcher.h [modify] https://crrev.com/52e11d48575954e29aa9407c4343d76f0475327a/base/files/file_path_watcher_kqueue.cc [modify] https://crrev.com/52e11d48575954e29aa9407c4343d76f0475327a/base/files/file_path_watcher_kqueue.h
,
Dec 5 2016
Removed all destruction observers from all browser threads that will be migrated to TaskScheduler. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Sep 27 2016