New issue
Advanced search Search tips

Issue 650317 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

dromaeo.jslibattrprototype failing on chromium.perf

Project Member Reported by pras...@chromium.org, Sep 26 2016

Issue description

This is also failing on 
Android Galaxy S5 Perf (1)
Android Nexus9 Perf (1)
Android One Perf (1)
Android Nexus6 WebView Perf (2)
Win 10 Perf (4)
Win 8 Perf (4)
Win 7 x64 Perf (4)
Win 7 Perf (4)
Win 7 ATI GPU Perf (4)
Mac 10.11 Perf (4)
Mac 10.10 Perf (4)
Mac HDD Perf (4)
Linux Perf (4)

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49f0731636ffc0b6a59e63e923dd74648ff23608

commit 49f0731636ffc0b6a59e63e923dd74648ff23608
Author: prasadv <prasadv@chromium.org>
Date: Mon Sep 26 23:34:41 2016

Disable dromaeo.jslibattrprototype on platforms.

BUG= 650317 
TBR=nednguyen,yukishiino

Review-Url: https://codereview.chromium.org/2371873003
Cr-Commit-Position: refs/heads/master@{#421038}

[modify] https://crrev.com/49f0731636ffc0b6a59e63e923dd74648ff23608/tools/perf/benchmarks/dromaeo.py

Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Sep 27 2016


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [stubs] Port SubStringStub to TurboFan
Author  : jgruber
Commit description:
  
This ports the platform-specific SubStringStub to TurboFan.

It also contains a minor bug-fix for the case when the requested substring
length equals the subject string length, but the start index is not equal to 0.
The old stub implementation returned the subject string, while the new
implementation calls into runtime, which finally results in a thrown exception.

BUG= v8:5415 

Review-Url: https://codereview.chromium.org/2355793003
Cr-Commit-Position: refs/heads/master@{#39653}
Commit  : 49be31921536716706a6790fbbf9c346b975af16
Date    : Fri Sep 23 06:50:31 2016


===== TESTED REVISIONS =====
Revision                       Exit Code  Std Dev  N  Good?
chromium@420694                0          N/A      1  good
chromium@420694,v8@3bbd11c233  0          N/A      1  good
chromium@420694,v8@b88a848faf  0          N/A      1  good
chromium@420694,v8@a717fb7c01  0          N/A      1  good
chromium@420694,v8@49be319215  1          N/A      1  bad    <--
chromium@420695                1          N/A      1  bad
chromium@420696                1          N/A      1  bad
chromium@420698                1          N/A      1  bad
chromium@420702                1          N/A      1  bad
chromium@420710                1          N/A      1  bad
chromium@420726                1          N/A      1  bad
chromium@420757                1          N/A      1  bad

Bisect job ran on: linux_perf_bisect
Bug ID: 650317

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests dromaeo.jslibattrprototype
Test Metric: jslib/jslib
Relative Change: Zero to non-zero
Score: 0.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6728
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9000437426328027744


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5785313308311552

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Owner: jgruber@chromium.org
Status: Available (was: Untriaged)
jgruber@, could you take a look?
The test is currently disabled by https://crrev.com/2371873003 .

Mergedinto: 649967
Status: Duplicate (was: Available)
49be31921536716706a6790fbbf9c346b975af16 was reverted on Monday since it was crashing canary. Sorry bout that, things should be fine now.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ec236b384dab4fd7c56308e850c2a1cb21a9a92

commit 3ec236b384dab4fd7c56308e850c2a1cb21a9a92
Author: yukishiino <yukishiino@chromium.org>
Date: Wed Sep 28 13:20:59 2016

binding: Re-enables dromaeo.jslibattrprototype.

https://bugs.chromium.org/p/chromium/issues/detail?id=650317#c6
The CL caused an issue was reverted.  Thus, enables the benchmark again.

BUG= 650317 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2378663002
Cr-Commit-Position: refs/heads/master@{#421507}

[modify] https://crrev.com/3ec236b384dab4fd7c56308e850c2a1cb21a9a92/tools/perf/benchmarks/dromaeo.py

Sign in to add a comment