New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 650306 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

battor.power_cases_no_chrome_trace failing

Project Member Reported by rnep...@chromium.org, Sep 26 2016

Issue description

MapFunctionError: Cannot read property 'rendererHelpers' of undefined
    at findTargetRendererHelper (/tracing/metrics/system_health/loading_metric.html:36:33)
    at timeToFirstContentfulPaintMetric (/tracing/metrics/system_health/loading_metric.html:230:26)
    at Object.loadingMetric (/tracing/metrics/system_health/loading_metric.html:425:5)
    at getNavigationTTIIntervals_ (/tracing/metrics/system_health/power_metric.html:55:19)
    at computeLoadingMetric_ (/tracing/metrics/system_health/power_metric.html:237:21)
    at new powerMetric (/tracing/metrics/system_health/power_metric.html:272:5)
    at runMetrics (/b/c/b/Mac_Retina_Perf__4_/src/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:37:14)
    at metricMapFunction (/b/c/b/Mac_Retina_Perf__4_/src/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:71:18)
    at Object.mapSingleTrace (/tracing/mre/map_single_trace.html:41:7)
    at eval (/b/c/b/Mac_Retina_Perf__4_/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:61:18)
[  FAILED  ] /tmp/tmpZmQ4rP.html (1302 ms)
Traceback (most recent call last):
  File "/b/c/b/Mac_Retina_Perf__4_/src/third_party/catapult/telemetry/telemetry/value/failure.py", line 41, in _GetExcInfoFromMessage
    raise Exception(message)
Exception: MapFunctionError: Cannot read property 'rendererHelpers' of undefined
    at findTargetRendererHelper (/tracing/metrics/system_health/loading_metric.html:36:33)
    at timeToFirstContentfulPaintMetric (/tracing/metrics/system_health/loading_metric.html:230:26)
    at Object.loadingMetric (/tracing/metrics/system_health/loading_metric.html:425:5)
    at getNavigationTTIIntervals_ (/tracing/metrics/system_health/power_metric.html:55:19)
    at computeLoadingMetric_ (/tracing/metrics/system_health/power_metric.html:237:21)
    at new powerMetric (/tracing/metrics/system_health/power_metric.html:272:5)
    at runMetrics (/b/c/b/Mac_Retina_Perf__4_/src/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:37:14)
    at metricMapFunction (/b/c/b/Mac_Retina_Perf__4_/src/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:71:18)
    at Object.mapSingleTrace (/tracing/mre/map_single_trace.html:41:7)
    at eval (/b/c/b/Mac_Retina_Perf__4_/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:61:18)

 
Cc: rnep...@chromium.org
Labels: Performance-Sheriff-BotHealth
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Sep 26 2016

Cc: catapult-deps-roller@chromium.org
Owner: catapult-deps-roller@chromium.org

=== Auto-CCing suspected CL author catapult-deps-roller@chromium.org ===

Hi catapult-deps-roller@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Roll src/third_party/catapult/ 7d41d5873..cc78bd596 (4 commits).
Author  : catapult-deps-roller
Commit description:
  
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7d41d5873cc4..cc78bd596aa7

$ git log 7d41d5873..cc78bd596 --date=short --no-merges --format='%ad %ae %s'
2016-09-20 benjhayden Add tr.v.d.Scalar
2016-09-20 nednguyen Add script for slimming trace file
2016-09-20 alexandermont Put all power metrics in one file.
2016-09-20 charliea Fix more camelcase violations in tracing/

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2357493003
Cr-Commit-Position: refs/heads/master@{#419862}
Commit  : 07d2aabf774a5580cd7d482bdadcc23956626d24
Date    : Tue Sep 20 21:57:28 2016


===== TESTED REVISIONS =====
Revision                             Exit Code  Std Dev  N  Good?
chromium@419839                      0          N/A      3  good
chromium@419853                      0          N/A      3  good
chromium@419860                      0          N/A      3  good
chromium@419861                      0          N/A      3  good
chromium@419861,catapult@5ede852f73  0          N/A      3  good
chromium@419861,catapult@cc78bd596a  0          N/A      3  good
chromium@419862                      1          N/A      3  bad    <--
chromium@419864                      1          N/A      3  bad
chromium@419867                      1          N/A      3  bad
chromium@419894                      1          N/A      3  bad

Bisect job ran on: mac_retina_perf_bisect
Bug ID: 650306

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests battor.power_cases_no_chrome_trace
Test Metric: energy_consumed_per_frame_avg/energy_consumed_per_frame_avg
Relative Change: Zero to non-zero
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1690
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9000439194136719664


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5876152940363776

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Cc: -catapult-deps-roller@chromium.org alexandermont@chromium.org
Owner: rnep...@chromium.org
Alex, could this be caused by your CL to put all power metrics into one file? Or related to the thing you were asking about traces for this morning?
Cc: -alexandermont@chromium.org
Owner: alexandermont@chromium.org
Alex, are you looking at this bug? Should we disable the test until you can fix?
I am looking at this bug. CL is here:

https://codereview.chromium.org/2371873002
Cc: alexandermont@chromium.org
 Issue 651384  has been merged into this issue.
On a run where your fix for this landed (2016-09-29 alexandermont Fail gracefully if no Chrome trace or insufficient power samples.) similar errors on other battor runs started. 

https://build.chromium.org/p/chromium.perf/builders/Mac%20Retina%20Perf%20%284%29/builds/6264

MapFunctionError: Cannot read property 'bounds' of undefined
    at getChromeBounds (/tracing/metrics/system_health/power_metric.html:276:72)
    at new powerMetric (/tracing/metrics/system_health/power_metric.html:302:24)
    at runMetrics (/b/c/b/Mac_Retina_Perf__4_/src/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:37:14)
    at metricMapFunction (/b/c/b/Mac_Retina_Perf__4_/src/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:71:18)
    at Object.mapSingleTrace (/tracing/mre/map_single_trace.html:41:7)
    at eval (/b/c/b/Mac_Retina_Perf__4_/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:61:18)
    at Object.runAndConvertErrorsToFailures (/tracing/mre/map_single_trace.html:26:10)
    at mapSingleTraceWithResult (/b/c/b/Mac_Retina_Perf__4_/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:52:12)
    at Object.mapSingleTraceMain (/b/c/b/Mac_Retina_Perf__4_/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:76:18)
    at eval (/b/c/b/Mac_Retina_Perf__4_/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:89:15)
Labels: -Pri-1 Pri-2
Bot is green. Downgrade to pri-2.

Is this fixed?
I think the bot is only green because I disabled the test: https://codereview.chromium.org/2382473003
Yeah, it doesn't look like alex landed a fix for it. He is working on it here:
https://codereview.chromium.org/2380183004/
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99c13774e9938a23c9551e86dd1648c7aebca3f9

commit 99c13774e9938a23c9551e86dd1648c7aebca3f9
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Tue Oct 11 20:23:00 2016

Roll src/third_party/catapult/ 169ae6251..e87e17fbf (1 commit).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/169ae625183e..e87e17fbfb63

$ git log 169ae6251..e87e17fbf --date=short --no-merges --format='%ad %ae %s'
2016-10-11 alexandermont Fail gracefully if no Chrome trace or insufficient power samples (reland)

BUG= 650306 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2410723003
Cr-Commit-Position: refs/heads/master@{#424528}

[modify] https://crrev.com/99c13774e9938a23c9551e86dd1648c7aebca3f9/DEPS

Status: WontFix (was: Untriaged)
Becnhmark no longer exists.

Sign in to add a comment