Optin IME Crash in ash::TrayDetailsView::OnViewClicked |
||||||||||
Issue descriptionChrome Version: 55.0.2866.0/8829.0 - peppy /samus Please specify Cr-* of the system to which this bug/feature applies (add the label below). Steps To Reproduce: (1)In settings enable input options in the shelf (2)Click on the US keyboard (3) Expected Result: No crash Actual Result: Crash How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always What is the impact to the user, and is there a workaround? If so, what is it? Please provide any additional information below. Attach a screen shot or log if possible. Report ID72548a2d00000000 0x00007fdb97e599d7 (chrome -tray_details_view.cc:76 ) ash::TrayDetailsView::OnViewClicked 0x00007fdb97dd27aa (chrome -hover_highlight_view.cc:210 ) ash::HoverHighlightView::PerformAction 0x00007fdb97dd1de7 (chrome -actionable_view.cc:52 ) ash::ActionableView::OnMouseReleased 0x00007fdb96e09176 (chrome -event_dispatcher.cc:191 ) ui::EventDispatcher::DispatchEvent 0x00007fdb96e09560 (chrome -event_dispatcher.cc:139 ) ui::EventDispatcher::ProcessEvent 0x00007fdb96e09646 (chrome -event_dispatcher.cc:86 ) ui::EventDispatcherDelegate::DispatchEventToTarget 0x00007fdb96e0973f (chrome -event_dispatcher.cc:58 ) ui::EventDispatcherDelegate::DispatchEvent 0x00007fdb9771092b (chrome -root_view.cc:447 ) views::internal::RootView::OnMouseReleased 0x00007fdb976eaf38 (chrome -widget.cc:1212 ) views::Widget::OnMouseEvent 0x00007fdb96e09176 (chrome -event_dispatcher.cc:191 ) ui::EventDispatcher::DispatchEvent 0x00007fdb96e09560 (chrome -event_dispatcher.cc:139 ) ui::EventDispatcher::ProcessEvent
,
Sep 27 2016
The crash should has already been fixed in Chrome Version: 55.0.2869.0/8835.0.
,
Sep 27 2016
This crash is still reproducible Test version :55.0.2869.0/8838.0.0 Crash Id - 3a06c32d00000000
,
Sep 29 2016
Sorry, this is only fixed when --ash-md=Experimental. I'll fix this ASAP.
,
Oct 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d13360c1060219cd5a2d8085fab433a8f49d414a commit d13360c1060219cd5a2d8085fab433a8f49d414a Author: azurewei <azurewei@chromium.org> Date: Sat Oct 08 02:44:38 2016 Fix opt-in IME menu crash. The crash is caused by the unsafely accessing of |title_row_| in TrayDetailsView, which is null for opt-in IME menu. Fix the crash by adding the check of |title_row_|. BUG= 650287 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2390753006 Cr-Commit-Position: refs/heads/master@{#424049} [modify] https://crrev.com/d13360c1060219cd5a2d8085fab433a8f49d414a/ash/common/system/tray/tray_details_view.cc
,
Oct 14 2016
,
Oct 18 2016
Need to Merge to M55 .Still crashes on build 55.0.2883.17/8872.15.0 Crash ID - 106f1a3b00000000
,
Oct 18 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 20 2016
Just a heads up that this bug is marked as ReleaseBlock-Beta for R55, and we are looking to promote R55 to beta with the build on Monday evening. Optimally we need Chrome side CLs in place by Sunday afternoon, if we can merge this in the next day or so we should be good.
,
Oct 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad916b7a758ede24c26836aa84315efb94bccbcd commit ad916b7a758ede24c26836aa84315efb94bccbcd Author: azurewei <azurewei@chromium.org> Date: Fri Oct 21 00:45:10 2016 Fix opt-in IME menu crash. The crash is caused by the unsafely accessing of |title_row_| in TrayDetailsView, which is null for opt-in IME menu. Fix the crash by adding the check of |title_row_|. TBR=tdanderson@chromium.org NOPRESUBMIT=true NOTRY=true BUG= 650287 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2390753006 Cr-Commit-Position: refs/heads/master@{#424049} (cherry picked from commit d13360c1060219cd5a2d8085fab433a8f49d414a) Review-Url: https://chromiumcodereview.appspot.com/2443443002 Cr-Commit-Position: refs/branch-heads/2883@{#226} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/ad916b7a758ede24c26836aa84315efb94bccbcd/ash/common/system/tray/tray_details_view.cc
,
Oct 24 2016
Looks like we are merged, should we assume this one is fixed?
,
Oct 24 2016
This is fixed in 55.0.2883.25/8872.22.0
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad916b7a758ede24c26836aa84315efb94bccbcd commit ad916b7a758ede24c26836aa84315efb94bccbcd Author: azurewei <azurewei@chromium.org> Date: Fri Oct 21 00:45:10 2016 Fix opt-in IME menu crash. The crash is caused by the unsafely accessing of |title_row_| in TrayDetailsView, which is null for opt-in IME menu. Fix the crash by adding the check of |title_row_|. TBR=tdanderson@chromium.org NOPRESUBMIT=true NOTRY=true BUG= 650287 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2390753006 Cr-Commit-Position: refs/heads/master@{#424049} (cherry picked from commit d13360c1060219cd5a2d8085fab433a8f49d414a) Review-Url: https://chromiumcodereview.appspot.com/2443443002 Cr-Commit-Position: refs/branch-heads/2883@{#226} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/ad916b7a758ede24c26836aa84315efb94bccbcd/ash/common/system/tray/tray_details_view.cc
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by shuchen@chromium.org
, Sep 27 2016Owner: azurewei@chromium.org
Status: Assigned (was: Untriaged)