https://www.chromium.org/developers/design-documents/mojo/mojo-migration-guide
Issue 637461 has been merged into this issue.
I'll have a stab at this mojo in Q4 2017.
Don't have cycles for this in Q4.
I'm going to do enums and AXNodeData. That will make the IPC work substantially easier.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/909f8e7a8f780809f5ade6b436e39d754dea4589 commit 909f8e7a8f780809f5ade6b436e39d754dea4589 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Wed Jan 24 20:37:04 2018 Add explicit typecasts to ui/accessibility enums. This patch is in preparation for switching the accessibility enums in ui/accessibility/ax_enums.idl to a .mojom file instead. Because the generated C++ headers from a .mojom file use enum class instead of enum, we need to explicitly cast anytime we use an enum as an int. Some helpers are added to AXNodeData for the most common cases. Bug: 650275 Change-Id: Icf2df4bdedb7faf6d1e7bd3ffd3639faa8c1409f Reviewed-on: https://chromium-review.googlesource.com/875551 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#531668} [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ash/system/audio/volume_view.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ash/system/ime_menu/ime_list_view.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ash/system/night_light/night_light_toggle_button.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ash/system/tray/hover_highlight_view.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/chrome/browser/ui/views/download/download_item_view.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/chrome/browser/ui/views/toolbar/toolbar_button.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/chrome/renderer/extensions/automation_internal_custom_bindings.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/components/pdf/renderer/pdf_accessibility_tree.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/content/browser/accessibility/accessibility_tree_formatter_blink.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/content/browser/accessibility/browser_accessibility.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/content/browser/accessibility/browser_accessibility_cocoa.mm [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/content/browser/accessibility/browser_accessibility_com_win.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/content/browser/accessibility/browser_accessibility_manager_unittest.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/content/browser/accessibility/browser_accessibility_win_unittest.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/content/browser/accessibility/one_shot_accessibility_tree_search.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/content/browser/accessibility/web_contents_accessibility_android.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/content/renderer/accessibility/blink_ax_enum_conversion.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/content/renderer/accessibility/blink_ax_enum_conversion.h [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/content/renderer/accessibility/blink_ax_tree_source.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ui/accessibility/ax_action_data.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ui/accessibility/ax_event_generator_unittest.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ui/accessibility/ax_node_data.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ui/accessibility/ax_node_data.h [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ui/accessibility/ax_node_position_unittest.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ui/accessibility/ax_tree.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ui/accessibility/ax_tree_unittest.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ui/accessibility/platform/ax_platform_node_auralinux.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ui/accessibility/platform/ax_platform_node_mac.mm [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ui/accessibility/platform/ax_platform_node_win.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ui/accessibility/platform/ax_platform_relation_win.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ui/accessibility/platform/ax_snapshot_node_android_platform.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ui/views/accessibility/view_accessibility.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ui/views/controls/button/button.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ui/views/controls/button/checkbox.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ui/views/controls/button/image_button.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ui/views/controls/button/menu_button.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ui/views/controls/button/toggle_button.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ui/views/controls/combobox/combobox.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ui/views/controls/menu/menu_item_view.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ui/views/controls/table/table_view.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/909f8e7a8f780809f5ade6b436e39d754dea4589/ui/views/controls/tree/tree_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcef1b73d8797d2e7d337601f9fa16c362ee91aa commit dcef1b73d8797d2e7d337601f9fa16c362ee91aa Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Fri Jan 26 17:57:04 2018 Convert ax_enums.idl to mojom. The accessibility enums were used in over 300 files and many of those uses depended on details of the bindings generated from the IDL file. To keep this as much of a pure refactoring as possible, this change does the following: * Implements Parse and ToString functions in ax_enum_util that match the behavior of the IDL bindings. * Explicitly adds a kNone and kLast item to every enum, to support code that iterates over enums. Bug: 650275 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6610169991ea1209629dab9a8c4c2c1f03c4116f Reviewed-on: https://chromium-review.googlesource.com/877417 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#531997} [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/BUILD.gn [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/accelerators/exit_warning_handler.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/accessibility/accessibility_controller.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/accessibility/accessibility_controller.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/accessibility/accessibility_delegate.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/ash_touch_exploration_manager_chromeos.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/ash_touch_exploration_manager_chromeos.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/ash_touch_exploration_manager_chromeos_unittest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/login/ui/login_bubble.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/login/ui/login_password_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/login/ui/non_accessible_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/message_center/message_center_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/message_center/notifier_settings_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/shelf/app_list_button.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/shelf/login_shelf_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/shelf/shelf_button.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/shelf/shelf_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/system/audio/volume_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/system/date/date_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/system/ime/tray_ime_chromeos.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/system/ime_menu/ime_list_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/system/ime_menu/ime_menu_tray_unittest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/system/network/network_state_list_detailed_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/system/network/tray_network.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/system/night_light/night_light_toggle_button.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/system/power/power_status_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/system/power/tray_power.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/system/toast/toast_overlay.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/system/tray/actionable_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/system/tray/hover_highlight_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/system/tray/system_tray_bubble.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/system/tray/tray_background_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/system/tray/tray_info_label.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/system/tray/tray_info_label_unittest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/system/tray_caps_lock.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/system/user/button_from_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/system/user/tray_user_unittest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/system/user/user_card_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/test/ash_test_views_delegate.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/test/ash_test_views_delegate.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/wm/overview/window_selector_item.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ash/wm/window_cycle_list.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/accessibility/accessibility_extension_api.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/accessibility/interstitial_accessibility_browsertest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/apps/guest_view/web_view_browsertest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/chromeos/accessibility/accessibility_manager.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service_browsertest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/chromeos/login/existing_user_controller.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/chromeos/ui/idle_app_name_notification_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/extensions/BUILD.gn [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/extensions/api/automation_internal/automation_event_router.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/pdf/pdf_extension_test.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/aura/accessibility/automation_manager_aura.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/aura/accessibility/automation_manager_aura_browsertest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/aura/accessibility/ax_root_obj_wrapper.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/aura/accessibility/ax_tree_source_aura.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/autofill/autofill_popup_controller_impl.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/chrome_views_delegate.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/chrome_views_delegate.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/conflicting_module_view_win.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/conflicting_module_view_win.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/critical_notification_bubble_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/desktop_capture/desktop_media_list_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/desktop_capture/desktop_media_source_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/download/download_item_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/frame/browser_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/hover_button_unittest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/infobars/infobar_container_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/infobars/infobar_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/location_bar/bubble_icon_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/location_bar/location_icon_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/omnibox/omnibox_result_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/omnibox/omnibox_result_view_unittest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/page_info/non_accessible_image_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/page_info/page_info_bubble_view_browsertest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/page_info/page_info_bubble_view_unittest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/tabs/tab.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/tabs/tab_strip.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/toolbar/app_menu.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/toolbar/browser_actions_container.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/toolbar/toolbar_action_view.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/toolbar/toolbar_action_view_unittest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/ui/views/toolbar/toolbar_button.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/common/extensions/api/BUILD.gn [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/common/extensions/chrome_extension_messages.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/renderer/extensions/automation_ax_tree_wrapper.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/renderer/extensions/automation_internal_custom_bindings.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/chrome/test/chromedriver/BUILD.gn [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/components/pdf/renderer/pdf_accessibility_tree.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/components/pdf/renderer/pdf_accessibility_tree.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/components/pdf/renderer/pdf_accessibility_tree_browsertest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/BUILD.gn [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/accessibility_action_browsertest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/accessibility_ipc_error_browsertest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/accessibility_mode_browsertest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/accessibility_tree_formatter_blink.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/accessibility_tree_formatter_blink.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/accessibility_win_browsertest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/android_granularity_movement_browsertest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/browser_accessibility.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/browser_accessibility.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/browser_accessibility_android.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/browser_accessibility_android.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/browser_accessibility_cocoa.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/browser_accessibility_cocoa.mm [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/browser_accessibility_com_win.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/browser_accessibility_com_win.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/browser_accessibility_mac_unittest.mm [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/browser_accessibility_manager.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/browser_accessibility_manager.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/browser_accessibility_manager_android.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/browser_accessibility_manager_android.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/browser_accessibility_manager_auralinux.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/browser_accessibility_manager_auralinux.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/browser_accessibility_manager_mac.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/browser_accessibility_manager_mac.mm [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/browser_accessibility_manager_unittest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/browser_accessibility_manager_win.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/browser_accessibility_manager_win.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/browser_accessibility_position.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/browser_accessibility_win_unittest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/cross_platform_accessibility_browsertest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/dump_accessibility_browsertest_base.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/dump_accessibility_events_browsertest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/fullscreen_browsertest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/hit_testing_browsertest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/one_shot_accessibility_tree_search.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/one_shot_accessibility_tree_search_unittest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/site_per_process_accessibility_browsertest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/snapshot_ax_tree_browsertest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/touch_accessibility_aura_browsertest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/accessibility/web_contents_accessibility_android.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/browser/frame_host/render_frame_host_impl.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/common/accessibility_messages.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/public/android/BUILD.gn [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/public/browser/ax_event_notification_details.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/public/browser/ax_event_notification_details.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/public/common/common_param_traits_macros.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/public/test/browser_test_utils.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/renderer/accessibility/aom_content_ax_tree.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/renderer/accessibility/blink_ax_enum_conversion.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/renderer/accessibility/blink_ax_enum_conversion.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/renderer/accessibility/blink_ax_tree_source.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/renderer/accessibility/render_accessibility_impl.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/renderer/accessibility/render_accessibility_impl.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/renderer/accessibility/render_accessibility_impl_browsertest.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/renderer/browser_plugin/browser_plugin.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/test/BUILD.gn [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/test/accessibility_browser_test_utils.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/content/test/accessibility_browser_test_utils.h [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/docs/accessibility/overview.md [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/tools/ipc_fuzzer/message_lib/BUILD.gn [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ui/accessibility/BUILD.gn [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ui/accessibility/OWNERS [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ui/accessibility/PRESUBMIT.py [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ui/accessibility/ax_action_data.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ui/accessibility/ax_action_data.h [add] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ui/accessibility/ax_enum_util.cc [add] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ui/accessibility/ax_enum_util.h [add] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ui/accessibility/ax_enums.mojom [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ui/accessibility/ax_event_generator.cc [modify] https://crrev.com/dcef1b73d8797d2e7d337601f9fa16c362ee91aa/ui/accessibility/ax_event_generator.h [modi
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ab70d2341cbe4f086a8b7bf1187de4c74fc9762 commit 3ab70d2341cbe4f086a8b7bf1187de4c74fc9762 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Mon Jan 29 21:17:49 2018 Clean-up after migration from ax_enums.idl to ax_enums.mojom The idl file should be removed, and a couple of comments got missed. TBR=dcheng@chromium.org Bug: 650275 Change-Id: Ic36c71da5234bd9f0808f005c967147a11e45e27 Reviewed-on: https://chromium-review.googlesource.com/889043 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#532590} [delete] https://crrev.com/af66ebcd045e4ea75e4cb09de214dee9cab73563/ui/accessibility/ax_enums.idl [modify] https://crrev.com/3ab70d2341cbe4f086a8b7bf1187de4c74fc9762/ui/accessibility/ax_enums.mojom [modify] https://crrev.com/3ab70d2341cbe4f086a8b7bf1187de4c74fc9762/ui/views/controls/combobox/combobox.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/781c933c7aa7f9bc468851239cd23c6b475e9e06 commit 781c933c7aa7f9bc468851239cd23c6b475e9e06 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Sat Apr 07 04:40:08 2018 Mojoify AXNodeData. BUG=650275 Change-Id: I1d4f4fff1868b115d55b3242ef82fcd2a71bf9a8 Reviewed-on: https://chromium-review.googlesource.com/996793 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#549034} [modify] https://crrev.com/781c933c7aa7f9bc468851239cd23c6b475e9e06/mojo/public/tools/bindings/chromium_bindings_configuration.gni [modify] https://crrev.com/781c933c7aa7f9bc468851239cd23c6b475e9e06/ui/accessibility/BUILD.gn [modify] https://crrev.com/781c933c7aa7f9bc468851239cd23c6b475e9e06/ui/accessibility/DEPS [add] https://crrev.com/781c933c7aa7f9bc468851239cd23c6b475e9e06/ui/accessibility/mojom/BUILD.gn [add] https://crrev.com/781c933c7aa7f9bc468851239cd23c6b475e9e06/ui/accessibility/mojom/OWNERS [add] https://crrev.com/781c933c7aa7f9bc468851239cd23c6b475e9e06/ui/accessibility/mojom/ax_node_data.mojom [add] https://crrev.com/781c933c7aa7f9bc468851239cd23c6b475e9e06/ui/accessibility/mojom/ax_node_data.typemap [add] https://crrev.com/781c933c7aa7f9bc468851239cd23c6b475e9e06/ui/accessibility/mojom/ax_node_data_mojom_traits.cc [add] https://crrev.com/781c933c7aa7f9bc468851239cd23c6b475e9e06/ui/accessibility/mojom/ax_node_data_mojom_traits.h [add] https://crrev.com/781c933c7aa7f9bc468851239cd23c6b475e9e06/ui/accessibility/mojom/ax_node_data_mojom_traits_unittest.cc [add] https://crrev.com/781c933c7aa7f9bc468851239cd23c6b475e9e06/ui/accessibility/mojom/typemaps.gni [add] https://crrev.com/781c933c7aa7f9bc468851239cd23c6b475e9e06/ui/accessibility/run_all_unittests.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfbc431a93d8c072a51985ee785a01c31645e100 commit bfbc431a93d8c072a51985ee785a01c31645e100 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Tue Apr 10 02:16:13 2018 Mojoify AXTreeData and AXTreeUpdate. Bug: 650275 Change-Id: I4d0120f649809f8b4d9a4b6447b7774a259ae584 Reviewed-on: https://chromium-review.googlesource.com/1000966 Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#549381} [modify] https://crrev.com/bfbc431a93d8c072a51985ee785a01c31645e100/ui/accessibility/BUILD.gn [modify] https://crrev.com/bfbc431a93d8c072a51985ee785a01c31645e100/ui/accessibility/mojom/BUILD.gn [add] https://crrev.com/bfbc431a93d8c072a51985ee785a01c31645e100/ui/accessibility/mojom/ax_tree_data.mojom [add] https://crrev.com/bfbc431a93d8c072a51985ee785a01c31645e100/ui/accessibility/mojom/ax_tree_data.typemap [add] https://crrev.com/bfbc431a93d8c072a51985ee785a01c31645e100/ui/accessibility/mojom/ax_tree_data_mojom_traits.cc [add] https://crrev.com/bfbc431a93d8c072a51985ee785a01c31645e100/ui/accessibility/mojom/ax_tree_data_mojom_traits.h [add] https://crrev.com/bfbc431a93d8c072a51985ee785a01c31645e100/ui/accessibility/mojom/ax_tree_data_mojom_traits_unittest.cc [add] https://crrev.com/bfbc431a93d8c072a51985ee785a01c31645e100/ui/accessibility/mojom/ax_tree_update.mojom [add] https://crrev.com/bfbc431a93d8c072a51985ee785a01c31645e100/ui/accessibility/mojom/ax_tree_update.typemap [add] https://crrev.com/bfbc431a93d8c072a51985ee785a01c31645e100/ui/accessibility/mojom/ax_tree_update_mojom_traits.cc [add] https://crrev.com/bfbc431a93d8c072a51985ee785a01c31645e100/ui/accessibility/mojom/ax_tree_update_mojom_traits.h [add] https://crrev.com/bfbc431a93d8c072a51985ee785a01c31645e100/ui/accessibility/mojom/ax_tree_update_mojom_traits_unittest.cc [modify] https://crrev.com/bfbc431a93d8c072a51985ee785a01c31645e100/ui/accessibility/mojom/typemaps.gni
Comment 1 by dmazz...@chromium.org
, Mar 27 2017